From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH, once again] regulator: core: avoid unused variable warning
Date: Fri, 20 Nov 2015 12:24:00 +0000 [thread overview]
Message-ID: <20151120122400.GA1929@sirena.org.uk> (raw)
In-Reply-To: <15541673.tdJ35xzzlG@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Fri, Nov 20, 2015 at 01:12:00PM +0100, Arnd Bergmann wrote:
> On Friday 20 November 2015 11:41:27 Mark Brown wrote:
> > Can we please at least have a comment explaining that this is working
> > around lockdep limitations?
> Not sure which limitation you are referring to. Maybe you could just
> modify the changelog text as you like when applying the patch?
> I tried to capture the fact that mutex_lock_nested() intentionally
> doesn't evaluate its second argument when CONFIG_DEBUG_LOCK_ALLOC
> is not set, but that appears to be less of a limitation than a
> choice of the interface.
That's the limitation (or intereface choice or whatever) that I'm
talking about - the code looks like a function call so not evaulating
the second argument is surprising. I'm looking for something in the
code rather than the changelog so it doesn't get cleaned up later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, once again] regulator: core: avoid unused variable warning
Date: Fri, 20 Nov 2015 12:24:00 +0000 [thread overview]
Message-ID: <20151120122400.GA1929@sirena.org.uk> (raw)
In-Reply-To: <15541673.tdJ35xzzlG@wuerfel>
On Fri, Nov 20, 2015 at 01:12:00PM +0100, Arnd Bergmann wrote:
> On Friday 20 November 2015 11:41:27 Mark Brown wrote:
> > Can we please at least have a comment explaining that this is working
> > around lockdep limitations?
> Not sure which limitation you are referring to. Maybe you could just
> modify the changelog text as you like when applying the patch?
> I tried to capture the fact that mutex_lock_nested() intentionally
> doesn't evaluate its second argument when CONFIG_DEBUG_LOCK_ALLOC
> is not set, but that appears to be less of a limitation than a
> choice of the interface.
That's the limitation (or intereface choice or whatever) that I'm
talking about - the code looks like a function call so not evaulating
the second argument is surprising. I'm looking for something in the
code rather than the changelog so it doesn't get cleaned up later.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151120/5b9d2824/attachment.sig>
next prev parent reply other threads:[~2015-11-20 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 11:30 [PATCH, once again] regulator: core: avoid unused variable warning Arnd Bergmann
2015-11-20 11:30 ` Arnd Bergmann
2015-11-20 11:41 ` Mark Brown
2015-11-20 11:41 ` Mark Brown
2015-11-20 12:12 ` Arnd Bergmann
2015-11-20 12:12 ` Arnd Bergmann
2015-11-20 12:24 ` Mark Brown [this message]
2015-11-20 12:24 ` Mark Brown
2015-11-20 12:28 ` Arnd Bergmann
2015-11-20 12:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151120122400.GA1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.