[asoc:topic/intel 36/41] sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address

[asoc:topic/intel 36/41] sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel
head:   314038e40a62c7cdfc07aad0fe14dcd4383bc34d
commit: ae395937ab95b8c62806af6a17a6cdfe6086401e [36/41] ASoC: Intel: Skylake: Fix cleanup of dma buffer


coccinelle warnings: (new ones prefixed by >>)

>> sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address
   sound/soc/intel/skylake/skl-sst-cldma.c:143:1-3: ERROR: test of a variable/field address

vim +141 sound/soc/intel/skylake/skl-sst-cldma.c

   125	
   126		sst_dsp_shim_update_bits(ctx, SKL_ADSP_REG_CL_SD_CTL,
   127					CL_SD_CTL_IOCE_MASK, CL_SD_CTL_IOCE(0));
   128		sst_dsp_shim_update_bits(ctx, SKL_ADSP_REG_CL_SD_CTL,
   129					CL_SD_CTL_FEIE_MASK, CL_SD_CTL_FEIE(0));
   130		sst_dsp_shim_update_bits(ctx, SKL_ADSP_REG_CL_SD_CTL,
   131					CL_SD_CTL_DEIE_MASK, CL_SD_CTL_DEIE(0));
   132		sst_dsp_shim_update_bits(ctx, SKL_ADSP_REG_CL_SD_CTL,
   133					CL_SD_CTL_STRM_MASK, CL_SD_CTL_STRM(0));
   134	
   135		sst_dsp_shim_write(ctx, SKL_ADSP_REG_CL_SD_BDLPL, CL_SD_BDLPLBA(0));
   136		sst_dsp_shim_write(ctx, SKL_ADSP_REG_CL_SD_BDLPU, 0);
   137	
   138		sst_dsp_shim_write(ctx, SKL_ADSP_REG_CL_SD_CBL, 0);
   139		sst_dsp_shim_write(ctx, SKL_ADSP_REG_CL_SD_LVI, 0);
   140	
 > 141		if (&ctx->cl_dev.dmab_data)
   142			ctx->dsp_ops.free_dma_buf(ctx->dev, &ctx->cl_dev.dmab_data);
   143		if (&ctx->cl_dev.dmab_bdl)
   144			ctx->dsp_ops.free_dma_buf(ctx->dev, &ctx->cl_dev.dmab_bdl);
   145	}
   146	
   147	static int skl_cldma_wait_interruptible(struct sst_dsp *ctx)
   148	{
   149		int ret = 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Re: [asoc:topic/intel 36/41] sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address

[Vinod Koul]

On Fri, Nov 20, 2015 at 05:59:04PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel
> head:   314038e40a62c7cdfc07aad0fe14dcd4383bc34d
> commit: ae395937ab95b8c62806af6a17a6cdfe6086401e [36/41] ASoC: Intel: Skylake: Fix cleanup of dma buffer
> 
> 
Thanks for the report,

Will send a fix for this shortly

-- 
~Vinod

Re: [asoc:topic/intel 36/41] sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address

[Vinod Koul]

On Fri, Nov 20, 2015 at 05:59:04PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel
> head:   314038e40a62c7cdfc07aad0fe14dcd4383bc34d
> commit: ae395937ab95b8c62806af6a17a6cdfe6086401e [36/41] ASoC: Intel: Skylake: Fix cleanup of dma buffer
> 
> 
> coccinelle warnings: (new ones prefixed by >>)
> 
> >> sound/soc/intel/skylake/skl-sst-cldma.c:141:1-3: ERROR: test of a variable/field address
>    sound/soc/intel/skylake/skl-sst-cldma.c:143:1-3: ERROR: test of a variable/field address

Yes these are field address so should not be checked, will send a fix

-- 
~Vinod