From: Dan Carpenter <dan.carpenter@oracle.com> To: David Airlie <airlied@linux.ie> Cc: Thomas Hellstrom <thellstrom@vmware.com>, kernel-janitors@vger.kernel.org, Jakob Bornecrantz <jakob@vmware.com>, dri-devel@lists.freedesktop.org, Brian Paul <brianp@vmware.com>, Charmaine Lee <charmainel@vmware.com> Subject: [patch] drm/vmwgfx: fix a warning message Date: Sat, 21 Nov 2015 10:29:39 +0000 [thread overview] Message-ID: <20151121102939.GB7002@mwanda> (raw) The WARN_ON() macro only takes a condition argument, it doesn't take a message. I have converted this to WARN() instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c index a8baf5f..b6a0806 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes, else if (ctx_id = SVGA3D_INVALID_ID) ret = vmw_local_fifo_reserve(dev_priv, bytes); else { - WARN_ON("Command buffer has not been allocated.\n"); + WARN(1, "Command buffer has not been allocated.\n"); ret = NULL; } if (IS_ERR_OR_NULL(ret)) {
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: David Airlie <airlied@linux.ie> Cc: Thomas Hellstrom <thellstrom@vmware.com>, kernel-janitors@vger.kernel.org, Jakob Bornecrantz <jakob@vmware.com>, dri-devel@lists.freedesktop.org, Brian Paul <brianp@vmware.com>, Charmaine Lee <charmainel@vmware.com> Subject: [patch] drm/vmwgfx: fix a warning message Date: Sat, 21 Nov 2015 13:29:39 +0300 [thread overview] Message-ID: <20151121102939.GB7002@mwanda> (raw) The WARN_ON() macro only takes a condition argument, it doesn't take a message. I have converted this to WARN() instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c index a8baf5f..b6a0806 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes, else if (ctx_id == SVGA3D_INVALID_ID) ret = vmw_local_fifo_reserve(dev_priv, bytes); else { - WARN_ON("Command buffer has not been allocated.\n"); + WARN(1, "Command buffer has not been allocated.\n"); ret = NULL; } if (IS_ERR_OR_NULL(ret)) { _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-11-21 10:29 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-21 10:29 Dan Carpenter [this message] 2015-11-21 10:29 ` [patch] drm/vmwgfx: fix a warning message Dan Carpenter 2015-11-24 19:55 ` Sinclair Yeh 2015-11-24 19:55 ` Sinclair Yeh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151121102939.GB7002@mwanda \ --to=dan.carpenter@oracle.com \ --cc=airlied@linux.ie \ --cc=brianp@vmware.com \ --cc=charmainel@vmware.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jakob@vmware.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=thellstrom@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.