* [PATCH] mtd: brcmnand: drop brcmnand_host::of_node field
@ 2015-12-01 2:01 Brian Norris
2015-12-01 17:17 ` Scott Branden
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2015-12-01 2:01 UTC (permalink / raw)
To: linux-mtd
Cc: Brian Norris, Julia Lawall, bcm-kernel-feedback-list, Kamal Dasu
We don't actually need to stash a copy of this device_node indefinitely;
we only need it in brcmnand_init_cs().
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: <bcm-kernel-feedback-list@broadcom.com>
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/mtd/nand/brcmnand/brcmnand.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
index ad756f626f4b..35d78f739d91 100644
--- a/drivers/mtd/nand/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/brcmnand/brcmnand.c
@@ -176,7 +176,6 @@ struct brcmnand_cfg {
struct brcmnand_host {
struct list_head node;
- struct device_node *of_node;
struct nand_chip chip;
struct mtd_info mtd;
@@ -1902,10 +1901,9 @@ static int brcmnand_setup_dev(struct brcmnand_host *host)
return 0;
}
-static int brcmnand_init_cs(struct brcmnand_host *host)
+static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
{
struct brcmnand_controller *ctrl = host->ctrl;
- struct device_node *dn = host->of_node;
struct platform_device *pdev = host->pdev;
struct mtd_info *mtd;
struct nand_chip *chip;
@@ -2239,9 +2237,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
}
host->pdev = pdev;
host->ctrl = ctrl;
- host->of_node = child;
- ret = brcmnand_init_cs(host);
+ ret = brcmnand_init_cs(host, child);
if (ret) {
devm_kfree(dev, host);
continue; /* Try all chip-selects */
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: brcmnand: drop brcmnand_host::of_node field
2015-12-01 2:01 [PATCH] mtd: brcmnand: drop brcmnand_host::of_node field Brian Norris
@ 2015-12-01 17:17 ` Scott Branden
2015-12-01 19:19 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Scott Branden @ 2015-12-01 17:17 UTC (permalink / raw)
To: Brian Norris, linux-mtd
Cc: Julia Lawall, bcm-kernel-feedback-list, Kamal Dasu
Looks good.
On 15-11-30 06:01 PM, Brian Norris wrote:
> We don't actually need to stash a copy of this device_node indefinitely;
> we only need it in brcmnand_init_cs().
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: <bcm-kernel-feedback-list@broadcom.com>
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Acked-by: Scott Branden <sbranden@broadcom.com>
> ---
> drivers/mtd/nand/brcmnand/brcmnand.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index ad756f626f4b..35d78f739d91 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -176,7 +176,6 @@ struct brcmnand_cfg {
>
> struct brcmnand_host {
> struct list_head node;
> - struct device_node *of_node;
>
> struct nand_chip chip;
> struct mtd_info mtd;
> @@ -1902,10 +1901,9 @@ static int brcmnand_setup_dev(struct brcmnand_host *host)
> return 0;
> }
>
> -static int brcmnand_init_cs(struct brcmnand_host *host)
> +static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
> {
> struct brcmnand_controller *ctrl = host->ctrl;
> - struct device_node *dn = host->of_node;
> struct platform_device *pdev = host->pdev;
> struct mtd_info *mtd;
> struct nand_chip *chip;
> @@ -2239,9 +2237,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
> }
> host->pdev = pdev;
> host->ctrl = ctrl;
> - host->of_node = child;
>
> - ret = brcmnand_init_cs(host);
> + ret = brcmnand_init_cs(host, child);
> if (ret) {
> devm_kfree(dev, host);
> continue; /* Try all chip-selects */
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: brcmnand: drop brcmnand_host::of_node field
2015-12-01 17:17 ` Scott Branden
@ 2015-12-01 19:19 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-12-01 19:19 UTC (permalink / raw)
To: Scott Branden
Cc: linux-mtd, Julia Lawall, bcm-kernel-feedback-list, Kamal Dasu
On Tue, Dec 01, 2015 at 09:17:27AM -0800, Scott Branden wrote:
> Looks good.
>
> On 15-11-30 06:01 PM, Brian Norris wrote:
> >We don't actually need to stash a copy of this device_node indefinitely;
> >we only need it in brcmnand_init_cs().
> >
> >Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> >Cc: <bcm-kernel-feedback-list@broadcom.com>
> >Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Acked-by: Scott Branden <sbranden@broadcom.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-01 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-01 2:01 [PATCH] mtd: brcmnand: drop brcmnand_host::of_node field Brian Norris
2015-12-01 17:17 ` Scott Branden
2015-12-01 19:19 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.