All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oom kill init lead panic
@ 2015-12-02  6:30 ` chenjie6
  0 siblings, 0 replies; 7+ messages in thread
From: chenjie6 @ 2015-12-02  6:30 UTC (permalink / raw)
  To: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao
  Cc: chenjie6, lizefan, akpm, stable

From: chenjie <chenjie6@huawei.com>

when oom happened we can see:
Out of memory: Kill process 9134 (init) score 3 or sacrifice child
Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
Kill process 1 (init) sharing same memory
...
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009

That's because:
        the busybox init will vfork a process,oom_kill_process found
the init not the children,their mm is the same when vfork.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chen Jie <chenjie6@huawei.com>

---
 mm/oom_kill.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index d13a339..a0ddebd 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -608,6 +608,8 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p,
 			continue;
 		if (unlikely(p->flags & PF_KTHREAD))
 			continue;
+		if (!is_global_init(p))
+			continue;
 		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
 			continue;
 
-- 
1.8.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] oom kill init lead panic
@ 2015-12-02  6:30 ` chenjie6
  0 siblings, 0 replies; 7+ messages in thread
From: chenjie6 @ 2015-12-02  6:30 UTC (permalink / raw)
  To: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao
  Cc: chenjie6, lizefan, akpm, stable

From: chenjie <chenjie6@huawei.com>

when oom happened we can see:
Out of memory: Kill process 9134 (init) score 3 or sacrifice child
Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
Kill process 1 (init) sharing same memory
...
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009

That's because:
        the busybox init will vfork a process,oom_kill_process found
the init not the children,their mm is the same when vfork.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chen Jie <chenjie6@huawei.com>

---
 mm/oom_kill.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index d13a339..a0ddebd 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -608,6 +608,8 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p,
 			continue;
 		if (unlikely(p->flags & PF_KTHREAD))
 			continue;
+		if (!is_global_init(p))
+			continue;
 		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
 			continue;
 
-- 
1.8.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] oom kill init lead panic
@ 2015-12-02  6:30 ` chenjie6
  0 siblings, 0 replies; 7+ messages in thread
From: chenjie6 @ 2015-12-02  6:30 UTC (permalink / raw)
  To: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao
  Cc: chenjie6, lizefan, akpm, stable

From: chenjie <chenjie6@huawei.com>

when oom happened we can see:
Out of memory: Kill process 9134 (init) score 3 or sacrifice child
Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
Kill process 1 (init) sharing same memory
...
Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009

That's because:
        the busybox init will vfork a process,oom_kill_process found
the init not the children,their mm is the same when vfork.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chen Jie <chenjie6@huawei.com>

---
 mm/oom_kill.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index d13a339..a0ddebd 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -608,6 +608,8 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p,
 			continue;
 		if (unlikely(p->flags & PF_KTHREAD))
 			continue;
+		if (!is_global_init(p))
+			continue;
 		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
 			continue;
 
-- 
1.8.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] oom kill init lead panic
  2015-12-02  6:30 ` chenjie6
@ 2015-12-02 10:35   ` Michal Hocko
  -1 siblings, 0 replies; 7+ messages in thread
From: Michal Hocko @ 2015-12-02 10:35 UTC (permalink / raw)
  To: chenjie6
  Cc: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao, lizefan,
	akpm, stable

On Wed 02-12-15 14:30:56, chenjie6@huawei.com wrote:
> From: chenjie <chenjie6@huawei.com>
> 
> when oom happened we can see:
> Out of memory: Kill process 9134 (init) score 3 or sacrifice child
> Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
> Kill process 1 (init) sharing same memory
> ...
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009
> 
> That's because:
>         the busybox init will vfork a process,oom_kill_process found
> the init not the children,their mm is the same when vfork.

It is quite unlikely that killing the task would help to free much
memory so if this is really the only oom victim it is to be expected to
panic sooner or later but this is in line with oom_unkillable_task()
so it makes sense.
 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chen Jie <chenjie6@huawei.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> 
> ---
>  mm/oom_kill.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index d13a339..a0ddebd 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -608,6 +608,8 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p,
>  			continue;
>  		if (unlikely(p->flags & PF_KTHREAD))
>  			continue;
> +		if (!is_global_init(p))
> +			continue;
>  		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>  			continue;
>  
> -- 
> 1.8.0
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] oom kill init lead panic
@ 2015-12-02 10:35   ` Michal Hocko
  0 siblings, 0 replies; 7+ messages in thread
From: Michal Hocko @ 2015-12-02 10:35 UTC (permalink / raw)
  To: chenjie6
  Cc: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao, lizefan,
	akpm, stable

On Wed 02-12-15 14:30:56, chenjie6@huawei.com wrote:
> From: chenjie <chenjie6@huawei.com>
> 
> when oom happened we can see:
> Out of memory: Kill process 9134 (init) score 3 or sacrifice child
> Killed process 9134 (init) total-vm:1868kB, anon-rss:84kB, file-rss:572kB
> Kill process 1 (init) sharing same memory
> ...
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000009
> 
> That's because:
>         the busybox init will vfork a process,oom_kill_process found
> the init not the children,their mm is the same when vfork.

It is quite unlikely that killing the task would help to free much
memory so if this is really the only oom victim it is to be expected to
panic sooner or later but this is in line with oom_unkillable_task()
so it makes sense.
 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chen Jie <chenjie6@huawei.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> 
> ---
>  mm/oom_kill.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index d13a339..a0ddebd 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -608,6 +608,8 @@ void oom_kill_process(struct oom_control *oc, struct task_struct *p,
>  			continue;
>  		if (unlikely(p->flags & PF_KTHREAD))
>  			continue;
> +		if (!is_global_init(p))
> +			continue;
>  		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
>  			continue;
>  
> -- 
> 1.8.0
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] oom kill init lead panic
  2015-12-02  6:30 ` chenjie6
@ 2015-12-02 15:47   ` Greg KH
  -1 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-12-02 15:47 UTC (permalink / raw)
  To: chenjie6
  Cc: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao, lizefan,
	akpm, stable

On Wed, Dec 02, 2015 at 02:30:56PM +0800, chenjie6@huawei.com wrote:
> From: chenjie <chenjie6@huawei.com>

This name should match...

> Signed-off-by: Chen Jie <chenjie6@huawei.com>

this name please.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] oom kill init lead panic
@ 2015-12-02 15:47   ` Greg KH
  0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-12-02 15:47 UTC (permalink / raw)
  To: chenjie6
  Cc: linux-mm, linux-kernel, David.Woodhouse, zhihui.gao, lizefan,
	akpm, stable

On Wed, Dec 02, 2015 at 02:30:56PM +0800, chenjie6@huawei.com wrote:
> From: chenjie <chenjie6@huawei.com>

This name should match...

> Signed-off-by: Chen Jie <chenjie6@huawei.com>

this name please.

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-02 15:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-02  6:30 [PATCH] oom kill init lead panic chenjie6
2015-12-02  6:30 ` chenjie6
2015-12-02  6:30 ` chenjie6
2015-12-02 10:35 ` Michal Hocko
2015-12-02 10:35   ` Michal Hocko
2015-12-02 15:47 ` Greg KH
2015-12-02 15:47   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.