* [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()
@ 2015-11-21 11:14 Lars-Peter Clausen
2015-12-04 23:39 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2015-11-21 11:14 UTC (permalink / raw)
To: Brian Norris, David Woodhouse
Cc: Maxim Levitsky, linux-mtd, Lars-Peter Clausen
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
free_irq(irq, ...);
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/mtd/nand/r852.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/r852.c b/drivers/mtd/nand/r852.c
index d8bb2be..be28cdd 100644
--- a/drivers/mtd/nand/r852.c
+++ b/drivers/mtd/nand/r852.c
@@ -980,7 +980,6 @@ static void r852_remove(struct pci_dev *pci_dev)
/* Stop interrupts */
r852_disable_irqs(dev);
- synchronize_irq(dev->irq);
free_irq(dev->irq, dev);
/* Cleanup */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq()
2015-11-21 11:14 [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq() Lars-Peter Clausen
@ 2015-12-04 23:39 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-12-04 23:39 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: David Woodhouse, linux-mtd, Maxim Levitsky
On Sat, Nov 21, 2015 at 12:14:44PM +0100, Lars-Peter Clausen wrote:
> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered, on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.
>
> Patch was generated using the following semantic patch:
> // <smpl>
> @@
> expression irq;
> @@
> -synchronize_irq(irq);
> free_irq(irq, ...);
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-04 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-21 11:14 [PATCH] mtd: nand: r852: Remove unnecessary synchronize_irq() before free_irq() Lars-Peter Clausen
2015-12-04 23:39 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.