* [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node
@ 2015-11-26 9:19 Mugunthan V N
2015-11-26 17:49 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mugunthan V N @ 2015-11-26 9:19 UTC (permalink / raw)
To: u-boot
With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all
TI platforms are broken with DM/DT boot as ns16550 driver expects
reg-shift from DT which is not populated for TI platforms.
Earlier it worked as it was hard coded to 2 in serial-omap
driver. So adding the reg-shift to serial nodes for dra7, am4372
and am33xx dtsi files. Tested this patch on am437x-sk-evm,
am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm.
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
reg-shift was hard coded to 2 in both u-boot and kernel driver,
so the DT entry was never added in TI platforms.
Sending this fix first to u-boot as dm boot of TI platforms are
failing to boot. Will be submitting the patch kernel also ASAP.
---
arch/arm/dts/am33xx.dtsi | 6 ++++++
arch/arm/dts/am4372.dtsi | 6 ++++++
arch/arm/dts/dra7.dtsi | 10 ++++++++++
3 files changed, 22 insertions(+)
diff --git a/arch/arm/dts/am33xx.dtsi b/arch/arm/dts/am33xx.dtsi
index 21fcc44..b26e21b 100644
--- a/arch/arm/dts/am33xx.dtsi
+++ b/arch/arm/dts/am33xx.dtsi
@@ -214,6 +214,7 @@
ti,hwmods = "uart1";
clock-frequency = <48000000>;
reg = <0x44e09000 0x2000>;
+ reg-shift = <2>;
interrupts = <72>;
status = "disabled";
dmas = <&edma 26>, <&edma 27>;
@@ -225,6 +226,7 @@
ti,hwmods = "uart2";
clock-frequency = <48000000>;
reg = <0x48022000 0x2000>;
+ reg-shift = <2>;
interrupts = <73>;
status = "disabled";
dmas = <&edma 28>, <&edma 29>;
@@ -236,6 +238,7 @@
ti,hwmods = "uart3";
clock-frequency = <48000000>;
reg = <0x48024000 0x2000>;
+ reg-shift = <2>;
interrupts = <74>;
status = "disabled";
dmas = <&edma 30>, <&edma 31>;
@@ -247,6 +250,7 @@
ti,hwmods = "uart4";
clock-frequency = <48000000>;
reg = <0x481a6000 0x2000>;
+ reg-shift = <2>;
interrupts = <44>;
status = "disabled";
};
@@ -256,6 +260,7 @@
ti,hwmods = "uart5";
clock-frequency = <48000000>;
reg = <0x481a8000 0x2000>;
+ reg-shift = <2>;
interrupts = <45>;
status = "disabled";
};
@@ -265,6 +270,7 @@
ti,hwmods = "uart6";
clock-frequency = <48000000>;
reg = <0x481aa000 0x2000>;
+ reg-shift = <2>;
interrupts = <46>;
status = "disabled";
};
diff --git a/arch/arm/dts/am4372.dtsi b/arch/arm/dts/am4372.dtsi
index ade28c7..3fffe1e 100644
--- a/arch/arm/dts/am4372.dtsi
+++ b/arch/arm/dts/am4372.dtsi
@@ -152,6 +152,7 @@
uart0: serial at 44e09000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x44e09000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart1";
};
@@ -159,6 +160,7 @@
uart1: serial at 48022000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x48022000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart2";
status = "disabled";
@@ -167,6 +169,7 @@
uart2: serial at 48024000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x48024000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart3";
status = "disabled";
@@ -175,6 +178,7 @@
uart3: serial at 481a6000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x481a6000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart4";
status = "disabled";
@@ -183,6 +187,7 @@
uart4: serial at 481a8000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x481a8000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart5";
status = "disabled";
@@ -191,6 +196,7 @@
uart5: serial at 481aa000 {
compatible = "ti,am4372-uart","ti,omap2-uart";
reg = <0x481aa000 0x2000>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart6";
status = "disabled";
diff --git a/arch/arm/dts/dra7.dtsi b/arch/arm/dts/dra7.dtsi
index 8f1e25b..feb3708 100644
--- a/arch/arm/dts/dra7.dtsi
+++ b/arch/arm/dts/dra7.dtsi
@@ -399,6 +399,7 @@
uart1: serial at 4806a000 {
compatible = "ti,omap4-uart";
reg = <0x4806a000 0x100>;
+ reg-shift = <2>;
interrupts-extended = <&crossbar_mpu GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart1";
clock-frequency = <48000000>;
@@ -410,6 +411,7 @@
uart2: serial at 4806c000 {
compatible = "ti,omap4-uart";
reg = <0x4806c000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart2";
clock-frequency = <48000000>;
@@ -421,6 +423,7 @@
uart3: serial at 48020000 {
compatible = "ti,omap4-uart";
reg = <0x48020000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart3";
clock-frequency = <48000000>;
@@ -432,6 +435,7 @@
uart4: serial at 4806e000 {
compatible = "ti,omap4-uart";
reg = <0x4806e000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart4";
clock-frequency = <48000000>;
@@ -443,6 +447,7 @@
uart5: serial at 48066000 {
compatible = "ti,omap4-uart";
reg = <0x48066000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart5";
clock-frequency = <48000000>;
@@ -454,6 +459,7 @@
uart6: serial at 48068000 {
compatible = "ti,omap4-uart";
reg = <0x48068000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart6";
clock-frequency = <48000000>;
@@ -465,6 +471,7 @@
uart7: serial at 48420000 {
compatible = "ti,omap4-uart";
reg = <0x48420000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart7";
clock-frequency = <48000000>;
@@ -474,6 +481,7 @@
uart8: serial at 48422000 {
compatible = "ti,omap4-uart";
reg = <0x48422000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart8";
clock-frequency = <48000000>;
@@ -483,6 +491,7 @@
uart9: serial at 48424000 {
compatible = "ti,omap4-uart";
reg = <0x48424000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 220 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart9";
clock-frequency = <48000000>;
@@ -492,6 +501,7 @@
uart10: serial at 4ae2b000 {
compatible = "ti,omap4-uart";
reg = <0x4ae2b000 0x100>;
+ reg-shift = <2>;
interrupts = <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
ti,hwmods = "uart10";
clock-frequency = <48000000>;
--
2.6.2.280.g74301d6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node
2015-11-26 9:19 [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node Mugunthan V N
@ 2015-11-26 17:49 ` Simon Glass
2015-11-27 12:32 ` Thomas Chou
2015-12-06 22:06 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-11-26 17:49 UTC (permalink / raw)
To: u-boot
On 26 November 2015 at 01:19, Mugunthan V N <mugunthanvnm@ti.com> wrote:
> With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all
> TI platforms are broken with DM/DT boot as ns16550 driver expects
> reg-shift from DT which is not populated for TI platforms.
> Earlier it worked as it was hard coded to 2 in serial-omap
> driver. So adding the reg-shift to serial nodes for dra7, am4372
> and am33xx dtsi files. Tested this patch on am437x-sk-evm,
> am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>
> reg-shift was hard coded to 2 in both u-boot and kernel driver,
> so the DT entry was never added in TI platforms.
>
> Sending this fix first to u-boot as dm boot of TI platforms are
> failing to boot. Will be submitting the patch kernel also ASAP.
>
> ---
> arch/arm/dts/am33xx.dtsi | 6 ++++++
> arch/arm/dts/am4372.dtsi | 6 ++++++
> arch/arm/dts/dra7.dtsi | 10 ++++++++++
> 3 files changed, 22 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node
2015-11-26 9:19 [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node Mugunthan V N
2015-11-26 17:49 ` Simon Glass
@ 2015-11-27 12:32 ` Thomas Chou
2015-12-06 22:06 ` [U-Boot] " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Chou @ 2015-11-27 12:32 UTC (permalink / raw)
To: u-boot
Hi Mugunthan,
On 2015?11?26? 17:19, Mugunthan V N wrote:
> With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all
> TI platforms are broken with DM/DT boot as ns16550 driver expects
> reg-shift from DT which is not populated for TI platforms.
> Earlier it worked as it was hard coded to 2 in serial-omap
> driver. So adding the reg-shift to serial nodes for dra7, am4372
> and am33xx dtsi files. Tested this patch on am437x-sk-evm,
> am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
>
> reg-shift was hard coded to 2 in both u-boot and kernel driver,
> so the DT entry was never added in TI platforms.
>
> Sending this fix first to u-boot as dm boot of TI platforms are
> failing to boot. Will be submitting the patch kernel also ASAP.
>
> ---
> arch/arm/dts/am33xx.dtsi | 6 ++++++
> arch/arm/dts/am4372.dtsi | 6 ++++++
> arch/arm/dts/dra7.dtsi | 10 ++++++++++
> 3 files changed, 22 insertions(+)
>
Acked-by: Thomas Chou <thomas@wytron.com.tw>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] arm: dts: omap: add reg-shift to serial device tree node
2015-11-26 9:19 [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node Mugunthan V N
2015-11-26 17:49 ` Simon Glass
2015-11-27 12:32 ` Thomas Chou
@ 2015-12-06 22:06 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2015-12-06 22:06 UTC (permalink / raw)
To: u-boot
On Thu, Nov 26, 2015 at 02:49:10PM +0530, Mugunthan V N wrote:
> With the commit 'c7b9686d5d48 ("ns16550: unify serial_omap")' all
> TI platforms are broken with DM/DT boot as ns16550 driver expects
> reg-shift from DT which is not populated for TI platforms.
> Earlier it worked as it was hard coded to 2 in serial-omap
> driver. So adding the reg-shift to serial nodes for dra7, am4372
> and am33xx dtsi files. Tested this patch on am437x-sk-evm,
> am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Acked-by: Thomas Chou <thomas@wytron.com.tw>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151206/b2a4d6fd/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-06 22:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-26 9:19 [U-Boot] [PATCH] arm: dts: omap: add reg-shift to serial device tree node Mugunthan V N
2015-11-26 17:49 ` Simon Glass
2015-11-27 12:32 ` Thomas Chou
2015-12-06 22:06 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.