All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA
@ 2015-12-07  9:09 Geert Uytterhoeven
  2015-12-07 11:12 ` Måns Rullgård
  2015-12-07 18:55 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-12-07  9:09 UTC (permalink / raw)
  To: Måns Rullgård, David S. Miller
  Cc: netdev, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
    ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/aurora/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
--- a/drivers/net/ethernet/aurora/Kconfig
+++ b/drivers/net/ethernet/aurora/Kconfig
@@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
 
 config AURORA_NB8800
 	tristate "Aurora AU-NB8800 support"
+	depends on HAS_DMA
 	select PHYLIB
 	help
 	 Support for the AU-NB8800 gigabit Ethernet controller.
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA
  2015-12-07  9:09 [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA Geert Uytterhoeven
@ 2015-12-07 11:12 ` Måns Rullgård
  2015-12-07 18:55 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Måns Rullgård @ 2015-12-07 11:12 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: David S. Miller, netdev, linux-kernel

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> If NO_DMA=y:
>
>     ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Mans Rullgard <mans@mansr.com>

>  drivers/net/ethernet/aurora/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/aurora/Kconfig b/drivers/net/ethernet/aurora/Kconfig
> index a3c7106fdf85e78f..8ba7f8ff3434000f 100644
> --- a/drivers/net/ethernet/aurora/Kconfig
> +++ b/drivers/net/ethernet/aurora/Kconfig
> @@ -13,6 +13,7 @@ if NET_VENDOR_AURORA
>
>  config AURORA_NB8800
>  	tristate "Aurora AU-NB8800 support"
> +	depends on HAS_DMA
>  	select PHYLIB
>  	help
>  	 Support for the AU-NB8800 gigabit Ethernet controller.
> -- 
> 1.9.1
>

-- 
Måns Rullgård
mans@mansr.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA
  2015-12-07  9:09 [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA Geert Uytterhoeven
  2015-12-07 11:12 ` Måns Rullgård
@ 2015-12-07 18:55 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-12-07 18:55 UTC (permalink / raw)
  To: geert; +Cc: mans, netdev, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon,  7 Dec 2015 10:09:06 +0100

> If NO_DMA=y:
> 
>     ERROR: "dma_map_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_sync_single_for_cpu" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/aurora/nb8800.ko] undefined!
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks Geert.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-07 18:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07  9:09 [PATCH] ethernet: aurora: AURORA_NB8800 should depend on HAS_DMA Geert Uytterhoeven
2015-12-07 11:12 ` Måns Rullgård
2015-12-07 18:55 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.