From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: remove mask fields from 'struct bb_info'
Date: Tue, 08 Dec 2015 00:42:21 +0000 [thread overview]
Message-ID: <20151208004221.GH10799@verge.net.au> (raw)
In-Reply-To: <8193175.UjRYeBy7vc@wasted.cogentembedded.com>
On Tue, Dec 08, 2015 at 12:40:19AM +0300, Sergei Shtylyov wrote:
> The MDIO control bits are always mapped to the same bits of the same register
> (PIR), so there's no need to store their masks in the 'struct bb_info'...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: remove mask fields from 'struct bb_info'
Date: Tue, 8 Dec 2015 09:42:21 +0900 [thread overview]
Message-ID: <20151208004221.GH10799@verge.net.au> (raw)
In-Reply-To: <8193175.UjRYeBy7vc@wasted.cogentembedded.com>
On Tue, Dec 08, 2015 at 12:40:19AM +0300, Sergei Shtylyov wrote:
> The MDIO control bits are always mapped to the same bits of the same register
> (PIR), so there's no need to store their masks in the 'struct bb_info'...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2015-12-08 0:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 21:39 [PATCH 0/3] sh_eth: optimize MDIO code Sergei Shtylyov
2015-12-07 21:39 ` Sergei Shtylyov
2015-12-07 21:40 ` [PATCH 1/3] sh_eth: remove mask fields from 'struct bb_info' Sergei Shtylyov
2015-12-07 21:40 ` Sergei Shtylyov
2015-12-08 0:42 ` Simon Horman [this message]
2015-12-08 0:42 ` Simon Horman
2015-12-07 21:40 ` [PATCH 2/3] sh_eth: factor out common code from MDIO bitbang methods Sergei Shtylyov
2015-12-07 21:40 ` Sergei Shtylyov
2015-12-08 0:42 ` Simon Horman
2015-12-08 0:42 ` Simon Horman
2015-12-07 21:41 ` [PATCH 3/3] sh_eth: get rid of bb_{set|clr|read}() Sergei Shtylyov
2015-12-07 21:41 ` Sergei Shtylyov
2015-12-08 0:42 ` Simon Horman
2015-12-08 0:42 ` Simon Horman
2015-12-09 2:56 ` [PATCH 0/3] sh_eth: optimize MDIO code David Miller
2015-12-09 2:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208004221.GH10799@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.