* [PATCH] mkfs.ubifs: use gid from table instead 2x uid
@ 2014-08-22 16:49 Sebastian Andrzej Siewior
2015-12-10 0:05 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2014-08-22 16:49 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: Sebastian Andrzej Siewior, Brian Norris, linux-mtd
If the devtable is used then the tool uses uid twice and doesn't
consider gid at all. This changes it to use gid & uid.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
mkfs.ubifs/mkfs.ubifs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs.ubifs/mkfs.ubifs.c b/mkfs.ubifs/mkfs.ubifs.c
index 200c8a5..d7a252c 100644
--- a/mkfs.ubifs/mkfs.ubifs.c
+++ b/mkfs.ubifs/mkfs.ubifs.c
@@ -1535,7 +1535,7 @@ static int add_directory(const char *dir_name, ino_t dir_inum, struct stat *st,
memcpy(&fake_st, &root_st, sizeof(struct stat));
fake_st.st_uid = nh_elt->uid;
- fake_st.st_uid = nh_elt->uid;
+ fake_st.st_gid = nh_elt->gid;
fake_st.st_mode = nh_elt->mode;
fake_st.st_rdev = nh_elt->dev;
fake_st.st_nlink = 1;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mkfs.ubifs: use gid from table instead 2x uid
2014-08-22 16:49 [PATCH] mkfs.ubifs: use gid from table instead 2x uid Sebastian Andrzej Siewior
@ 2015-12-10 0:05 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-12-10 0:05 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Artem Bityutskiy, linux-mtd, Richard Weinberger
With the archaeology hat on...
On Fri, Aug 22, 2014 at 06:49:01PM +0200, Sebastian Andrzej Siewior wrote:
> If the devtable is used then the tool uses uid twice and doesn't
> consider gid at all. This changes it to use gid & uid.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> mkfs.ubifs/mkfs.ubifs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs.ubifs/mkfs.ubifs.c b/mkfs.ubifs/mkfs.ubifs.c
> index 200c8a5..d7a252c 100644
> --- a/mkfs.ubifs/mkfs.ubifs.c
> +++ b/mkfs.ubifs/mkfs.ubifs.c
> @@ -1535,7 +1535,7 @@ static int add_directory(const char *dir_name, ino_t dir_inum, struct stat *st,
>
> memcpy(&fake_st, &root_st, sizeof(struct stat));
> fake_st.st_uid = nh_elt->uid;
> - fake_st.st_uid = nh_elt->uid;
> + fake_st.st_gid = nh_elt->gid;
> fake_st.st_mode = nh_elt->mode;
> fake_st.st_rdev = nh_elt->dev;
> fake_st.st_nlink = 1;
LGTM. Applied to mtd-utils.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-10 0:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-22 16:49 [PATCH] mkfs.ubifs: use gid from table instead 2x uid Sebastian Andrzej Siewior
2015-12-10 0:05 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.