All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm-ppc@vger.kernel.org, lvivier@redhat.com, kvm@vger.kernel.org,
	dgibson@redhat.com
Subject: Re: [PATCH] KVM: PPC: Fix emulation of H_SET_DABR/X on POWER8
Date: Thu, 10 Dec 2015 11:40:03 +1100	[thread overview]
Message-ID: <20151210004003.GC6978@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1448007105-15283-1-git-send-email-thuth@redhat.com>

On Fri, Nov 20, 2015 at 09:11:45AM +0100, Thomas Huth wrote:
> In the old DABR register, the BT (Breakpoint Translation) bit
> is bit number 61. In the new DAWRX register, the WT (Watchpoint
> Translation) bit is bit number 59. So to move the DABR-BT bit
> into the position of the DAWRX-WT bit, it has to be shifted by
> two, not only by one. This fixes hardware watchpoints in gdb of
> older guests that only use the H_SET_DABR/X interface instead
> of the new H_SET_MODE interface.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to my kvm-ppc-next branch, with cc: stable@vger.kernel.org.

Paul.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@ozlabs.org>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm-ppc@vger.kernel.org, lvivier@redhat.com, kvm@vger.kernel.org,
	dgibson@redhat.com
Subject: Re: [PATCH] KVM: PPC: Fix emulation of H_SET_DABR/X on POWER8
Date: Thu, 10 Dec 2015 00:40:03 +0000	[thread overview]
Message-ID: <20151210004003.GC6978@fergus.ozlabs.ibm.com> (raw)
In-Reply-To: <1448007105-15283-1-git-send-email-thuth@redhat.com>

On Fri, Nov 20, 2015 at 09:11:45AM +0100, Thomas Huth wrote:
> In the old DABR register, the BT (Breakpoint Translation) bit
> is bit number 61. In the new DAWRX register, the WT (Watchpoint
> Translation) bit is bit number 59. So to move the DABR-BT bit
> into the position of the DAWRX-WT bit, it has to be shifted by
> two, not only by one. This fixes hardware watchpoints in gdb of
> older guests that only use the H_SET_DABR/X interface instead
> of the new H_SET_MODE interface.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to my kvm-ppc-next branch, with cc: stable@vger.kernel.org.

Paul.

  parent reply	other threads:[~2015-12-10  0:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  8:11 [PATCH] KVM: PPC: Fix emulation of H_SET_DABR/X on POWER8 Thomas Huth
2015-11-20  8:11 ` Thomas Huth
2015-11-20 15:42 ` Laurent Vivier
2015-11-20 15:42   ` Laurent Vivier
2015-11-23  1:35 ` David Gibson
2015-11-23  1:35   ` David Gibson
2015-12-07 12:01 ` Thomas Huth
2015-12-07 12:01   ` Thomas Huth
2015-12-10  0:40 ` Paul Mackerras [this message]
2015-12-10  0:40   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151210004003.GC6978@fergus.ozlabs.ibm.com \
    --to=paulus@ozlabs.org \
    --cc=dgibson@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.