* [cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation
@ 2015-12-09 18:49 kbuild test robot
2015-12-10 1:47 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-12-09 18:49 UTC (permalink / raw)
To: Andrzej Zaborowski; +Cc: kbuild-all, linux-crypto, Herbert Xu
[-- Attachment #1: Type: text/plain, Size: 1791 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2
commit: 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6 [53/54] crypto: rsa - RSA padding algorithm
config: s390-allmodconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6
# save the attached .config to linux build tree
make.cross ARCH=s390
All warnings (new ones prefixed by >>):
crypto/rsa-pkcs1pad.c: In function 'pkcs1pad_encrypt_sign_complete':
>> crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation
}
^
vim +/pkcs1pad_encrypt_sign_complete +135 crypto/rsa-pkcs1pad.c
119 sg_nents_for_len(req->dst,
120 sizeof(zeros)),
121 zeros, sizeof(zeros));
122 }
123
124 sg_pcopy_from_buffer(req->dst,
125 sg_nents_for_len(req->dst, ctx->key_size),
126 req_ctx->out_buf, req_ctx->child_req.dst_len,
127 sizeof(zeros));
128 }
129 req->dst_len = ctx->key_size;
130
131 kfree(req_ctx->in_buf);
132 kzfree(req_ctx->out_buf);
133
134 return err;
> 135 }
136
137 static void pkcs1pad_encrypt_sign_complete_cb(
138 struct crypto_async_request *child_async_req, int err)
139 {
140 struct akcipher_request *req = child_async_req->data;
141 struct crypto_async_request async_req;
142
143 if (err == -EINPROGRESS)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 39221 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation
2015-12-09 18:49 [cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation kbuild test robot
@ 2015-12-10 1:47 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-12-10 1:47 UTC (permalink / raw)
To: kbuild test robot; +Cc: Andrzej Zaborowski, kbuild-all, linux-crypto
On Thu, Dec 10, 2015 at 02:49:27AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2
> commit: 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6 [53/54] crypto: rsa - RSA padding algorithm
> config: s390-allmodconfig (attached as .config)
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 3d5b1ecdea6fb94f8c61554fcb2ba776a2d3d0e6
> # save the attached .config to linux build tree
> make.cross ARCH=s390
>
> All warnings (new ones prefixed by >>):
>
> crypto/rsa-pkcs1pad.c: In function 'pkcs1pad_encrypt_sign_complete':
> >> crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation
> }
> ^
Indeed that looks bad. Andrzej please fix this.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-10 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-09 18:49 [cryptodev:master 53/54] crypto/rsa-pkcs1pad.c:135:1: warning: 'pkcs1pad_encrypt_sign_complete' uses dynamic stack allocation kbuild test robot
2015-12-10 1:47 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.