From: Vinod Koul <vinod.koul@intel.com>
To: "M'boumba Cedric Madianga" <cedric.madianga@gmail.com>
Cc: dan.j.williams@intel.com, mcoquelin.stm32@gmail.com,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: stm32-dma: Fix unchecked deference of chan->desc
Date: Thu, 10 Dec 2015 09:45:44 +0530 [thread overview]
Message-ID: <20151210041544.GO1854@localhost> (raw)
In-Reply-To: <1449486028-29344-1-git-send-email-cedric.madianga@gmail.com>
On Mon, Dec 07, 2015 at 12:00:28PM +0100, M'boumba Cedric Madianga wrote:
> 'commit d8b468394fb7 ("dmaengine: Add STM32 DMA driver")' leads to the
> following Smatch complaint:
>
> drivers/dma/stm32-dma.c:562 stm32_dma_issue_pending()
> error: we previously assumed 'chan->desc' could be null (see line 560)
>
> So, this patch fixes the unchecked dereference of chan->desc by returning
> operation not permitted error when stm32_dma_start_transfer() does not
> succeed to allocate a virtual channel descriptor.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dmaengine: stm32-dma: Fix unchecked deference of chan->desc
Date: Thu, 10 Dec 2015 09:45:44 +0530 [thread overview]
Message-ID: <20151210041544.GO1854@localhost> (raw)
In-Reply-To: <1449486028-29344-1-git-send-email-cedric.madianga@gmail.com>
On Mon, Dec 07, 2015 at 12:00:28PM +0100, M'boumba Cedric Madianga wrote:
> 'commit d8b468394fb7 ("dmaengine: Add STM32 DMA driver")' leads to the
> following Smatch complaint:
>
> drivers/dma/stm32-dma.c:562 stm32_dma_issue_pending()
> error: we previously assumed 'chan->desc' could be null (see line 560)
>
> So, this patch fixes the unchecked dereference of chan->desc by returning
> operation not permitted error when stm32_dma_start_transfer() does not
> succeed to allocate a virtual channel descriptor.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2015-12-10 4:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 11:00 [PATCH v2] dmaengine: stm32-dma: Fix unchecked deference of chan->desc M'boumba Cedric Madianga
2015-12-07 11:00 ` M'boumba Cedric Madianga
2015-12-10 4:15 ` Vinod Koul [this message]
2015-12-10 4:15 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210041544.GO1854@localhost \
--to=vinod.koul@intel.com \
--cc=cedric.madianga@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.