From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG
Date: Thu, 10 Dec 2015 14:17:18 +0100 [thread overview]
Message-ID: <20151210131718.GL19496@dhcp22.suse.cz> (raw)
In-Reply-To: <1449599665-18047-7-git-send-email-hannes@cmpxchg.org>
On Tue 08-12-15 13:34:23, Johannes Weiner wrote:
> The cgroup2 memory controller will account important in-kernel memory
> consumers per default. Move all necessary components to CONFIG_MEMCG.
Hmm, that bloats the kernel also for users who are not using cgroup2
and have CONFIG_MEMCG_KMEM disabled.
This is the situation before this patch
text data bss dec hex filename
521342 97516 44312 663170 a1e82 mm/built-in.o.kmem
513349 96299 43960 653608 9f928 mm/built-in.o.nokmem
and after with CONFIG_MEMCG_KMEM=n
521028 96556 44312 661896 a1988 mm/built-in.o
we are basically back to CONFIG_MEMCG_KMEM=y. This sounds like a wastage
to me. Do we really need this?
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
[...]
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG
Date: Thu, 10 Dec 2015 14:17:18 +0100 [thread overview]
Message-ID: <20151210131718.GL19496@dhcp22.suse.cz> (raw)
In-Reply-To: <1449599665-18047-7-git-send-email-hannes@cmpxchg.org>
On Tue 08-12-15 13:34:23, Johannes Weiner wrote:
> The cgroup2 memory controller will account important in-kernel memory
> consumers per default. Move all necessary components to CONFIG_MEMCG.
Hmm, that bloats the kernel also for users who are not using cgroup2
and have CONFIG_MEMCG_KMEM disabled.
This is the situation before this patch
text data bss dec hex filename
521342 97516 44312 663170 a1e82 mm/built-in.o.kmem
513349 96299 43960 653608 9f928 mm/built-in.o.nokmem
and after with CONFIG_MEMCG_KMEM=n
521028 96556 44312 661896 a1988 mm/built-in.o
we are basically back to CONFIG_MEMCG_KMEM=y. This sounds like a wastage
to me. Do we really need this?
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
[...]
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-10 13:17 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 18:34 [PATCH 0/8] mm: memcontrol: account "kmem" in cgroup2 Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-08 18:34 ` [PATCH 1/8] mm: memcontrol: drop unused @css argument in memcg_init_kmem Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:01 ` Vladimir Davydov
2015-12-09 9:01 ` Vladimir Davydov
2015-12-09 9:01 ` Vladimir Davydov
2015-12-10 12:37 ` Michal Hocko
2015-12-10 12:37 ` Michal Hocko
2015-12-10 12:37 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 2/8] mm: memcontrol: remove double kmem page_counter init Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:05 ` Vladimir Davydov
2015-12-09 9:05 ` Vladimir Davydov
2015-12-10 12:40 ` Michal Hocko
2015-12-10 12:40 ` Michal Hocko
2015-12-10 12:40 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 3/8] mm: memcontrol: give the kmem states more descriptive names Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:10 ` Vladimir Davydov
2015-12-09 9:10 ` Vladimir Davydov
2015-12-09 9:10 ` Vladimir Davydov
2015-12-10 12:47 ` Michal Hocko
2015-12-10 12:47 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 4/8] mm: memcontrol: group kmem init and exit functions together Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:14 ` Vladimir Davydov
2015-12-09 9:14 ` Vladimir Davydov
2015-12-09 9:14 ` Vladimir Davydov
2015-12-10 12:56 ` Michal Hocko
2015-12-10 12:56 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 5/8] mm: memcontrol: separate kmem code from legacy tcp accounting code Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:23 ` Vladimir Davydov
2015-12-09 9:23 ` Vladimir Davydov
2015-12-09 9:23 ` Vladimir Davydov
2015-12-10 12:59 ` Michal Hocko
2015-12-10 12:59 ` Michal Hocko
2015-12-10 12:59 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 6/8] mm: memcontrol: move kmem accounting code to CONFIG_MEMCG Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 9:32 ` Vladimir Davydov
2015-12-09 9:32 ` Vladimir Davydov
2015-12-09 9:32 ` Vladimir Davydov
2015-12-10 13:17 ` Michal Hocko [this message]
2015-12-10 13:17 ` Michal Hocko
2015-12-10 14:00 ` Johannes Weiner
2015-12-10 14:00 ` Johannes Weiner
2015-12-10 14:00 ` Johannes Weiner
2015-12-10 20:22 ` [PATCH 6/8 v2] " Johannes Weiner
2015-12-10 20:22 ` Johannes Weiner
2015-12-10 20:22 ` Johannes Weiner
2015-12-10 20:50 ` Johannes Weiner
2015-12-10 20:50 ` Johannes Weiner
2015-12-10 20:50 ` Johannes Weiner
2015-12-08 18:34 ` [PATCH 7/8] mm: memcontrol: account "kmem" consumers in cgroup2 memory controller Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 11:30 ` Vladimir Davydov
2015-12-09 11:30 ` Vladimir Davydov
2015-12-09 11:30 ` Vladimir Davydov
2015-12-09 14:32 ` Johannes Weiner
2015-12-09 14:32 ` Johannes Weiner
2015-12-09 14:32 ` Johannes Weiner
2015-12-10 13:28 ` Michal Hocko
2015-12-10 13:28 ` Michal Hocko
2015-12-10 13:28 ` Michal Hocko
2015-12-10 15:16 ` Johannes Weiner
2015-12-10 15:16 ` Johannes Weiner
2015-12-10 16:25 ` Michal Hocko
2015-12-10 16:25 ` Michal Hocko
2015-12-10 16:25 ` Michal Hocko
2015-12-10 14:21 ` Michal Hocko
2015-12-10 14:21 ` Michal Hocko
2015-12-08 18:34 ` [PATCH 8/8] mm: memcontrol: introduce CONFIG_MEMCG_LEGACY_KMEM Johannes Weiner
2015-12-08 18:34 ` Johannes Weiner
2015-12-09 11:31 ` Vladimir Davydov
2015-12-09 11:31 ` Vladimir Davydov
2015-12-09 11:31 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210131718.GL19496@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.