From: Simon Horman <horms@verge.net.au> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Magnus Damm <magnus.damm@gmail.com>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings Date: Fri, 11 Dec 2015 01:09:15 +0000 [thread overview] Message-ID: <20151211010911.GC9927@verge.net.au> (raw) In-Reply-To: <877fkmbw9p.wl%kuninori.morimoto.gx@renesas.com> On Thu, Dec 10, 2015 at 07:28:06AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > Thank you for your patch > > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Also add SoC names. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > (snip) > > Required properties: > > - compatible: Must contain one of the following: > > - - "renesas,usbhs-r8a7790" > > - - "renesas,usbhs-r8a7791" > > - - "renesas,usbhs-r8a7794" > > - - "renesas,usbhs-r8a7795" > > + > > + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > > + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > > + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > > + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device > > + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed > > + by the generic version. > > I think these can be separated ? > > 1. document update for "renesas,usbhs-r8a77xx" > 2. add new "rcar-genX" (this patch) Sure, will do. > > Example: > > usbhs: usb@e6590000 { > > - compatible = "renesas,usbhs-r8a7790"; > > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > > I think you want > > - compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs"; Thanks, I will fix that.
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au> To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Magnus Damm <magnus.damm@gmail.com>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings Date: Fri, 11 Dec 2015 10:09:15 +0900 [thread overview] Message-ID: <20151211010911.GC9927@verge.net.au> (raw) In-Reply-To: <877fkmbw9p.wl%kuninori.morimoto.gx@renesas.com> On Thu, Dec 10, 2015 at 07:28:06AM +0000, Kuninori Morimoto wrote: > > Hi Simon > > Thank you for your patch > > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Also add SoC names. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > (snip) > > Required properties: > > - compatible: Must contain one of the following: > > - - "renesas,usbhs-r8a7790" > > - - "renesas,usbhs-r8a7791" > > - - "renesas,usbhs-r8a7794" > > - - "renesas,usbhs-r8a7795" > > + > > + - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device > > + - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device > > + - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device > > + - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device > > + - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device > > + - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device > > + > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed > > + by the generic version. > > I think these can be separated ? > > 1. document update for "renesas,usbhs-r8a77xx" > 2. add new "rcar-genX" (this patch) Sure, will do. > > Example: > > usbhs: usb@e6590000 { > > - compatible = "renesas,usbhs-r8a7790"; > > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > > I think you want > > - compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs"; > + compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs"; Thanks, I will fix that.
next prev parent reply other threads:[~2015-12-11 1:09 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-10 5:40 [PATCH v2 0/2] usb: renesas_usbhs: More compat strings Simon Horman 2015-12-10 5:40 ` Simon Horman 2015-12-10 5:40 ` [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings Simon Horman 2015-12-10 5:40 ` Simon Horman 2015-12-10 7:28 ` Kuninori Morimoto 2015-12-11 1:09 ` Simon Horman [this message] 2015-12-11 1:09 ` Simon Horman [not found] ` <1449726033-17117-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-10 11:59 ` Sergei Shtylyov 2015-12-10 11:59 ` Sergei Shtylyov [not found] ` <1449726033-17117-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-10 5:40 ` [PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman 2015-12-10 5:40 ` Simon Horman [not found] ` <1449726033-17117-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> 2015-12-10 9:33 ` Geert Uytterhoeven 2015-12-10 9:33 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151211010911.GC9927@verge.net.au \ --to=horms@verge.net.au \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=linux-sh@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.