From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Wang, Annie" <Annie.Wang-5C7GfCeVMHo@public.gmane.org>
Cc: "Li, Tony" <Tony.Li-5C7GfCeVMHo@public.gmane.org>,
"Wan, Vincent" <Vincent.Wan-5C7GfCeVMHo@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"Huang, Ray" <Ray.Huang-5C7GfCeVMHo@public.gmane.org>,
Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>,
Graeme Gregory <gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"Xue, Ken" <Ken.Xue-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 3/9] ACPI: add struct acpi_amba_quirk for AMD pl330 specific device config
Date: Fri, 11 Dec 2015 15:01:49 +0530 [thread overview]
Message-ID: <20151211093148.GX1854@localhost> (raw)
In-Reply-To: <BLUPR12MB04339648B98F07977B6FA61F81EA0-7LeqcoF/hwrdEWIfrEWxYwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Fri, Dec 11, 2015 at 06:57:51AM +0000, Wang, Annie wrote:
> >> + /*
> >> + * If the ACPI device already has a node attached. It must be
> >> + * renamed.
> >> + */
> >> + if (quirk->quirk & MULTI_ATTACHED_QUIRK)
> >> + sprintf(amba_devname, "%s%s", dev_name(&adev->dev),
> >"DMA");
> >> + else
> >> + memcpy(amba_devname, dev_name(&adev->dev),
> >> + strlen(dev_name(&adev->dev)));
> >> +
> >> + amba_dev = amba_device_alloc(amba_devname,
> >> resource->start,
> >> resource_size(resource));
> >>
> >
> >Isn't this basially an MFD in a rather odd fashion?
MFD yes, odd perhaps made out here!
> >
> >I would have though having a device which just splits the resources then creates 2
> >children would be a whole lot simpler?
> >
Yup!
>
> It seems more complex, if I trans an ACPI device to pdev, then attach 2 platform child nodes,
> and create an amba device refer to one of the childs. Too many trans.
Sorry but I dont think that is right assumption, it will simper and PM would
become easy
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: "Wang, Annie" <Annie.Wang@amd.com>
Cc: Graeme Gregory <gg@slimlogic.co.uk>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, "Huang, Ray" <Ray.Huang@amd.com>,
"Wan, Vincent" <Vincent.Wan@amd.com>,
"Xue, Ken" <Ken.Xue@amd.com>, "Li, Tony" <Tony.Li@amd.com>
Subject: Re: [PATCH 3/9] ACPI: add struct acpi_amba_quirk for AMD pl330 specific device config
Date: Fri, 11 Dec 2015 15:01:49 +0530 [thread overview]
Message-ID: <20151211093148.GX1854@localhost> (raw)
In-Reply-To: <BLUPR12MB04339648B98F07977B6FA61F81EA0@BLUPR12MB0433.namprd12.prod.outlook.com>
On Fri, Dec 11, 2015 at 06:57:51AM +0000, Wang, Annie wrote:
> >> + /*
> >> + * If the ACPI device already has a node attached. It must be
> >> + * renamed.
> >> + */
> >> + if (quirk->quirk & MULTI_ATTACHED_QUIRK)
> >> + sprintf(amba_devname, "%s%s", dev_name(&adev->dev),
> >"DMA");
> >> + else
> >> + memcpy(amba_devname, dev_name(&adev->dev),
> >> + strlen(dev_name(&adev->dev)));
> >> +
> >> + amba_dev = amba_device_alloc(amba_devname,
> >> resource->start,
> >> resource_size(resource));
> >>
> >
> >Isn't this basially an MFD in a rather odd fashion?
MFD yes, odd perhaps made out here!
> >
> >I would have though having a device which just splits the resources then creates 2
> >children would be a whole lot simpler?
> >
Yup!
>
> It seems more complex, if I trans an ACPI device to pdev, then attach 2 platform child nodes,
> and create an amba device refer to one of the childs. Too many trans.
Sorry but I dont think that is right assumption, it will simper and PM would
become easy
--
~Vinod
next prev parent reply other threads:[~2015-12-11 9:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 3:24 [PATCH 0/9] 8250: AMD Carrizo UART PL300 DMA enablement Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-04 3:24 ` [PATCH 1/9] ACPI: Add support for AMBA bus type Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-04 8:50 ` Mika Westerberg
2015-12-04 9:17 ` Huang Rui
2015-12-04 9:17 ` Huang Rui
2015-12-04 9:42 ` Hanjun Guo
2015-12-04 9:42 ` Hanjun Guo
2015-12-04 9:59 ` G Gregory
2015-12-04 10:20 ` Huang Rui
2015-12-04 10:20 ` Huang Rui
2015-12-04 10:23 ` G Gregory
2015-12-04 3:24 ` [PATCH 2/9] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-04 11:11 ` Borislav Petkov
2015-12-04 3:24 ` [PATCH 3/9] ACPI: add struct acpi_amba_quirk for AMD pl330 specific device config Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
[not found] ` <1449199466-6081-4-git-send-email-annie.wang-5C7GfCeVMHo@public.gmane.org>
2015-12-04 12:56 ` kbuild test robot
2015-12-04 12:56 ` kbuild test robot
2015-12-04 13:16 ` Graeme Gregory
2015-12-11 6:57 ` Wang, Annie
[not found] ` <BLUPR12MB04339648B98F07977B6FA61F81EA0-7LeqcoF/hwrdEWIfrEWxYwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-12-11 9:31 ` Vinod Koul [this message]
2015-12-11 9:31 ` Vinod Koul
2015-12-04 3:24 ` [PATCH 4/9] dmaengine: pl330: add new items for pl330 private data Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-10 4:09 ` Vinod Koul
2015-12-10 6:38 ` Wang, Annie
[not found] ` <BLUPR12MB0433B81BB0AEB2D84505B55881E90-7LeqcoF/hwrdEWIfrEWxYwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-12-11 9:29 ` Vinod Koul
2015-12-11 9:29 ` Vinod Koul
2015-12-11 13:56 ` Andy Shevchenko
2015-12-04 3:24 ` [PATCH 5/9] dmaengine: pl330: provide ACPI dmaengine interface Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
[not found] ` <1449199466-6081-6-git-send-email-annie.wang-5C7GfCeVMHo@public.gmane.org>
2015-12-13 2:21 ` Andy Shevchenko
2015-12-13 2:21 ` Andy Shevchenko
2015-12-04 3:24 ` [PATCH 6/9] dmaengine:pl330: set segment_boundary_mask = 0cffffffff Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-04 14:59 ` Robin Murphy
2015-12-04 3:24 ` [PATCH 7/9] Serial:8250: New Port Type PORT_AMD_8250 Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
[not found] ` <1449199466-6081-8-git-send-email-annie.wang-5C7GfCeVMHo@public.gmane.org>
2015-12-13 2:30 ` Andy Shevchenko
2015-12-13 2:30 ` Andy Shevchenko
2015-12-04 3:24 ` [PATCH 8/9] Documentation: Add ivrs_acpihid kernel parameter description Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
[not found] ` <1449199466-6081-9-git-send-email-annie.wang-5C7GfCeVMHo@public.gmane.org>
2015-12-04 12:21 ` Borislav Petkov
2015-12-04 12:21 ` Borislav Petkov
2015-12-04 13:19 ` Wan, Vincent
2015-12-04 13:19 ` Wan, Vincent
2015-12-04 14:38 ` Borislav Petkov
2015-12-04 3:24 ` [PATCH 9/9] iommu/amd: Add ACPI HID named devices IOMMU driver support Wang Hongcheng
2015-12-04 3:24 ` Wang Hongcheng
2015-12-13 2:32 ` [PATCH 0/9] 8250: AMD Carrizo UART PL300 DMA enablement Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151211093148.GX1854@localhost \
--to=vinod.koul-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=Annie.Wang-5C7GfCeVMHo@public.gmane.org \
--cc=Ken.Xue-5C7GfCeVMHo@public.gmane.org \
--cc=Ray.Huang-5C7GfCeVMHo@public.gmane.org \
--cc=Tony.Li-5C7GfCeVMHo@public.gmane.org \
--cc=Vincent.Wan-5C7GfCeVMHo@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.