* [PATCH 1/2] crypto: atmel-sha: Removed unused variable "err"
@ 2015-12-14 8:44 Pathak, Rahul (R.)
2015-12-17 8:46 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Pathak, Rahul (R.) @ 2015-12-14 8:44 UTC (permalink / raw)
To: herbert, davem, linux-crypto, linux-kernel
From: Rahul Pathak <rpathak@visteon.com>
Removed unused variable "err" and directly return "0"
Reported by coccicheck -
./drivers/crypto/atmel-sha.c:758:5-8: Unneeded variable: "err". Return "0" on line 766
Signed-off-by: Rahul Pathak <rpathak@visteon.com>
---
drivers/crypto/atmel-sha.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 660d8c0..20de861 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -755,7 +755,6 @@ static int atmel_sha_finish(struct ahash_request *req)
{
struct atmel_sha_reqctx *ctx = ahash_request_ctx(req);
struct atmel_sha_dev *dd = ctx->dd;
- int err = 0;
if (ctx->digcnt[0] || ctx->digcnt[1])
atmel_sha_copy_ready_hash(req);
@@ -763,7 +762,7 @@ static int atmel_sha_finish(struct ahash_request *req)
dev_dbg(dd->dev, "digcnt: 0x%llx 0x%llx, bufcnt: %d\n", ctx->digcnt[1],
ctx->digcnt[0], ctx->bufcnt);
- return err;
+ return 0;
}
static void atmel_sha_finish_req(struct ahash_request *req, int err)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] crypto: atmel-sha: Removed unused variable "err"
2015-12-14 8:44 [PATCH 1/2] crypto: atmel-sha: Removed unused variable "err" Pathak, Rahul (R.)
@ 2015-12-17 8:46 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-12-17 8:46 UTC (permalink / raw)
To: Pathak, Rahul (R.); +Cc: davem, linux-crypto, linux-kernel
On Mon, Dec 14, 2015 at 08:44:19AM +0000, Pathak, Rahul (R.) wrote:
> From: Rahul Pathak <rpathak@visteon.com>
>
> Removed unused variable "err" and directly return "0"
>
> Reported by coccicheck -
> ./drivers/crypto/atmel-sha.c:758:5-8: Unneeded variable: "err". Return "0" on line 766
>
> Signed-off-by: Rahul Pathak <rpathak@visteon.com>
Both patches applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-17 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-14 8:44 [PATCH 1/2] crypto: atmel-sha: Removed unused variable "err" Pathak, Rahul (R.)
2015-12-17 8:46 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.