* [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc
@ 2015-12-16 23:12 James Smart
2015-12-17 0:04 ` Matthew R. Ochs
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: James Smart @ 2015-12-16 23:12 UTC (permalink / raw)
To: linux-scsi
From: Punit Vara <punitvara@gmail.com>
This patch is to the lpfc_els.c which resolves following warning
reported by coccicheck:
WARNING: kzalloc should be used for rdp_context, instead of
kmalloc/memset
Signed-off-by: Punit Vara <punitvara@gmail.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
---
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 273a1db..7f5abb8 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -5016,13 +5016,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
}
- memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
cmd = &cmdiocb->iocb;
rdp_context->ndlp = lpfc_nlp_get(ndlp);
rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc
2015-12-16 23:12 [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc James Smart
@ 2015-12-17 0:04 ` Matthew R. Ochs
2015-12-17 8:39 ` Hannes Reinecke
2015-12-17 22:58 ` Sebastian Herbszt
2 siblings, 0 replies; 4+ messages in thread
From: Matthew R. Ochs @ 2015-12-17 0:04 UTC (permalink / raw)
To: James Smart; +Cc: linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc
2015-12-16 23:12 [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc James Smart
2015-12-17 0:04 ` Matthew R. Ochs
@ 2015-12-17 8:39 ` Hannes Reinecke
2015-12-17 22:58 ` Sebastian Herbszt
2 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2015-12-17 8:39 UTC (permalink / raw)
To: James Smart, linux-scsi
On 12/17/2015 12:12 AM, James Smart wrote:
>
> From: Punit Vara <punitvara@gmail.com>
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 273a1db..7f5abb8 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -5016,13 +5016,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc
2015-12-16 23:12 [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc James Smart
2015-12-17 0:04 ` Matthew R. Ochs
2015-12-17 8:39 ` Hannes Reinecke
@ 2015-12-17 22:58 ` Sebastian Herbszt
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2015-12-17 22:58 UTC (permalink / raw)
To: James Smart; +Cc: linux-scsi, Sebastian Herbszt
James Smart wrote:
> From: Punit Vara <punitvara@gmail.com>
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
You missed the two already available positive reviews [1][2].
Anyway,
Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>
[1] http://marc.info/?l=linux-scsi&m=144574360607327&w=2
[2] http://marc.info/?l=linux-scsi&m=144823385015994&w=2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-17 22:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-16 23:12 [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc James Smart
2015-12-17 0:04 ` Matthew R. Ochs
2015-12-17 8:39 ` Hannes Reinecke
2015-12-17 22:58 ` Sebastian Herbszt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.