From: Mark Rutland <mark.rutland@arm.com> To: "majun (F)" <majun258@huawei.com>, marc.zyngier@arm.com Cc: Catalin.Marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com, jason@lakedaemon.net, tglx@linutronix.de, lizefan@huawei.com, huxinwei@huawei.com, dingtianhong@huawei.com, zhaojunhua@hisilicon.com, liguozhu@hisilicon.com, xuwei5@hisilicon.com, wei.chenwei@hisilicon.com, guohanjun@huawei.com, wuyun.wu@huawei.com, guodong.xu@linaro.org, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, usman.ahmad@linaro.org, klimov.linux@gmail.com, gabriele.paoloni@huawei.com Subject: Re: [PATCH v10 1/4] dt-binding:Documents of the mbigen bindings Date: Fri, 18 Dec 2015 10:58:38 +0000 [thread overview] Message-ID: <20151218105837.GB29219@leverpostej> (raw) In-Reply-To: <5673683C.2080304@huawei.com> On Fri, Dec 18, 2015 at 09:58:20AM +0800, majun (F) wrote: > Hi Mark: > > 在 2015/12/17 21:52, Mark Rutland 写道: > > On Thu, Dec 17, 2015 at 07:56:34PM +0800, MaJun wrote: > >> From: Ma Jun <majun258@huawei.com> > [...] > >> +- compatible: Should be "hisilicon,mbigen-v2" > >> + > >> +- reg: Specifies the base physical address and size of the Mbigen > >> + registers. > >> + > >> +- interrupt controller: Identifies the node as an interrupt controller > >> + > >> +- msi-parent: Specifies the MSI controller this mbigen use. > >> + For more detail information,please refer to the generic msi-parent binding in > >> + Documentation/devicetree/bindings/interrupt-controller/msi.txt. > >> + > >> +- num-msis:Specifies the total number of interrupt this device has. > > > > Is this the number of pins implemented? Or the number of pins that are > > in use? > > > > The latter feels like something we can derive. > > num-msis means the total number of pins implemented. Ok. In that case I think it should be: - num-pins: the total number of pins implemented in this Mbigen instance. (with the appropriate fixups in the driver). With that: Acked-by: Mark Rutland <mark.rutland@arm.com> > >> +- #interrupt-cells : Specifies the number of cells needed to encode an > >> + interrupt source. The value must be 2. > >> + > >> + The 1st cell is hardware pin number of the interrupt.This number is local to > >> + each mbigen chip and in the range from 0 to the maximum interrupts number > >> + of the mbigen. > > > > Just to check: 0 - 63 represent the "reserved" pins, yes? > > Yes, you are right. > > > > > Other than those questions, this looks good to me. > > Do i need to post a new patch to update these two questions? Hopefully not. Marc, are you happy to fold in the s/num-msis/num-pins/ change? Thanks, Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v10 1/4] dt-binding:Documents of the mbigen bindings Date: Fri, 18 Dec 2015 10:58:38 +0000 [thread overview] Message-ID: <20151218105837.GB29219@leverpostej> (raw) In-Reply-To: <5673683C.2080304@huawei.com> On Fri, Dec 18, 2015 at 09:58:20AM +0800, majun (F) wrote: > Hi Mark: > > ? 2015/12/17 21:52, Mark Rutland ??: > > On Thu, Dec 17, 2015 at 07:56:34PM +0800, MaJun wrote: > >> From: Ma Jun <majun258@huawei.com> > [...] > >> +- compatible: Should be "hisilicon,mbigen-v2" > >> + > >> +- reg: Specifies the base physical address and size of the Mbigen > >> + registers. > >> + > >> +- interrupt controller: Identifies the node as an interrupt controller > >> + > >> +- msi-parent: Specifies the MSI controller this mbigen use. > >> + For more detail information,please refer to the generic msi-parent binding in > >> + Documentation/devicetree/bindings/interrupt-controller/msi.txt. > >> + > >> +- num-msis:Specifies the total number of interrupt this device has. > > > > Is this the number of pins implemented? Or the number of pins that are > > in use? > > > > The latter feels like something we can derive. > > num-msis means the total number of pins implemented. Ok. In that case I think it should be: - num-pins: the total number of pins implemented in this Mbigen instance. (with the appropriate fixups in the driver). With that: Acked-by: Mark Rutland <mark.rutland@arm.com> > >> +- #interrupt-cells : Specifies the number of cells needed to encode an > >> + interrupt source. The value must be 2. > >> + > >> + The 1st cell is hardware pin number of the interrupt.This number is local to > >> + each mbigen chip and in the range from 0 to the maximum interrupts number > >> + of the mbigen. > > > > Just to check: 0 - 63 represent the "reserved" pins, yes? > > Yes, you are right. > > > > > Other than those questions, this looks good to me. > > Do i need to post a new patch to update these two questions? Hopefully not. Marc, are you happy to fold in the s/num-msis/num-pins/ change? Thanks, Mark.
next prev parent reply other threads:[~2015-12-18 10:58 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-17 11:56 [PATCH v10 0/4] irqchip:support mbigen interrupt controller MaJun 2015-12-17 11:56 ` MaJun 2015-12-17 11:56 ` [PATCH v10 1/4] dt-binding:Documents of the mbigen bindings MaJun 2015-12-17 11:56 ` MaJun 2015-12-17 13:52 ` Mark Rutland 2015-12-17 13:52 ` Mark Rutland 2015-12-18 1:58 ` majun (F) 2015-12-18 1:58 ` majun (F) 2015-12-18 10:58 ` Mark Rutland [this message] 2015-12-18 10:58 ` Mark Rutland 2015-12-18 11:26 ` Marc Zyngier 2015-12-18 11:26 ` Marc Zyngier 2015-12-18 11:35 ` Marc Zyngier 2015-12-18 11:35 ` Marc Zyngier 2015-12-18 11:54 ` Mark Rutland 2015-12-18 11:54 ` Mark Rutland 2015-12-17 11:56 ` [PATCH v10 2/4] irqchip: add platform device driver for mbigen device MaJun 2015-12-17 11:56 ` MaJun 2015-12-17 11:56 ` [PATCH v10 3/4] irqchip:create irq domain for each " MaJun 2015-12-17 11:56 ` MaJun 2015-12-17 16:02 ` Marc Zyngier 2015-12-17 16:02 ` Marc Zyngier 2015-12-18 11:02 ` Mark Rutland 2015-12-18 11:02 ` Mark Rutland 2015-12-18 11:27 ` Marc Zyngier 2015-12-18 11:27 ` Marc Zyngier 2015-12-17 11:56 ` [PATCH v10 4/4] irqchip:implement the mbigen irq chip operation functions MaJun 2015-12-17 11:56 ` MaJun 2015-12-17 16:03 ` Marc Zyngier 2015-12-17 16:03 ` Marc Zyngier 2015-12-17 16:06 ` [PATCH v10 0/4] irqchip:support mbigen interrupt controller Marc Zyngier 2015-12-17 16:06 ` Marc Zyngier 2015-12-18 11:58 ` Marc Zyngier 2015-12-18 11:58 ` Marc Zyngier 2015-12-18 12:27 ` Hanjun Guo 2015-12-18 12:27 ` Hanjun Guo 2015-12-18 14:03 ` majun 2015-12-18 14:03 ` majun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151218105837.GB29219@leverpostej \ --to=mark.rutland@arm.com \ --cc=Catalin.Marinas@arm.com \ --cc=Will.Deacon@arm.com \ --cc=dingtianhong@huawei.com \ --cc=gabriele.paoloni@huawei.com \ --cc=guodong.xu@linaro.org \ --cc=guohanjun@huawei.com \ --cc=haojian.zhuang@linaro.org \ --cc=huxinwei@huawei.com \ --cc=jason@lakedaemon.net \ --cc=klimov.linux@gmail.com \ --cc=liguozhu@hisilicon.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=majun258@huawei.com \ --cc=marc.zyngier@arm.com \ --cc=tglx@linutronix.de \ --cc=usman.ahmad@linaro.org \ --cc=wei.chenwei@hisilicon.com \ --cc=wuyun.wu@huawei.com \ --cc=xuwei5@hisilicon.com \ --cc=zhangfei.gao@linaro.org \ --cc=zhaojunhua@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.