* Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field
[not found] <1450444599-29265-1-git-send-email-fw.dmitrii@yandex.com>
@ 2015-12-18 14:13 ` Phil Sutter
2015-12-18 14:26 ` Jesper Dangaard Brouer
[not found] ` <1450444599-29265-2-git-send-email-fw.dmitrii@yandex.com>
2 siblings, 0 replies; 6+ messages in thread
From: Phil Sutter @ 2015-12-18 14:13 UTC (permalink / raw)
To: Dmitrii Shcherbakov; +Cc: netdev, brouer, stephen
On Fri, Dec 18, 2015 at 04:16:38PM +0300, Dmitrii Shcherbakov wrote:
> Remove printing according to the previously used encoding of mpu and overhead values within the tc_ratespec's mpu field. This encoding is no longer being used as a separate 'overhead' field in the ratespec structure has been introduced.
>
> Signed-off-by: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent
[not found] ` <1450444599-29265-2-git-send-email-fw.dmitrii@yandex.com>
@ 2015-12-18 14:13 ` Phil Sutter
2015-12-18 14:26 ` Jesper Dangaard Brouer
1 sibling, 0 replies; 6+ messages in thread
From: Phil Sutter @ 2015-12-18 14:13 UTC (permalink / raw)
To: Dmitrii Shcherbakov; +Cc: netdev, brouer, stephen
On Fri, Dec 18, 2015 at 04:16:39PM +0300, Dmitrii Shcherbakov wrote:
> b3 buffer has been deleted previously so b2 is followed by b4 which is not consistent
>
> Signed-off-by: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
Acked-by: Phil Sutter <phil@nwl.cc>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field
[not found] <1450444599-29265-1-git-send-email-fw.dmitrii@yandex.com>
2015-12-18 14:13 ` [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field Phil Sutter
@ 2015-12-18 14:26 ` Jesper Dangaard Brouer
2015-12-18 15:56 ` Dmitrii Shcherbakov
[not found] ` <1450444599-29265-2-git-send-email-fw.dmitrii@yandex.com>
2 siblings, 1 reply; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2015-12-18 14:26 UTC (permalink / raw)
To: Dmitrii Shcherbakov; +Cc: netdev, phil, stephen, brouer
On Fri, 18 Dec 2015 16:16:38 +0300 Dmitrii Shcherbakov <fw.dmitrii@yandex.com> wrote:
> Remove printing according to the previously used encoding of mpu and overhead values within the tc_ratespec's mpu field. This encoding is no longer being used as a separate 'overhead' field in the ratespec structure has been introduced.
>
> Signed-off-by: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
> ---
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Thank you Dmitrii for cleaning this up :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent
[not found] ` <1450444599-29265-2-git-send-email-fw.dmitrii@yandex.com>
2015-12-18 14:13 ` [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent Phil Sutter
@ 2015-12-18 14:26 ` Jesper Dangaard Brouer
1 sibling, 0 replies; 6+ messages in thread
From: Jesper Dangaard Brouer @ 2015-12-18 14:26 UTC (permalink / raw)
To: Dmitrii Shcherbakov; +Cc: netdev, phil, stephen, brouer
On Fri, 18 Dec 2015 16:16:39 +0300
Dmitrii Shcherbakov <fw.dmitrii@yandex.com> wrote:
> b3 buffer has been deleted previously so b2 is followed by b4 which is not consistent
>
> Signed-off-by: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
> ---
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field
2015-12-18 14:26 ` Jesper Dangaard Brouer
@ 2015-12-18 15:56 ` Dmitrii Shcherbakov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitrii Shcherbakov @ 2015-12-18 15:56 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: netdev
Jesper,
> Thank you Dmitrii for cleaning this up :-)
You are welcome :^)
I should read more carefully: its what you asked from the beginning.
Thank you,
Dmitrii Shcherbakov
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent
@ 2015-12-19 15:26 Dmitrii Shcherbakov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitrii Shcherbakov @ 2015-12-19 15:26 UTC (permalink / raw)
To: netdev; +Cc: Jesper Dangaard Brouer, Phil Sutter, Stephen Hemminger
b3 buffer has been deleted previously so b2 is followed by b4 which is not consistent
Signed-off-by: Dmitrii Shcherbakov <fw.dmitrii@yandex.com>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Phil Sutter <phil@nwl.cc>
---
tc/q_htb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/q_htb.c b/tc/q_htb.c
index e76d20a..7d54090 100644
--- a/tc/q_htb.c
+++ b/tc/q_htb.c
@@ -273,7 +273,7 @@ static int htb_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
__u64 rate64, ceil64;
SPRINT_BUF(b1);
SPRINT_BUF(b2);
- SPRINT_BUF(b4);
+ SPRINT_BUF(b3);
if (opt == NULL)
return 0;
@@ -310,7 +310,7 @@ static int htb_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
cbuffer = tc_calc_xmitsize(ceil64, hopt->cbuffer);
linklayer = (hopt->rate.linklayer & TC_LINKLAYER_MASK);
if (linklayer > TC_LINKLAYER_ETHERNET || show_details)
- fprintf(f, "linklayer %s ", sprint_linklayer(linklayer, b4));
+ fprintf(f, "linklayer %s ", sprint_linklayer(linklayer, b3));
if (show_details) {
fprintf(f, "burst %s/%u mpu %s ",
sprint_size(buffer, b1),
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-12-19 15:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1450444599-29265-1-git-send-email-fw.dmitrii@yandex.com>
2015-12-18 14:13 ` [PATCH 1/2] [iproute2] tc/q_htb.c: remove printing of a deprecated overhead value previously encoded as a part of mpu field Phil Sutter
2015-12-18 14:26 ` Jesper Dangaard Brouer
2015-12-18 15:56 ` Dmitrii Shcherbakov
[not found] ` <1450444599-29265-2-git-send-email-fw.dmitrii@yandex.com>
2015-12-18 14:13 ` [PATCH 2/2] [iproute2] tc/q_htb.c: rename b4 buffer to b3 to make its name more consistent Phil Sutter
2015-12-18 14:26 ` Jesper Dangaard Brouer
2015-12-19 15:26 Dmitrii Shcherbakov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.