All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/nut: disable libltdl (and nut-scanner) for static-only
@ 2015-12-19 18:10 Yann E. MORIN
  2015-12-20 12:58 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2015-12-19 18:10 UTC (permalink / raw)
  To: buildroot

nut-scanner needs libltdl, a wrapper around dlopen/dlsym. This does not
really make sense on a static-only build.

Disable use of libltdl in static-only builds; this disble nut-scanner.

Fixes:
    http://autobuild.buildroot.org/results/d8e/d8e769709681b1965f36eb5c27f71f3a1f5adcf1/
    http://autobuild.buildroot.org/results/6e4/6e403642069093389acbeeccd7030b76d4ab68be/
    http://autobuild.buildroot.org/results/fa4/fa4c647ce58b91b863d8de5bf9d44b2060a1cf1c/
    and so many others...

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/nut/nut.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/package/nut/nut.mk b/package/nut/nut.mk
index d5babee..b0a92ca 100644
--- a/package/nut/nut.mk
+++ b/package/nut/nut.mk
@@ -50,8 +50,11 @@ else
 NUT_CONF_OPTS += --without-cgi
 endif
 
-# libltdl (libtool) is needed for nut-scanner
-ifeq ($(BR2_PACKAGE_LIBTOOL),y)
+# nut-scanner needs libltdl, which is a wrapper arounf dlopen/dlsym,
+# so is not available for static-only builds.
+# There is no flag to directly enable/disable nut-scanner, it's done
+# via the --enable/disable-libltdl flag.
+ifeq ($(BR2_STATIC_LIBS):$(BR2_PACKAGE_LIBTOOL),:y)
 NUT_DEPENDENCIES += libtool
 NUT_CONF_OPTS += --with-libltdl
 else
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/nut: disable libltdl (and nut-scanner) for static-only
  2015-12-19 18:10 [Buildroot] [PATCH] package/nut: disable libltdl (and nut-scanner) for static-only Yann E. MORIN
@ 2015-12-20 12:58 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-12-20 12:58 UTC (permalink / raw)
  To: buildroot

Dear Yann E. MORIN,

On Sat, 19 Dec 2015 19:10:56 +0100, Yann E. MORIN wrote:
> nut-scanner needs libltdl, a wrapper around dlopen/dlsym. This does not
> really make sense on a static-only build.
> 
> Disable use of libltdl in static-only builds; this disble nut-scanner.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/d8e/d8e769709681b1965f36eb5c27f71f3a1f5adcf1/
>     http://autobuild.buildroot.org/results/6e4/6e403642069093389acbeeccd7030b76d4ab68be/
>     http://autobuild.buildroot.org/results/fa4/fa4c647ce58b91b863d8de5bf9d44b2060a1cf1c/
>     and so many others...
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
>  package/nut/nut.mk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-20 12:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-19 18:10 [Buildroot] [PATCH] package/nut: disable libltdl (and nut-scanner) for static-only Yann E. MORIN
2015-12-20 12:58 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.