[PATCH 20/54] gpio: tz1090: Be sure to clamp return value

[PATCH 20/54] gpio: tz1090: Be sure to clamp return value

[Linus Walleij]

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-tz1090.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
index 79ef6e1ce568..a4a822542ac1 100644
--- a/drivers/gpio/gpio-tz1090.c
+++ b/drivers/gpio/gpio-tz1090.c
@@ -214,7 +214,7 @@ static int tz1090_gpio_get(struct gpio_chip *chip, unsigned int offset)
 {
 	struct tz1090_gpio_bank *bank = to_bank(chip);
 
-	return tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
+	return !!tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
 }
 
 /*
-- 
2.4.3

Re: [PATCH 20/54] gpio: tz1090: Be sure to clamp return value

[James Hogan]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Tue, Dec 22, 2015 at 03:24:26PM +0100, Linus Walleij wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> Cc: James Hogan <james.hogan@imgtec.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> ---
>  drivers/gpio/gpio-tz1090.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-tz1090.c b/drivers/gpio/gpio-tz1090.c
> index 79ef6e1ce568..a4a822542ac1 100644
> --- a/drivers/gpio/gpio-tz1090.c
> +++ b/drivers/gpio/gpio-tz1090.c
> @@ -214,7 +214,7 @@ static int tz1090_gpio_get(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct tz1090_gpio_bank *bank = to_bank(chip);
>  
> -	return tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
> +	return !!tz1090_gpio_read_bit(bank, REG_GPIO_DIN, offset);
>  }
>  
>  /*
> -- 
> 2.4.3
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]