[Buildroot] LIB_SYMLINK in top-level Makefile

[Buildroot] LIB_SYMLINK in top-level Makefile

[Steven Noonan]

Are the LIB_SYMLINK definitions in the top-level Makefile defined at
the time they're used in package/skeleton/skeleton.mk? It looks like
those lines didn't get moved along with the rest of the bits from the
$(STAGING_DIR) target.

[Buildroot] LIB_SYMLINK in top-level Makefile

[Thomas De Schampheleire]

Hi Steven,

On Wed, Dec 23, 2015 at 9:44 AM, Steven Noonan <steven@uplinklabs.net> wrote:
> Are the LIB_SYMLINK definitions in the top-level Makefile defined at
> the time they're used in package/skeleton/skeleton.mk? It looks like
> those lines didn't get moved along with the rest of the bits from the
> $(STAGING_DIR) target.

They are defined, so functionally things are fine, but nevertheless it
would have been cleaner if they'd had been moved.

Anyway, see related patch http://patchwork.ozlabs.org/patch/560003/
which moves the definitions in toolchain/helpers.mk.

/Thomas

[Buildroot] LIB_SYMLINK in top-level Makefile

[Yann E. MORIN]

Steven, All,

On 2015-12-23 00:44 -0800, Steven Noonan spake thusly:
> Are the LIB_SYMLINK definitions in the top-level Makefile defined at
> the time they're used in package/skeleton/skeleton.mk? It looks like
> those lines didn't get moved along with the rest of the bits from the
> $(STAGING_DIR) target.

As Thomas already replied, they are.

And even if they are defined after they are used', that is not a
problem. In Makefiles, the expansion of variables is not done at
the time of parsing, but at the time the rules are executed.

For example, test this simple Makefile:

    $ cat Makefile
    all:
        @echo FOO="'$(FOO)'"
    FOO=1234

    $ make
    FOO='1234'

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] LIB_SYMLINK in top-level Makefile

[Steven Noonan]

My question was not about order of operations but rather whether any
definitions in the top-level Makefile applied to package .mk files. I
wasn't sure whether those were invoked in a sub-make or similar. From your
response it's clear they are included into the main Make process.
On Dec 23, 2015 11:09 AM, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Steven, All,
>
> On 2015-12-23 00:44 -0800, Steven Noonan spake thusly:
> > Are the LIB_SYMLINK definitions in the top-level Makefile defined at
> > the time they're used in package/skeleton/skeleton.mk? It looks like
> > those lines didn't get moved along with the rest of the bits from the
> > $(STAGING_DIR) target.
>
> As Thomas already replied, they are.
>
> And even if they are defined after they are used', that is not a
> problem. In Makefiles, the expansion of variables is not done at
> the time of parsing, but at the time the rules are executed.
>
> For example, test this simple Makefile:
>
>     $ cat Makefile
>     all:
>         @echo FOO="'$(FOO)'"
>     FOO=1234
>
>     $ make
>     FOO='1234'
>
> Regards,
> Yann E. MORIN.
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151223/4d771794/attachment.html>

[Buildroot] LIB_SYMLINK in top-level Makefile

[Yann E. MORIN]

Steven, All,

On 2015-12-23 13:32 -0800, Steven Noonan spake thusly:
> My question was not about order of operations but rather whether any
> definitions in the top-level Makefile applied to package .mk files. I
> wasn't sure whether those were invoked in a sub-make or similar. From your
> response it's clear they are included into the main Make process.

Ah, sorry, I misunderstood your question, then.

We're only doing a single-level make, there's no sub-make.

Well, in fact, there can be sub-makes, if your umask is not what
Buildroot expects, but then the to-most make only set the umask
correctly before it calls a sub-make that does all the job.

Another case where you may see a sub-make being run is when you build
out-of-tree, in which case, the top-most make is just a wrapper to the
Makefile in Buildroot's topdir.

So, in all cases, all build actions are done in a single invocation of
make, so there's no need to propagate variables to sub-makes as there
are none.

Regards,
Yann E. MORIN.

> On Dec 23, 2015 11:09 AM, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> > Steven, All,
> >
> > On 2015-12-23 00:44 -0800, Steven Noonan spake thusly:
> > > Are the LIB_SYMLINK definitions in the top-level Makefile defined at
> > > the time they're used in package/skeleton/skeleton.mk? It looks like
> > > those lines didn't get moved along with the rest of the bits from the
> > > $(STAGING_DIR) target.
> >
> > As Thomas already replied, they are.
> >
> > And even if they are defined after they are used', that is not a
> > problem. In Makefiles, the expansion of variables is not done at
> > the time of parsing, but at the time the rules are executed.
> >
> > For example, test this simple Makefile:
> >
> >     $ cat Makefile
> >     all:
> >         @echo FOO="'$(FOO)'"
> >     FOO=1234
> >
> >     $ make
> >     FOO='1234'
> >
> > Regards,
> > Yann E. MORIN.
> >
> > --
> >
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> > conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
> >      |
> > | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
> > no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
> >  conspiracy.  |
> >
> > '------------------------------^-------^------------------^--------------------'
> >

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'