All of lore.kernel.org
 help / color / mirror / Atom feed
* re: drm/etnaviv: add initial etnaviv DRM driver
@ 2015-12-24  7:30 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-12-24  7:30 UTC (permalink / raw)
  To: dri-devel, Christian Gmeiner

Hello The etnaviv authors,

The patch a8c21a5451d8: "drm/etnaviv: add initial etnaviv DRM driver"
from Dec 3, 2015, leads to the following static checker warning:

	drivers/gpu/drm/etnaviv/etnaviv_gpu.c:254 etnaviv_hw_identify()
	warn: masked condition '(((chipIdentity) << 24) & 4278190080) == 1' is always false.

drivers/gpu/drm/etnaviv/etnaviv_gpu.c
   247  static void etnaviv_hw_identify(struct etnaviv_gpu *gpu)
   248  {
   249          u32 chipIdentity;
   250  
   251          chipIdentity = gpu_read(gpu, VIVS_HI_CHIP_IDENTITY);
   252  
   253          /* Special case for older graphic cores. */
   254          if (VIVS_HI_CHIP_IDENTITY_FAMILY(chipIdentity) ==  0x01) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not possibly true.

   255                  gpu->identity.model    = 0x500; /* gc500 */
   256                  gpu->identity.revision = VIVS_HI_CHIP_IDENTITY_REVISION(chipIdentity);
   257          } else {
   258  

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-12-24  7:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-24  7:30 drm/etnaviv: add initial etnaviv DRM driver Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.