All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2015-12-29 22:22 Heinrich Schuchardt
  2015-12-30 10:56   ` Michael Kerrisk (man-pages)
  2016-01-04 22:19   ` David Miller
  0 siblings, 2 replies; 9+ messages in thread
From: Heinrich Schuchardt @ 2015-12-29 22:22 UTC (permalink / raw)
  To: David S. Miller
  Cc: linux-api, linux-kernel, Alexey Kuznetsov, James Morris,
	Hideaki YOSHIFUJI, Patrick McHardy, netdev, Heinrich Schuchardt

IOCTL SIOCRTMSG does nothing but return EINVAL.

So comment it as unused.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/uapi/linux/sockios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
index e888b1a..8e7890b 100644
--- a/include/uapi/linux/sockios.h
+++ b/include/uapi/linux/sockios.h
@@ -27,7 +27,7 @@
 /* Routing table calls. */
 #define SIOCADDRT	0x890B		/* add routing table entry	*/
 #define SIOCDELRT	0x890C		/* delete routing table entry	*/
-#define SIOCRTMSG	0x890D		/* call to routing system	*/
+#define SIOCRTMSG	0x890D		/* unused			*/
 
 /* Socket configuration controls. */
 #define SIOCGIFNAME	0x8910		/* get iface name		*/
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2015-12-30 10:56   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Kerrisk (man-pages) @ 2015-12-30 10:56 UTC (permalink / raw)
  To: Heinrich Schuchardt, David S. Miller
  Cc: mtk.manpages, linux-api, linux-kernel, Alexey Kuznetsov,
	James Morris, Hideaki YOSHIFUJI, Patrick McHardy, netdev

Hi Heinrich,

On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.

Can you say something about how you confirmed this?
It's not immediately obvious from the code.

Cheers,

Michael


> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/uapi/linux/sockios.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
> index e888b1a..8e7890b 100644
> --- a/include/uapi/linux/sockios.h
> +++ b/include/uapi/linux/sockios.h
> @@ -27,7 +27,7 @@
>  /* Routing table calls. */
>  #define SIOCADDRT	0x890B		/* add routing table entry	*/
>  #define SIOCDELRT	0x890C		/* delete routing table entry	*/
> -#define SIOCRTMSG	0x890D		/* call to routing system	*/
> +#define SIOCRTMSG	0x890D		/* unused			*/
>  
>  /* Socket configuration controls. */
>  #define SIOCGIFNAME	0x8910		/* get iface name		*/
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2015-12-30 10:56   ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 9+ messages in thread
From: Michael Kerrisk (man-pages) @ 2015-12-30 10:56 UTC (permalink / raw)
  To: Heinrich Schuchardt, David S. Miller
  Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
	linux-api-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alexey Kuznetsov,
	James Morris, Hideaki YOSHIFUJI, Patrick McHardy,
	netdev-u79uwXL29TY76Z2rM5mHXA

Hi Heinrich,

On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.

Can you say something about how you confirmed this?
It's not immediately obvious from the code.

Cheers,

Michael


> Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
> ---
>  include/uapi/linux/sockios.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
> index e888b1a..8e7890b 100644
> --- a/include/uapi/linux/sockios.h
> +++ b/include/uapi/linux/sockios.h
> @@ -27,7 +27,7 @@
>  /* Routing table calls. */
>  #define SIOCADDRT	0x890B		/* add routing table entry	*/
>  #define SIOCDELRT	0x890C		/* delete routing table entry	*/
> -#define SIOCRTMSG	0x890D		/* call to routing system	*/
> +#define SIOCRTMSG	0x890D		/* unused			*/
>  
>  /* Socket configuration controls. */
>  #define SIOCGIFNAME	0x8910		/* get iface name		*/
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
  2015-12-30 10:56   ` Michael Kerrisk (man-pages)
  (?)
@ 2015-12-30 11:14   ` Heinrich Schuchardt
  -1 siblings, 0 replies; 9+ messages in thread
From: Heinrich Schuchardt @ 2015-12-30 11:14 UTC (permalink / raw)
  To: Michael Kerrisk (man-pages), David S. Miller
  Cc: linux-api, linux-kernel, Alexey Kuznetsov, James Morris,
	Hideaki YOSHIFUJI, Patrick McHardy, netdev

On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote:
> Hi Heinrich,
> 
> On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote:
>> IOCTL SIOCRTMSG does nothing but return EINVAL.
>>
>> So comment it as unused.
> 
> Can you say something about how you confirmed this?
> It's not immediately obvious from the code.
> 
> Cheers,
> 
> Michael

grep -GHrn SIOCRTMSG

SIOCRTMSG is only used in:
* net/ipv4/af_inet.c
* include/uapi/linux/sockios.h

inet_ioctl calls ip_rt_ioctl.

ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
otherwise.

cf.
http://lkml.iu.edu/hypermail/linux/kernel/0911.0/02636.html

Best regards

Heinrich

> 
> 
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  include/uapi/linux/sockios.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
>> index e888b1a..8e7890b 100644
>> --- a/include/uapi/linux/sockios.h
>> +++ b/include/uapi/linux/sockios.h
>> @@ -27,7 +27,7 @@
>>  /* Routing table calls. */
>>  #define SIOCADDRT	0x890B		/* add routing table entry	*/
>>  #define SIOCDELRT	0x890C		/* delete routing table entry	*/
>> -#define SIOCRTMSG	0x890D		/* call to routing system	*/
>> +#define SIOCRTMSG	0x890D		/* unused			*/
>>  
>>  /* Socket configuration controls. */
>>  #define SIOCGIFNAME	0x8910		/* get iface name		*/
>>
> 
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2016-01-04 22:19   ` David Miller
  0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2016-01-04 22:19 UTC (permalink / raw)
  To: xypron.glpk
  Cc: linux-api, linux-kernel, kuznet, jmorris, yoshfuji, kaber, netdev

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 29 Dec 2015 23:22:02 +0100

> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Please enhance your commit log message to include the analysis you
provided in your reply to Michael Kerrisk.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2016-01-04 22:19   ` David Miller
  0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2016-01-04 22:19 UTC (permalink / raw)
  To: xypron.glpk-Mmb7MZpHnFY
  Cc: linux-api-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	kuznet-v/Mj1YrvjDBInbfyfbPRSQ, jmorris-gx6/JNMH7DfYtjvyW6yDsg,
	yoshfuji-VfPWfsRibaP+Ru+s062T9g, kaber-dcUjhNyLwpNeoWH0uzbU5w,
	netdev-u79uwXL29TY76Z2rM5mHXA

From: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
Date: Tue, 29 Dec 2015 23:22:02 +0100

> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>

Please enhance your commit log message to include the analysis you
provided in your reply to Michael Kerrisk.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
  2016-01-04 22:19   ` David Miller
  (?)
@ 2016-01-05  9:12   ` Heinrich Schuchardt
  2016-01-05 21:44       ` David Miller
  -1 siblings, 1 reply; 9+ messages in thread
From: Heinrich Schuchardt @ 2016-01-05  9:12 UTC (permalink / raw)
  To: David S. Miller
  Cc: linux-api, linux-kernel, Michael Kerrisk (man-pages),
	Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI,
	Patrick McHardy, netdev, Heinrich Schuchardt

IOCTL SIOCRTMSG does nothing but return EINVAL.

So comment it as unused.

SIOCRTMSG is only used in:
* net/ipv4/af_inet.c
* include/uapi/linux/sockios.h

inet_ioctl calls ip_rt_ioctl.
ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
otherwise.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/uapi/linux/sockios.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h
index e888b1a..8e7890b 100644
--- a/include/uapi/linux/sockios.h
+++ b/include/uapi/linux/sockios.h
@@ -27,7 +27,7 @@
 /* Routing table calls. */
 #define SIOCADDRT	0x890B		/* add routing table entry	*/
 #define SIOCDELRT	0x890C		/* delete routing table entry	*/
-#define SIOCRTMSG	0x890D		/* call to routing system	*/
+#define SIOCRTMSG	0x890D		/* unused			*/
 
 /* Socket configuration controls. */
 #define SIOCGIFNAME	0x8910		/* get iface name		*/
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2016-01-05 21:44       ` David Miller
  0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2016-01-05 21:44 UTC (permalink / raw)
  To: xypron.glpk
  Cc: linux-api, linux-kernel, mtk.manpages, kuznet, jmorris, yoshfuji,
	kaber, netdev

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue,  5 Jan 2016 10:12:49 +0100

> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.
> 
> SIOCRTMSG is only used in:
> * net/ipv4/af_inet.c
> * include/uapi/linux/sockios.h
> 
> inet_ioctl calls ip_rt_ioctl.
> ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
> otherwise.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused
@ 2016-01-05 21:44       ` David Miller
  0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2016-01-05 21:44 UTC (permalink / raw)
  To: xypron.glpk-Mmb7MZpHnFY
  Cc: linux-api-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
	kuznet-v/Mj1YrvjDBInbfyfbPRSQ, jmorris-gx6/JNMH7DfYtjvyW6yDsg,
	yoshfuji-VfPWfsRibaP+Ru+s062T9g, kaber-dcUjhNyLwpNeoWH0uzbU5w,
	netdev-u79uwXL29TY76Z2rM5mHXA

From: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
Date: Tue,  5 Jan 2016 10:12:49 +0100

> IOCTL SIOCRTMSG does nothing but return EINVAL.
> 
> So comment it as unused.
> 
> SIOCRTMSG is only used in:
> * net/ipv4/af_inet.c
> * include/uapi/linux/sockios.h
> 
> inet_ioctl calls ip_rt_ioctl.
> ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL
> otherwise.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-01-05 21:44 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-29 22:22 [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused Heinrich Schuchardt
2015-12-30 10:56 ` Michael Kerrisk (man-pages)
2015-12-30 10:56   ` Michael Kerrisk (man-pages)
2015-12-30 11:14   ` Heinrich Schuchardt
2016-01-04 22:19 ` David Miller
2016-01-04 22:19   ` David Miller
2016-01-05  9:12   ` [PATCH 1/1 v2] " Heinrich Schuchardt
2016-01-05 21:44     ` David Miller
2016-01-05 21:44       ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.