* [PATCH] OrangeFS: constify export_operations structures
@ 2016-01-01 9:01 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-01-01 9:01 UTC (permalink / raw)
To: linux-kernel, Mike Marshall; +Cc: kernel-janitors
This export_operations structure is never modified, so declare it as const.
Most other structures of this type are already const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Mike, I saw your name on all of the patches for this driver, but you aren't
in the MAINTAINERS file. If you are the maintainer of this file, maybe you
should add yourself there.
fs/orangefs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
index 52bc522..bee67b3 100644
--- a/fs/orangefs/super.c
+++ b/fs/orangefs/super.c
@@ -342,7 +342,7 @@ out:
return type;
}
-static struct export_operations orangefs_export_ops = {
+static const struct export_operations orangefs_export_ops = {
.encode_fh = orangefs_encode_fh,
.fh_to_dentry = orangefs_fh_to_dentry,
};
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] OrangeFS: constify export_operations structures
@ 2016-01-01 9:01 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-01-01 9:01 UTC (permalink / raw)
To: linux-kernel, Mike Marshall; +Cc: kernel-janitors
This export_operations structure is never modified, so declare it as const.
Most other structures of this type are already const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
Mike, I saw your name on all of the patches for this driver, but you aren't
in the MAINTAINERS file. If you are the maintainer of this file, maybe you
should add yourself there.
fs/orangefs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
index 52bc522..bee67b3 100644
--- a/fs/orangefs/super.c
+++ b/fs/orangefs/super.c
@@ -342,7 +342,7 @@ out:
return type;
}
-static struct export_operations orangefs_export_ops = {
+static const struct export_operations orangefs_export_ops = {
.encode_fh = orangefs_encode_fh,
.fh_to_dentry = orangefs_fh_to_dentry,
};
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
2016-01-01 9:01 ` Julia Lawall
@ 2016-01-04 16:18 ` Mike Marshall
-1 siblings, 0 replies; 8+ messages in thread
From: Mike Marshall @ 2016-01-04 16:18 UTC (permalink / raw)
To: Julia Lawall; +Cc: LKML, kernel-janitors
Hi Julia... thanks for the patch... I've applied it to my github repo,
so it will be in the next push to kernel.org.
Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
don't belong in the MAINTAINERS file yet...
-Mike
On Fri, Jan 1, 2016 at 4:01 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> This export_operations structure is never modified, so declare it as const.
> Most other structures of this type are already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>
> Mike, I saw your name on all of the patches for this driver, but you aren't
> in the MAINTAINERS file. If you are the maintainer of this file, maybe you
> should add yourself there.
>
> fs/orangefs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
> index 52bc522..bee67b3 100644
> --- a/fs/orangefs/super.c
> +++ b/fs/orangefs/super.c
> @@ -342,7 +342,7 @@ out:
> return type;
> }
>
> -static struct export_operations orangefs_export_ops = {
> +static const struct export_operations orangefs_export_ops = {
> .encode_fh = orangefs_encode_fh,
> .fh_to_dentry = orangefs_fh_to_dentry,
> };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
@ 2016-01-04 16:18 ` Mike Marshall
0 siblings, 0 replies; 8+ messages in thread
From: Mike Marshall @ 2016-01-04 16:18 UTC (permalink / raw)
To: Julia Lawall; +Cc: LKML, kernel-janitors
Hi Julia... thanks for the patch... I've applied it to my github repo,
so it will be in the next push to kernel.org.
Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
don't belong in the MAINTAINERS file yet...
-Mike
On Fri, Jan 1, 2016 at 4:01 AM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> This export_operations structure is never modified, so declare it as const.
> Most other structures of this type are already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>
> Mike, I saw your name on all of the patches for this driver, but you aren't
> in the MAINTAINERS file. If you are the maintainer of this file, maybe you
> should add yourself there.
>
> fs/orangefs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
> index 52bc522..bee67b3 100644
> --- a/fs/orangefs/super.c
> +++ b/fs/orangefs/super.c
> @@ -342,7 +342,7 @@ out:
> return type;
> }
>
> -static struct export_operations orangefs_export_ops = {
> +static const struct export_operations orangefs_export_ops = {
> .encode_fh = orangefs_encode_fh,
> .fh_to_dentry = orangefs_fh_to_dentry,
> };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
2016-01-04 16:18 ` Mike Marshall
@ 2016-01-04 18:45 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-01-04 18:45 UTC (permalink / raw)
To: Mike Marshall; +Cc: Julia Lawall, LKML, kernel-janitors
On Mon, Jan 04, 2016 at 11:18:00AM -0500, Mike Marshall wrote:
> Hi Julia... thanks for the patch... I've applied it to my github repo,
> so it will be in the next push to kernel.org.
>
> Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
> don't belong in the MAINTAINERS file yet...
>
It's in linux-next though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
@ 2016-01-04 18:45 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-01-04 18:45 UTC (permalink / raw)
To: Mike Marshall; +Cc: Julia Lawall, LKML, kernel-janitors
On Mon, Jan 04, 2016 at 11:18:00AM -0500, Mike Marshall wrote:
> Hi Julia... thanks for the patch... I've applied it to my github repo,
> so it will be in the next push to kernel.org.
>
> Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
> don't belong in the MAINTAINERS file yet...
>
It's in linux-next though.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
2016-01-04 18:45 ` Dan Carpenter
@ 2016-01-05 15:34 ` Mike Marshall
-1 siblings, 0 replies; 8+ messages in thread
From: Mike Marshall @ 2016-01-05 15:34 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Julia Lawall, LKML, kernel-janitors
I checked with Stephen Rothwell too, and he agrees with y'all
that there should be a Orangefs stanza in the MAINTAINERS
file... it will be there next time I push to kernel.org...
Thanks!
-Mike
On Mon, Jan 4, 2016 at 1:45 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jan 04, 2016 at 11:18:00AM -0500, Mike Marshall wrote:
>> Hi Julia... thanks for the patch... I've applied it to my github repo,
>> so it will be in the next push to kernel.org.
>>
>> Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
>> don't belong in the MAINTAINERS file yet...
>>
>
> It's in linux-next though.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] OrangeFS: constify export_operations structures
@ 2016-01-05 15:34 ` Mike Marshall
0 siblings, 0 replies; 8+ messages in thread
From: Mike Marshall @ 2016-01-05 15:34 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Julia Lawall, LKML, kernel-janitors
I checked with Stephen Rothwell too, and he agrees with y'all
that there should be a Orangefs stanza in the MAINTAINERS
file... it will be there next time I push to kernel.org...
Thanks!
-Mike
On Mon, Jan 4, 2016 at 1:45 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jan 04, 2016 at 11:18:00AM -0500, Mike Marshall wrote:
>> Hi Julia... thanks for the patch... I've applied it to my github repo,
>> so it will be in the next push to kernel.org.
>>
>> Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
>> don't belong in the MAINTAINERS file yet...
>>
>
> It's in linux-next though.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-01-05 15:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-01 9:01 [PATCH] OrangeFS: constify export_operations structures Julia Lawall
2016-01-01 9:01 ` Julia Lawall
2016-01-04 16:18 ` Mike Marshall
2016-01-04 16:18 ` Mike Marshall
2016-01-04 18:45 ` Dan Carpenter
2016-01-04 18:45 ` Dan Carpenter
2016-01-05 15:34 ` Mike Marshall
2016-01-05 15:34 ` Mike Marshall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.