Re: [PATCH 09/10] [media] tvp5150: Initialize the chip on probe

From: kbuild test robot <lkp@intel.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Enrico Butera <ebutera@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Enric Balletbo i Serra <eballetbo@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Eduard Gavin <egavinc@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	linux-media@vger.kernel.org,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH 09/10] [media] tvp5150: Initialize the chip on probe
Date: Mon, 4 Jan 2016 20:40:42 +0800	[thread overview]
Message-ID: <201601042006.Dk9Wav4W%fengguang.wu@intel.com> (raw)
In-Reply-To: <1451910332-23385-10-git-send-email-javier@osg.samsung.com>

[-- Attachment #1: Type: text/plain, Size: 2207 bytes --]

Hi Javier,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.4-rc8 next-20151231]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Javier-Martinez-Canillas/tvp5150-add-MC-and-DT-support/20160104-203224
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x008-01040711 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/media/i2c/tvp5150.c: In function 'tvp5150_init':
>> drivers/media/i2c/tvp5150.c:1206:13: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
     pdn_gpio = devm_gpiod_get_optional(&c->dev, "powerdown", GPIOD_OUT_HIGH);
                ^
>> drivers/media/i2c/tvp5150.c:1206:59: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function)
     pdn_gpio = devm_gpiod_get_optional(&c->dev, "powerdown", GPIOD_OUT_HIGH);
                                                              ^
   drivers/media/i2c/tvp5150.c:1206:59: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/media/i2c/tvp5150.c:1211:3: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
      gpiod_set_value_cansleep(pdn_gpio, 0);
      ^
   cc1: some warnings being treated as errors

vim +/devm_gpiod_get_optional +1206 drivers/media/i2c/tvp5150.c

  1200	
  1201	static inline int tvp5150_init(struct i2c_client *c)
  1202	{
  1203		struct gpio_desc *pdn_gpio;
  1204		struct gpio_desc *reset_gpio;
  1205	
> 1206		pdn_gpio = devm_gpiod_get_optional(&c->dev, "powerdown", GPIOD_OUT_HIGH);
  1207		if (IS_ERR(pdn_gpio))
  1208			return PTR_ERR(pdn_gpio);
  1209	
  1210		if (pdn_gpio) {
> 1211			gpiod_set_value_cansleep(pdn_gpio, 0);
  1212			/* Delay time between power supplies active and reset */
  1213			msleep(20);
  1214		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 21835 bytes --]