All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen <dave@sr71.net>,
	dave.hansen@linux.intel.com
Subject: [PATCH 08/31] x86, pkeys: new page fault error code bit: PF_PK
Date: Wed, 06 Jan 2016 16:01:16 -0800	[thread overview]
Message-ID: <20160107000116.1A4FFAD4@viggo.jf.intel.com> (raw)
In-Reply-To: <20160107000104.1A105322@viggo.jf.intel.com>


From: Dave Hansen <dave.hansen@linux.intel.com>

Note: "PK" is how the Intel SDM refers to this bit, so we also
use that nomenclature.

This only defines the bit, it does not plumb it anywhere to be
handled.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
---

 b/arch/x86/mm/fault.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff -puN arch/x86/mm/fault.c~pkeys-05-pfec arch/x86/mm/fault.c
--- a/arch/x86/mm/fault.c~pkeys-05-pfec	2016-01-06 15:50:06.068176638 -0800
+++ b/arch/x86/mm/fault.c	2016-01-06 15:50:06.071176773 -0800
@@ -33,6 +33,7 @@
  *   bit 2 ==	 0: kernel-mode access	1: user-mode access
  *   bit 3 ==				1: use of reserved bit detected
  *   bit 4 ==				1: fault was an instruction fetch
+ *   bit 5 ==				1: protection keys block access
  */
 enum x86_pf_error_code {
 
@@ -41,6 +42,7 @@ enum x86_pf_error_code {
 	PF_USER		=		1 << 2,
 	PF_RSVD		=		1 << 3,
 	PF_INSTR	=		1 << 4,
+	PF_PK		=		1 << 5,
 };
 
 /*
@@ -916,6 +918,12 @@ static int spurious_fault_check(unsigned
 
 	if ((error_code & PF_INSTR) && !pte_exec(*pte))
 		return 0;
+	/*
+	 * Note: We do not do lazy flushing on protection key
+	 * changes, so no spurious fault will ever set PF_PK.
+	 */
+	if ((error_code & PF_PK))
+		return 1;
 
 	return 1;
 }
_

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, Dave Hansen <dave@sr71.net>,
	dave.hansen@linux.intel.com
Subject: [PATCH 08/31] x86, pkeys: new page fault error code bit: PF_PK
Date: Wed, 06 Jan 2016 16:01:16 -0800	[thread overview]
Message-ID: <20160107000116.1A4FFAD4@viggo.jf.intel.com> (raw)
In-Reply-To: <20160107000104.1A105322@viggo.jf.intel.com>


From: Dave Hansen <dave.hansen@linux.intel.com>

Note: "PK" is how the Intel SDM refers to this bit, so we also
use that nomenclature.

This only defines the bit, it does not plumb it anywhere to be
handled.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
---

 b/arch/x86/mm/fault.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff -puN arch/x86/mm/fault.c~pkeys-05-pfec arch/x86/mm/fault.c
--- a/arch/x86/mm/fault.c~pkeys-05-pfec	2016-01-06 15:50:06.068176638 -0800
+++ b/arch/x86/mm/fault.c	2016-01-06 15:50:06.071176773 -0800
@@ -33,6 +33,7 @@
  *   bit 2 ==	 0: kernel-mode access	1: user-mode access
  *   bit 3 ==				1: use of reserved bit detected
  *   bit 4 ==				1: fault was an instruction fetch
+ *   bit 5 ==				1: protection keys block access
  */
 enum x86_pf_error_code {
 
@@ -41,6 +42,7 @@ enum x86_pf_error_code {
 	PF_USER		=		1 << 2,
 	PF_RSVD		=		1 << 3,
 	PF_INSTR	=		1 << 4,
+	PF_PK		=		1 << 5,
 };
 
 /*
@@ -916,6 +918,12 @@ static int spurious_fault_check(unsigned
 
 	if ((error_code & PF_INSTR) && !pte_exec(*pte))
 		return 0;
+	/*
+	 * Note: We do not do lazy flushing on protection key
+	 * changes, so no spurious fault will ever set PF_PK.
+	 */
+	if ((error_code & PF_PK))
+		return 1;
 
 	return 1;
 }
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-01-07  0:01 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07  0:01 [PATCH 00/31] x86: Memory Protection Keys (v8) Dave Hansen
2016-01-07  0:01 ` Dave Hansen
2016-01-07  0:01 ` [PATCH 01/31] mm, gup: introduce concept of "foreign" get_user_pages() Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-13 19:00   ` Vlastimil Babka
2016-01-13 19:00     ` Vlastimil Babka
2016-01-13 19:16     ` Dave Hansen
2016-01-13 19:16       ` Dave Hansen
2016-01-07  0:01 ` [PATCH 02/31] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 03/31] x86, pkeys: Add Kconfig option Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 04/31] x86, pkeys: cpuid bit definition Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 05/31] x86, pkeys: define new CR4 bit Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 06/31] x86, pkeys: add PKRU xsave fields and data structure(s) Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 07/31] x86, pkeys: PTE bits for storing protection key Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` Dave Hansen [this message]
2016-01-07  0:01   ` [PATCH 08/31] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2016-01-07  0:01 ` [PATCH 09/31] x86, pkeys: store protection in high VMA flags Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 10/31] x86, pkeys: arch-specific protection bits Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-08 19:31   ` Thomas Gleixner
2016-01-07  0:01 ` [PATCH 11/31] x86, pkeys: pass VMA down in to fault signal generation code Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 12/31] signals, pkeys: notify userspace about protection key faults Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 13/31] x86, pkeys: fill in pkey field in siginfo Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 14/31] x86, pkeys: add functions to fetch PKRU Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-08 19:32   ` Thomas Gleixner
2016-01-07  0:01 ` [PATCH 15/31] mm: factor out VMA fault permission checking Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 16/31] x86, mm: simplify get_user_pages() PTE bit handling Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 17/31] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 18/31] mm: add gup flag to indicate "foreign" mm access Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 19/31] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 20/31] x86, pkeys: differentiate instruction fetches Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 21/31] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 22/31] x86, pkeys: dump pkey from VMA in /proc/pid/smaps Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 23/31] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 24/31] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 25/31] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 26/31] x86, pkeys: add arch_validate_pkey() Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-08 19:34   ` Thomas Gleixner
2016-01-07  0:01 ` [PATCH 27/31] x86: separate out LDT init from context init Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 28/31] x86, fpu: allow setting of XSAVE state Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07  0:01 ` [PATCH 29/31] x86, pkeys: allow kernel to modify user pkey rights register Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-08 19:40   ` Thomas Gleixner
2016-01-07  0:01 ` [PATCH 30/31] x86, pkeys: create an x86 arch_calc_vm_prot_bits() for VMA flags Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-08 19:40   ` Thomas Gleixner
2016-01-07  0:01 ` [PATCH 31/31] x86, pkeys: execute-only support Dave Hansen
2016-01-07  0:01   ` Dave Hansen
2016-01-07 21:02   ` Kees Cook
2016-01-07 21:02     ` Kees Cook
2016-01-07 22:25     ` Dave Hansen
2016-01-07 22:25       ` Dave Hansen
2016-01-07 21:10   ` Andy Lutomirski
2016-01-07 21:10     ` Andy Lutomirski
2016-01-07 22:13     ` Dave Hansen
2016-01-07 22:13       ` Dave Hansen
2016-01-07 22:44       ` Andy Lutomirski
2016-01-07 22:44         ` Andy Lutomirski
2016-01-08 19:51   ` Thomas Gleixner
2016-01-08 19:51     ` Thomas Gleixner
2016-01-29 18:16 [PATCH 00/31] x86: Memory Protection Keys (v9) Dave Hansen
2016-01-29 18:16 ` [PATCH 08/31] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2016-01-29 18:16   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107000116.1A4FFAD4@viggo.jf.intel.com \
    --to=dave@sr71.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.