backport 6d4f5440a3a2 to 4.3?

backport 6d4f5440a3a2 to 4.3?

[Andy Lutomirski]

Hi, Mika and Greg-

Should this commit:

commit 6d4f5440a3a2bb2e9d0d582bbf98234e9e9bb095
Author: Mika Westerberg <mika.westerberg@linux.intel.com>
Date:   Wed Oct 7 15:33:43 2015 +0300

    HID: multitouch: Fetch feature reports on demand for Win8 devices

be backported to 4.3?

AFAICT the issue affects a range of Skylake systems, but only on Linux
4.3, because 4.2 and below don't have the intel_lpss driver and end up
driving the pad in compatibility mode, which isn't affected.

--Andy

Re: backport 6d4f5440a3a2 to 4.3?

[Greg KH]

On Thu, Jan 07, 2016 at 12:09:34PM -0800, Andy Lutomirski wrote:
> Hi, Mika and Greg-
> 
> Should this commit:
> 
> commit 6d4f5440a3a2bb2e9d0d582bbf98234e9e9bb095
> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> Date:   Wed Oct 7 15:33:43 2015 +0300
> 
>     HID: multitouch: Fetch feature reports on demand for Win8 devices
> 
> be backported to 4.3?
> 
> AFAICT the issue affects a range of Skylake systems, but only on Linux
> 4.3, because 4.2 and below don't have the intel_lpss driver and end up
> driving the pad in compatibility mode, which isn't affected.

Looks reasonable to me, is it a clean "cherry-pick"?

thanks,

greg k-h

Re: backport 6d4f5440a3a2 to 4.3?

[Andy Lutomirski]

On Thu, Jan 7, 2016 at 12:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Jan 07, 2016 at 12:09:34PM -0800, Andy Lutomirski wrote:
>> Hi, Mika and Greg-
>>
>> Should this commit:
>>
>> commit 6d4f5440a3a2bb2e9d0d582bbf98234e9e9bb095
>> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
>> Date:   Wed Oct 7 15:33:43 2015 +0300
>>
>>     HID: multitouch: Fetch feature reports on demand for Win8 devices
>>
>> be backported to 4.3?
>>
>> AFAICT the issue affects a range of Skylake systems, but only on Linux
>> 4.3, because 4.2 and below don't have the intel_lpss driver and end up
>> driving the pad in compatibility mode, which isn't affected.
>
> Looks reasonable to me, is it a clean "cherry-pick"?

It is, and I've even tested it on a 4.3 kernel on my laptop.

I'd prefer to get either Mika or Benjamin's ok first, though.

--Andy

Re: backport 6d4f5440a3a2 to 4.3?

[Benjamin Tissoires]

On Jan 07 2016 or thereabouts, Andy Lutomirski wrote:
> On Thu, Jan 7, 2016 at 12:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 07, 2016 at 12:09:34PM -0800, Andy Lutomirski wrote:
> >> Hi, Mika and Greg-
> >>
> >> Should this commit:
> >>
> >> commit 6d4f5440a3a2bb2e9d0d582bbf98234e9e9bb095
> >> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> >> Date:   Wed Oct 7 15:33:43 2015 +0300
> >>
> >>     HID: multitouch: Fetch feature reports on demand for Win8 devices
> >>
> >> be backported to 4.3?
> >>
> >> AFAICT the issue affects a range of Skylake systems, but only on Linux
> >> 4.3, because 4.2 and below don't have the intel_lpss driver and end up
> >> driving the pad in compatibility mode, which isn't affected.
> >
> > Looks reasonable to me, is it a clean "cherry-pick"?
> 
> It is, and I've even tested it on a 4.3 kernel on my laptop.
> 
> I'd prefer to get either Mika or Benjamin's ok first, though.
> 

I think we are safe with 4.3 with this one. We limited the scope of it
and made tests on a few hardwares when testing upstream. It was
submitted during 4.3 rc cycles, so that's why it's in 4.4 and not 4.3.

Backport-Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

Re: backport 6d4f5440a3a2 to 4.3?

[Mika Westerberg]

On Fri, Jan 08, 2016 at 09:26:01AM +0100, Benjamin Tissoires wrote:
> On Jan 07 2016 or thereabouts, Andy Lutomirski wrote:
> > On Thu, Jan 7, 2016 at 12:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Thu, Jan 07, 2016 at 12:09:34PM -0800, Andy Lutomirski wrote:
> > >> Hi, Mika and Greg-
> > >>
> > >> Should this commit:
> > >>
> > >> commit 6d4f5440a3a2bb2e9d0d582bbf98234e9e9bb095
> > >> Author: Mika Westerberg <mika.westerberg@linux.intel.com>
> > >> Date:   Wed Oct 7 15:33:43 2015 +0300
> > >>
> > >>     HID: multitouch: Fetch feature reports on demand for Win8 devices
> > >>
> > >> be backported to 4.3?
> > >>
> > >> AFAICT the issue affects a range of Skylake systems, but only on Linux
> > >> 4.3, because 4.2 and below don't have the intel_lpss driver and end up
> > >> driving the pad in compatibility mode, which isn't affected.
> > >
> > > Looks reasonable to me, is it a clean "cherry-pick"?
> > 
> > It is, and I've even tested it on a 4.3 kernel on my laptop.
> > 
> > I'd prefer to get either Mika or Benjamin's ok first, though.
> > 
> 
> I think we are safe with 4.3 with this one. We limited the scope of it
> and made tests on a few hardwares when testing upstream. It was
> submitted during 4.3 rc cycles, so that's why it's in 4.4 and not 4.3.
> 
> Backport-Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

No objections from me either.