From: Joerg Roedel <joro@8bytes.org>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: Wan Zongshun <vincent.wan@amd.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu@lists.linux-foundation.org, Ray Huang <ray.huang@amd.com>,
Borislav Petkov <bp@suse.de>,
ken.xue@amd.com, vw@iommu.org
Subject: Re: [PATCH 5/6] iommu/amd: Add support for non-pci devices
Date: Fri, 8 Jan 2016 13:18:56 +0100 [thread overview]
Message-ID: <20160108121855.GU18805@8bytes.org> (raw)
In-Reply-To: <CAKT61h9retMxx8JiWEHYRVkX7ROXVvsYDJ3WZDoL17YhdjJdBA@mail.gmail.com>
On Fri, Jan 08, 2016 at 11:15:37AM +0800, Wan ZongShun wrote:
> Please see the following function, since I judge this
> 'get_acpihid_device_id(dev, NULL) < 0' in the front of
> 'get_device_id', so your concern should not exist. I have already
> filtered the negative situation in check_device firstly, do you think
> it is ok?
>
>
> static bool check_device(struct device *dev)
> {
> u16 devid;
> ......
>
> /* No PCI device */
> if (!dev_is_pci(dev) && (get_acpihid_device_id(dev, NULL) < 0))
> return false;
>
> devid = get_device_id(dev);
That is true for this case, but the other call-sites of get_device_id()
still have to care about a potential negative return value, right?
Joerg
next prev parent reply other threads:[~2016-01-08 12:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 10:07 [PATCH 0/6] iommu/amd: enable ACPI hardware ID device support Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-05 10:07 ` [PATCH 1/6] iommu/amd: Modify ivhd_header structure to support type 11h and 40h Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-05 10:07 ` [PATCH 2/6] iommu/amd: Use the most comprehensive IVHD type that the driver can support Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-05 10:07 ` [PATCH 3/6] iommu/amd: Add new map for storing IVHD dev entry type HID Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-05 10:07 ` [PATCH 4/6] iommu/amd: Introduces ivrs_acpihid kernel parameter Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-05 10:07 ` [PATCH 5/6] iommu/amd: Add support for non-pci devices Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-07 12:04 ` Joerg Roedel
2016-01-07 12:04 ` Joerg Roedel
2016-01-08 3:15 ` Wan ZongShun
2016-01-08 3:15 ` Wan ZongShun
2016-01-08 12:18 ` Joerg Roedel [this message]
2016-01-08 14:52 ` Wan Zongshun
2016-01-08 14:52 ` Wan Zongshun
2016-01-08 17:01 ` Joerg Roedel
2016-01-08 17:01 ` Joerg Roedel
2016-01-09 9:47 ` Wan Zongshun
2016-01-20 12:00 ` Joerg Roedel
2016-01-05 10:07 ` [PATCH 6/6] iommu/amd: Manage iommu_group " Wan Zongshun
2016-01-05 10:07 ` Wan Zongshun
2016-01-07 12:06 ` Joerg Roedel
2016-01-07 12:06 ` Joerg Roedel
2016-01-08 1:44 ` Wan ZongShun
2016-01-05 15:40 ` [PATCH 0/6] iommu/amd: enable ACPI hardware ID device support Suravee Suthikulpanit
2016-01-05 15:40 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108121855.GU18805@8bytes.org \
--to=joro@8bytes.org \
--cc=bp@suse.de \
--cc=iommu@lists.linux-foundation.org \
--cc=ken.xue@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcuos.com@gmail.com \
--cc=ray.huang@amd.com \
--cc=vincent.wan@amd.com \
--cc=vw@iommu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.