* [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs
@ 2016-01-09 11:23 nimisolo
2016-01-09 16:42 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: nimisolo @ 2016-01-09 11:23 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai
Cc: linux-kernel, nimisolo
Maybe it's better to set rdp->core_needs_qs with true/false
Signed-off-by: nimisolo <nimisolo@gmail.com>
---
kernel/rcu/tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index f07343b..0c0d09d 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
if ((rnp->qsmask & mask) == 0) {
raw_spin_unlock_irqrestore(&rnp->lock, flags);
} else {
- rdp->core_needs_qs = 0;
+ rdp->core_needs_qs = false;
/*
* This GP can't end until cpu checks in, so all of our
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs
2016-01-09 11:23 [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs nimisolo
@ 2016-01-09 16:42 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2016-01-09 16:42 UTC (permalink / raw)
To: nimisolo; +Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, linux-kernel
On Sat, Jan 09, 2016 at 06:23:04AM -0500, nimisolo wrote:
> Maybe it's better to set rdp->core_needs_qs with true/false
>
> Signed-off-by: nimisolo <nimisolo@gmail.com>
Good catch, but someone beat you by about a month.
To check for future changes, please see branch rcu/dev of:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
Thanx, Paul
> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index f07343b..0c0d09d 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
> if ((rnp->qsmask & mask) == 0) {
> raw_spin_unlock_irqrestore(&rnp->lock, flags);
> } else {
> - rdp->core_needs_qs = 0;
> + rdp->core_needs_qs = false;
>
> /*
> * This GP can't end until cpu checks in, so all of our
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-09 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-09 11:23 [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs nimisolo
2016-01-09 16:42 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.