From: Lee Jones <lee.jones@linaro.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
Date: Mon, 11 Jan 2016 05:49:08 +0000 [thread overview]
Message-ID: <20160111054908.GE3331@x1> (raw)
In-Reply-To: <1452218729-11357-3-git-send-email-wenyou.yang@atmel.com>
On Fri, 08 Jan 2016, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
> - Regulator
> - Charger
Is this really an MFD? What special handling does it require?
> This patch adds documentation for ACT8945A DT bindings.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Documentation/devicetree/bindings/mfd/act8945a.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> + mfd: act8945a@5b {
"mfd" is too generic to be a label.
Why do you need a label in any case?
> + compatible = "active-semi,act8945a";
> + reg = <0x5b>;
> + status = "okay";
> + };
This doesn't look much like an MFD to me.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
Date: Mon, 11 Jan 2016 05:49:08 +0000 [thread overview]
Message-ID: <20160111054908.GE3331@x1> (raw)
In-Reply-To: <1452218729-11357-3-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
On Fri, 08 Jan 2016, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
> - Regulator
> - Charger
Is this really an MFD? What special handling does it require?
> This patch adds documentation for ACT8945A DT bindings.
>
> Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
>
> Documentation/devicetree/bindings/mfd/act8945a.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> + mfd: act8945a@5b {
"mfd" is too generic to be a label.
Why do you need a label in any case?
> + compatible = "active-semi,act8945a";
> + reg = <0x5b>;
> + status = "okay";
> + };
This doesn't look much like an MFD to me.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-11 5:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 2:05 [PATCH 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Wenyou Yang
2016-01-08 2:05 ` Wenyou Yang
2016-01-08 2:05 ` [PATCH 1/2] " Wenyou Yang
2016-01-08 2:05 ` Wenyou Yang
2016-01-11 5:49 ` Lee Jones
2016-01-12 7:40 ` Yang, Wenyou
2016-03-07 23:54 ` kbuild test robot
2016-03-07 23:54 ` kbuild test robot
2016-03-07 23:54 ` [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-03-07 23:54 ` kbuild test robot
2016-03-08 1:53 ` Yang, Wenyou
2016-03-08 4:50 ` Lee Jones
2016-03-08 4:50 ` Lee Jones
2016-01-08 2:05 ` [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
2016-01-08 2:05 ` Wenyou Yang
2016-01-09 15:38 ` Rob Herring
2016-01-12 8:04 ` Yang, Wenyou
2016-01-12 8:04 ` Yang, Wenyou
2016-01-11 5:49 ` Lee Jones [this message]
2016-01-11 5:49 ` Lee Jones
2016-01-12 7:43 ` Yang, Wenyou
2016-01-12 7:43 ` Yang, Wenyou
2016-01-12 8:53 ` Lee Jones
2016-01-12 8:53 ` Lee Jones
2016-03-08 3:04 ` kbuild test robot
2016-03-08 3:04 ` kbuild test robot
2016-03-08 7:57 ` Yang, Wenyou
2016-03-08 7:57 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111054908.GE3331@x1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.