* [PATCH] ide: constify ide_dma_ops structures
@ 2015-11-15 20:36 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-11-15 20:36 UTC (permalink / raw)
To: David S. Miller; +Cc: kernel-janitors, linux-ide, linux-kernel
The ide_dma_ops structures are never modified, so declare these as const,
as is already done for the others.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/ide/it821x.c | 2 +-
drivers/ide/trm290.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c
index f01ba46..04029d1 100644
--- a/drivers/ide/it821x.c
+++ b/drivers/ide/it821x.c
@@ -508,7 +508,7 @@ static void it821x_quirkproc(ide_drive_t *drive)
}
-static struct ide_dma_ops it821x_pass_through_dma_ops = {
+static const struct ide_dma_ops it821x_pass_through_dma_ops = {
.dma_host_set = ide_dma_host_set,
.dma_setup = ide_dma_setup,
.dma_start = it821x_dma_start,
diff --git a/drivers/ide/trm290.c b/drivers/ide/trm290.c
index 0069f6c..d550b37 100644
--- a/drivers/ide/trm290.c
+++ b/drivers/ide/trm290.c
@@ -314,7 +314,7 @@ static const struct ide_tp_ops trm290_tp_ops = {
.output_data = ide_output_data,
};
-static struct ide_dma_ops trm290_dma_ops = {
+static const struct ide_dma_ops trm290_dma_ops = {
.dma_host_set = trm290_dma_host_set,
.dma_setup = trm290_dma_setup,
.dma_start = trm290_dma_start,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ide: constify ide_dma_ops structures
@ 2015-11-15 20:36 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-11-15 20:36 UTC (permalink / raw)
To: David S. Miller; +Cc: kernel-janitors, linux-ide, linux-kernel
The ide_dma_ops structures are never modified, so declare these as const,
as is already done for the others.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/ide/it821x.c | 2 +-
drivers/ide/trm290.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c
index f01ba46..04029d1 100644
--- a/drivers/ide/it821x.c
+++ b/drivers/ide/it821x.c
@@ -508,7 +508,7 @@ static void it821x_quirkproc(ide_drive_t *drive)
}
-static struct ide_dma_ops it821x_pass_through_dma_ops = {
+static const struct ide_dma_ops it821x_pass_through_dma_ops = {
.dma_host_set = ide_dma_host_set,
.dma_setup = ide_dma_setup,
.dma_start = it821x_dma_start,
diff --git a/drivers/ide/trm290.c b/drivers/ide/trm290.c
index 0069f6c..d550b37 100644
--- a/drivers/ide/trm290.c
+++ b/drivers/ide/trm290.c
@@ -314,7 +314,7 @@ static const struct ide_tp_ops trm290_tp_ops = {
.output_data = ide_output_data,
};
-static struct ide_dma_ops trm290_dma_ops = {
+static const struct ide_dma_ops trm290_dma_ops = {
.dma_host_set = trm290_dma_host_set,
.dma_setup = trm290_dma_setup,
.dma_start = trm290_dma_start,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ide: constify ide_dma_ops structures
2015-11-15 20:36 ` Julia Lawall
@ 2016-01-18 19:12 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-18 19:12 UTC (permalink / raw)
To: Julia.Lawall; +Cc: kernel-janitors, linux-ide, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 15 Nov 2015 21:36:30 +0100
> The ide_dma_ops structures are never modified, so declare these as const,
> as is already done for the others.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ide: constify ide_dma_ops structures
@ 2016-01-18 19:12 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-18 19:12 UTC (permalink / raw)
To: Julia.Lawall; +Cc: kernel-janitors, linux-ide, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 15 Nov 2015 21:36:30 +0100
> The ide_dma_ops structures are never modified, so declare these as const,
> as is already done for the others.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-18 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-15 20:36 [PATCH] ide: constify ide_dma_ops structures Julia Lawall
2015-11-15 20:36 ` Julia Lawall
2016-01-18 19:12 ` David Miller
2016-01-18 19:12 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.