* [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
@ 2016-01-19 15:15 Shobhit Kumar
2016-01-19 15:30 ` Kumar, Shobhit
2016-01-19 15:49 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Shobhit Kumar @ 2016-01-19 15:15 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Shobhit Kumar, bloften80
INTEL_SOC_PMIC is loading later than I915 failing the gpiod_get and
pwm_get calls in i915. Add a retry to give time for the INTEL_SOC_PMIC
to load. This was fine till now but broke in latest kernel. Maybe load
time for the INTEL_SOC_PMIC has increased.
Since the lookup tables for GPIO (panel enable) and PWM both are
exported by same intel_soc_pmic driver, just retrying for the driver to
load in intel_dsi_init is sufficient. By the time we come to
setup_backlight, pwm would have been exported as well.
Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_dsi.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 91cef35..e309ef6 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -1192,10 +1192,14 @@ void intel_dsi_init(struct drm_device *dev)
* Panel control.
*/
if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
+ int retry = 4;
+ do {
intel_dsi->gpio_panel =
gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
+ msleep(50);
+ } while (IS_ERR(intel_dsi->gpio_panel) && --retry);
- if (IS_ERR(intel_dsi->gpio_panel)) {
+ if (!retry) {
DRM_ERROR("Failed to own gpio for panel control\n");
intel_dsi->gpio_panel = NULL;
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
2016-01-19 15:15 [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init Shobhit Kumar
@ 2016-01-19 15:30 ` Kumar, Shobhit
2016-01-19 20:20 ` Daniel Vetter
2016-01-19 15:49 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Kumar, Shobhit @ 2016-01-19 15:30 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Daniel Vetter, bloften80
On 01/19/2016 08:45 PM, Shobhit Kumar wrote:
> INTEL_SOC_PMIC is loading later than I915 failing the gpiod_get and
> pwm_get calls in i915. Add a retry to give time for the INTEL_SOC_PMIC
> to load. This was fine till now but broke in latest kernel. Maybe load
> time for the INTEL_SOC_PMIC has increased.
>
> Since the lookup tables for GPIO (panel enable) and PWM both are
> exported by same intel_soc_pmic driver, just retrying for the driver to
> load in intel_dsi_init is sufficient. By the time we come to
> setup_backlight, pwm would have been exported as well.
Maybe we should play with initcalls here but I was not sure how it will
impact if I change it for PMIC driver. IIRC, this discussion came up
from Daniel at the time of original patches also but somehow did not
close decidedly and has come back as a regression.
Regards
Shobhit
>
> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 91cef35..e309ef6 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -1192,10 +1192,14 @@ void intel_dsi_init(struct drm_device *dev)
> * Panel control.
> */
> if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
> + int retry = 4;
> + do {
> intel_dsi->gpio_panel =
> gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
> + msleep(50);
> + } while (IS_ERR(intel_dsi->gpio_panel) && --retry);
>
> - if (IS_ERR(intel_dsi->gpio_panel)) {
> + if (!retry) {
> DRM_ERROR("Failed to own gpio for panel control\n");
> intel_dsi->gpio_panel = NULL;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
2016-01-19 15:15 [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init Shobhit Kumar
2016-01-19 15:30 ` Kumar, Shobhit
@ 2016-01-19 15:49 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2016-01-19 15:49 UTC (permalink / raw)
To: Shobhit Kumar; +Cc: intel-gfx
== Summary ==
Built on 20c388faff9d8c41ab27e825c685526561b892a2 drm-intel-nightly: 2016y-01m-19d-13h-31m-46s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
dmesg-warn -> PASS (skl-i5k-2) UNSTABLE
bdw-nuci7 total:140 pass:131 dwarn:0 dfail:0 fail:0 skip:9
bsw-nuc-2 total:143 pass:117 dwarn:2 dfail:0 fail:0 skip:24
byt-nuc total:143 pass:125 dwarn:3 dfail:0 fail:0 skip:15
hsw-brixbox total:143 pass:136 dwarn:0 dfail:0 fail:0 skip:7
hsw-gt2 total:143 pass:139 dwarn:0 dfail:0 fail:0 skip:4
ilk-hp8440p total:143 pass:102 dwarn:3 dfail:0 fail:0 skip:38
skl-i5k-2 total:143 pass:134 dwarn:1 dfail:0 fail:0 skip:8
snb-dellxps total:143 pass:124 dwarn:5 dfail:0 fail:0 skip:14
snb-x220t total:143 pass:124 dwarn:5 dfail:0 fail:1 skip:13
Results at /archive/results/CI_IGT_test/Patchwork_1222/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
2016-01-19 15:30 ` Kumar, Shobhit
@ 2016-01-19 20:20 ` Daniel Vetter
2016-01-20 8:38 ` Kumar, Shobhit
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2016-01-19 20:20 UTC (permalink / raw)
To: Kumar, Shobhit; +Cc: jani.nikula, Daniel Vetter, intel-gfx, bloften80
On Tue, Jan 19, 2016 at 09:00:40PM +0530, Kumar, Shobhit wrote:
> On 01/19/2016 08:45 PM, Shobhit Kumar wrote:
> >INTEL_SOC_PMIC is loading later than I915 failing the gpiod_get and
> >pwm_get calls in i915. Add a retry to give time for the INTEL_SOC_PMIC
> >to load. This was fine till now but broke in latest kernel. Maybe load
> >time for the INTEL_SOC_PMIC has increased.
> >
> >Since the lookup tables for GPIO (panel enable) and PWM both are
> >exported by same intel_soc_pmic driver, just retrying for the driver to
> >load in intel_dsi_init is sufficient. By the time we come to
> >setup_backlight, pwm would have been exported as well.
>
> Maybe we should play with initcalls here but I was not sure how it will
> impact if I change it for PMIC driver. IIRC, this discussion came up from
> Daniel at the time of original patches also but somehow did not close
> decidedly and has come back as a regression.
The correct way to handle this is to bail out with -EPROBE_DEFER. This is
how this is meant to be, no amount of random retrying will fix this
properly for such dynamic inter-module depencies.
And yes this is going to be a world-class test for our module load unwind
code.
-Daniel
> Regards
> Shobhit
>
> >
> >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >---
> > drivers/gpu/drm/i915/intel_dsi.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> >index 91cef35..e309ef6 100644
> >--- a/drivers/gpu/drm/i915/intel_dsi.c
> >+++ b/drivers/gpu/drm/i915/intel_dsi.c
> >@@ -1192,10 +1192,14 @@ void intel_dsi_init(struct drm_device *dev)
> > * Panel control.
> > */
> > if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
> >+ int retry = 4;
> >+ do {
> > intel_dsi->gpio_panel =
> > gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
> >+ msleep(50);
> >+ } while (IS_ERR(intel_dsi->gpio_panel) && --retry);
> >
> >- if (IS_ERR(intel_dsi->gpio_panel)) {
> >+ if (!retry) {
> > DRM_ERROR("Failed to own gpio for panel control\n");
> > intel_dsi->gpio_panel = NULL;
> > }
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
2016-01-19 20:20 ` Daniel Vetter
@ 2016-01-20 8:38 ` Kumar, Shobhit
2016-01-20 9:01 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Kumar, Shobhit @ 2016-01-20 8:38 UTC (permalink / raw)
To: Daniel Vetter; +Cc: jani.nikula, Daniel Vetter, intel-gfx, bloften80
On 01/20/2016 01:50 AM, Daniel Vetter wrote:
> On Tue, Jan 19, 2016 at 09:00:40PM +0530, Kumar, Shobhit wrote:
>> On 01/19/2016 08:45 PM, Shobhit Kumar wrote:
>>> INTEL_SOC_PMIC is loading later than I915 failing the gpiod_get and
>>> pwm_get calls in i915. Add a retry to give time for the INTEL_SOC_PMIC
>>> to load. This was fine till now but broke in latest kernel. Maybe load
>>> time for the INTEL_SOC_PMIC has increased.
>>>
>>> Since the lookup tables for GPIO (panel enable) and PWM both are
>>> exported by same intel_soc_pmic driver, just retrying for the driver to
>>> load in intel_dsi_init is sufficient. By the time we come to
>>> setup_backlight, pwm would have been exported as well.
>>
>> Maybe we should play with initcalls here but I was not sure how it will
>> impact if I change it for PMIC driver. IIRC, this discussion came up from
>> Daniel at the time of original patches also but somehow did not close
>> decidedly and has come back as a regression.
>
> The correct way to handle this is to bail out with -EPROBE_DEFER. This is
> how this is meant to be, no amount of random retrying will fix this
> properly for such dynamic inter-module depencies.
Yeah, you are right, retries are working pretty randomly. I made a quick
changes all the way up to i915_driver_load returning -EPROBE_DEFER form
intel_setup_outputs and it seems to work.
>
> And yes this is going to be a world-class test for our module load unwind
> code.
Well it seems to be working :) Will have a cleaned up patch for review.
Also need to take care of this in the LPSS_PWM patches as well.
Regards
Shobhit
> -Daniel
>
>> Regards
>> Shobhit
>>
>>>
>>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_dsi.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
>>> index 91cef35..e309ef6 100644
>>> --- a/drivers/gpu/drm/i915/intel_dsi.c
>>> +++ b/drivers/gpu/drm/i915/intel_dsi.c
>>> @@ -1192,10 +1192,14 @@ void intel_dsi_init(struct drm_device *dev)
>>> * Panel control.
>>> */
>>> if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
>>> + int retry = 4;
>>> + do {
>>> intel_dsi->gpio_panel =
>>> gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);
>>> + msleep(50);
>>> + } while (IS_ERR(intel_dsi->gpio_panel) && --retry);
>>>
>>> - if (IS_ERR(intel_dsi->gpio_panel)) {
>>> + if (!retry) {
>>> DRM_ERROR("Failed to own gpio for panel control\n");
>>> intel_dsi->gpio_panel = NULL;
>>> }
>>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init
2016-01-20 8:38 ` Kumar, Shobhit
@ 2016-01-20 9:01 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2016-01-20 9:01 UTC (permalink / raw)
To: Kumar, Shobhit; +Cc: jani.nikula, Daniel Vetter, intel-gfx, bloften80
On Wed, Jan 20, 2016 at 02:08:06PM +0530, Kumar, Shobhit wrote:
>
> On 01/20/2016 01:50 AM, Daniel Vetter wrote:
> >On Tue, Jan 19, 2016 at 09:00:40PM +0530, Kumar, Shobhit wrote:
> >>On 01/19/2016 08:45 PM, Shobhit Kumar wrote:
> >>>INTEL_SOC_PMIC is loading later than I915 failing the gpiod_get and
> >>>pwm_get calls in i915. Add a retry to give time for the INTEL_SOC_PMIC
> >>>to load. This was fine till now but broke in latest kernel. Maybe load
> >>>time for the INTEL_SOC_PMIC has increased.
> >>>
> >>>Since the lookup tables for GPIO (panel enable) and PWM both are
> >>>exported by same intel_soc_pmic driver, just retrying for the driver to
> >>>load in intel_dsi_init is sufficient. By the time we come to
> >>>setup_backlight, pwm would have been exported as well.
> >>
> >>Maybe we should play with initcalls here but I was not sure how it will
> >>impact if I change it for PMIC driver. IIRC, this discussion came up from
> >>Daniel at the time of original patches also but somehow did not close
> >>decidedly and has come back as a regression.
> >
> >The correct way to handle this is to bail out with -EPROBE_DEFER. This is
> >how this is meant to be, no amount of random retrying will fix this
> >properly for such dynamic inter-module depencies.
>
> Yeah, you are right, retries are working pretty randomly. I made a quick
> changes all the way up to i915_driver_load returning -EPROBE_DEFER form
> intel_setup_outputs and it seems to work.
>
> >
> >And yes this is going to be a world-class test for our module load unwind
> >code.
>
> Well it seems to be working :) Will have a cleaned up patch for review. Also
> need to take care of this in the LPSS_PWM patches as well.
You're extremely lucky then I'd say. Let's see whether CI agrees and then
merge this ;-)
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-20 9:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-19 15:15 [PATCH] drm/i915: Retry few time if gpiod_get fails during intel_dsi_init Shobhit Kumar
2016-01-19 15:30 ` Kumar, Shobhit
2016-01-19 20:20 ` Daniel Vetter
2016-01-20 8:38 ` Kumar, Shobhit
2016-01-20 9:01 ` Daniel Vetter
2016-01-19 15:49 ` ✓ Fi.CI.BAT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.