From: Tony Lindgren <tony@atomide.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Richard Woodruff <r-woodruff2@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Kees Cook <keescook@chromium.org>, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org,
Nishanth Menon <menon.nishanth@gmail.com>,
Laura Abbott <labbott@redhat.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] ARM: OMAP2+: Fix l2dis_3630 for rodata
Date: Tue, 19 Jan 2016 10:40:46 -0800 [thread overview]
Message-ID: <20160119184046.GD19432@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1601191305370.7882@knanqh.ubzr>
* Nicolas Pitre <nicolas.pitre@linaro.org> [160119 10:10]:
> On Tue, 19 Jan 2016, Tony Lindgren wrote:
> > --- a/arch/arm/mach-omap2/sleep34xx.S
> > +++ b/arch/arm/mach-omap2/sleep34xx.S
> > @@ -86,7 +86,9 @@ ENTRY(enable_omap3630_toggle_l2_on_restore)
> > stmfd sp!, {lr} @ save registers on stack
> > /* Setup so that we will disable and enable l2 */
> > mov r1, #0x1
> > - adrl r2, l2dis_3630 @ may be too distant for plain adr
> > + adrl r3, l2dis_3630_offset @ may be too distant for plain adr
> > + ldr r2, [r3]
> > + add r2, r2, r3
> > str r1, [r2]
>
> You could combine the add with the following str:
OK.
> str r1, [r2, r3]
>
> > ldmfd sp!, {pc} @ restore regs and return
> > ENDPROC(enable_omap3630_toggle_l2_on_restore)
> > @@ -415,7 +417,9 @@ ENTRY(omap3_restore)
> > cmp r2, #0x0 @ Check if target power state was OFF or RET
> > bne logic_l1_restore
> >
> > - ldr r0, l2dis_3630
> > + adr r1, l2dis_3630_offset
> > + ldr r0, [r1]
> > + add r0, r0, r1
> > cmp r0, #0x1 @ should we disable L2 on 3630?
>
> This looks wrong. You're testing the first bit of the address for
> l2dis_3630 rather than its content.
Ugh yup a ldr missing missing there. Will check the whole series
and repost. Thanks for checking!
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: OMAP2+: Fix l2dis_3630 for rodata
Date: Tue, 19 Jan 2016 10:40:46 -0800 [thread overview]
Message-ID: <20160119184046.GD19432@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1601191305370.7882@knanqh.ubzr>
* Nicolas Pitre <nicolas.pitre@linaro.org> [160119 10:10]:
> On Tue, 19 Jan 2016, Tony Lindgren wrote:
> > --- a/arch/arm/mach-omap2/sleep34xx.S
> > +++ b/arch/arm/mach-omap2/sleep34xx.S
> > @@ -86,7 +86,9 @@ ENTRY(enable_omap3630_toggle_l2_on_restore)
> > stmfd sp!, {lr} @ save registers on stack
> > /* Setup so that we will disable and enable l2 */
> > mov r1, #0x1
> > - adrl r2, l2dis_3630 @ may be too distant for plain adr
> > + adrl r3, l2dis_3630_offset @ may be too distant for plain adr
> > + ldr r2, [r3]
> > + add r2, r2, r3
> > str r1, [r2]
>
> You could combine the add with the following str:
OK.
> str r1, [r2, r3]
>
> > ldmfd sp!, {pc} @ restore regs and return
> > ENDPROC(enable_omap3630_toggle_l2_on_restore)
> > @@ -415,7 +417,9 @@ ENTRY(omap3_restore)
> > cmp r2, #0x0 @ Check if target power state was OFF or RET
> > bne logic_l1_restore
> >
> > - ldr r0, l2dis_3630
> > + adr r1, l2dis_3630_offset
> > + ldr r0, [r1]
> > + add r0, r0, r1
> > cmp r0, #0x1 @ should we disable L2 on 3630?
>
> This looks wrong. You're testing the first bit of the address for
> l2dis_3630 rather than its content.
Ugh yup a ldr missing missing there. Will check the whole series
and repost. Thanks for checking!
Regards,
Tony
next prev parent reply other threads:[~2016-01-19 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 17:48 [PATCH 0/5] omap assembly fixes for CONFIG_DEBUG_RODATA Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 17:48 ` [PATCH 1/5] ARM: OMAP2+: Fix wait_dll_lock_timed for rodata Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 17:48 ` [PATCH 2/5] ARM: OMAP2+: Fix l2dis_3630 " Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 18:10 ` Nicolas Pitre
2016-01-19 18:10 ` Nicolas Pitre
2016-01-19 18:40 ` Tony Lindgren [this message]
2016-01-19 18:40 ` Tony Lindgren
2016-01-19 17:48 ` [PATCH 3/5] ARM: OMAP2+: Fix save_secure_ram_context " Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 18:45 ` Sergei Shtylyov
2016-01-19 18:45 ` Sergei Shtylyov
2016-01-19 21:57 ` Tony Lindgren
2016-01-19 21:57 ` Tony Lindgren
2016-01-19 17:48 ` [PATCH 4/5] ARM: OMAP2+: Fix l2_inv_api_params " Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 17:48 ` [PATCH 5/5] ARM: OMAP2+: Fix ppa_zero_params and ppa_por_params " Tony Lindgren
2016-01-19 17:48 ` Tony Lindgren
2016-01-19 18:12 ` [PATCH 0/5] omap assembly fixes for CONFIG_DEBUG_RODATA Kees Cook
2016-01-19 18:12 ` Kees Cook
2016-01-21 19:12 [PATCH v2 " Tony Lindgren
2016-01-21 19:12 ` [PATCH 2/5] ARM: OMAP2+: Fix l2dis_3630 for rodata Tony Lindgren
2016-01-21 19:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119184046.GD19432@atomide.com \
--to=tony@atomide.com \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=menon.nishanth@gmail.com \
--cc=nicolas.pitre@linaro.org \
--cc=r-woodruff2@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.