[PATCH] ti-softhsmv2: Use target includes for zlib and openssl

[PATCH] ti-softhsmv2: Use target includes for zlib and openssl

[Paul Barker]

ti-softhsmv2 needs to look at the target include directories instead of the host
include directories for zlib and openssl header files.

Signed-off-by: Paul Barker <paul.barker@commagility.com>
---
 recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
index c1e1654..dd51309 100644
--- a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
+++ b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
@@ -21,7 +21,10 @@ S = "${WORKDIR}/git"
 CFLAGS += " -mno-unaligned-access"
 CPPFLAGS += " -mno-unaligned-access"
 
-EXTRA_OECONF += "--with-zlib=${STAGING_DIR_HOST}/usr"
+EXTRA_OECONF += " \
+    --with-zlib=${STAGING_DIR_TARGET}/usr \
+    --with-openssl=${STAGING_DIR_TARGET}/usr \
+    "
 
 INITSCRIPT_NAME = "softhsm-daemon.sh"
 INITSCRIPT_PARAMS = "defaults 10"
-- 
1.9.1

Re: [PATCH] ti-softhsmv2: Use target includes for zlib and openssl

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]


> On Jan 19, 2016, at 7:51 AM, Paul Barker <paul.barker@commagility.com> wrote:
> 
> ti-softhsmv2 needs to look at the target include directories instead of the host
> include directories for zlib and openssl header files.
> 
> Signed-off-by: Paul Barker <paul.barker@commagility.com>
> ---
> recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> index c1e1654..dd51309 100644
> --- a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> +++ b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> @@ -21,7 +21,10 @@ S = "${WORKDIR}/git"
> CFLAGS += " -mno-unaligned-access"
> CPPFLAGS += " -mno-unaligned-access"
> 
> -EXTRA_OECONF += "--with-zlib=${STAGING_DIR_HOST}/usr"
> +EXTRA_OECONF += " \
> +    --with-zlib=${STAGING_DIR_TARGET}/usr \
> +    --with-openssl=${STAGING_DIR_TARGET}/usr \
> +    “

you know there is STAGING_EXECPREFIXDIR, may be better suited here ?
> 
> INITSCRIPT_NAME = "softhsm-daemon.sh"
> INITSCRIPT_PARAMS = "defaults 10"
> --
> 1.9.1
> 
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] ti-softhsmv2: Use target includes for zlib and openssl

[Denys Dmytriyenko]

On Tue, Jan 19, 2016 at 11:01:37AM -0800, Khem Raj wrote:
> 
> > On Jan 19, 2016, at 7:51 AM, Paul Barker <paul.barker@commagility.com> wrote:
> > 
> > ti-softhsmv2 needs to look at the target include directories instead of the host
> > include directories for zlib and openssl header files.
> > 
> > Signed-off-by: Paul Barker <paul.barker@commagility.com>
> > ---
> > recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> > index c1e1654..dd51309 100644
> > --- a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> > +++ b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> > @@ -21,7 +21,10 @@ S = "${WORKDIR}/git"
> > CFLAGS += " -mno-unaligned-access"
> > CPPFLAGS += " -mno-unaligned-access"
> > 
> > -EXTRA_OECONF += "--with-zlib=${STAGING_DIR_HOST}/usr"
> > +EXTRA_OECONF += " \
> > +    --with-zlib=${STAGING_DIR_TARGET}/usr \
> > +    --with-openssl=${STAGING_DIR_TARGET}/usr \
> > +    “
> 
> you know there is STAGING_EXECPREFIXDIR, may be better suited here ?

From bitbake.conf:

STAGING_EXECPREFIXDIR = "${STAGING_DIR_HOST}${exec_prefix}"


> > INITSCRIPT_NAME = "softhsm-daemon.sh"
> > INITSCRIPT_PARAMS = "defaults 10"
> > --
> > 1.9.1
> > 
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> 



> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti

Re: [PATCH] ti-softhsmv2: Use target includes for zlib and openssl

[Paul Barker]

On Tue, 19 Jan 2016 14:13:01 -0500
Denys Dmytriyenko <denys@ti.com> wrote:

> On Tue, Jan 19, 2016 at 11:01:37AM -0800, Khem Raj wrote:
> > 
> > > On Jan 19, 2016, at 7:51 AM, Paul Barker
> > > <paul.barker@commagility.com> wrote:
> > > 
> > > ti-softhsmv2 needs to look at the target include directories
> > > instead of the host include directories for zlib and openssl
> > > header files.
> > > 
> > > Signed-off-by: Paul Barker <paul.barker@commagility.com>
> > > ---
> > > recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb
> > > b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb index
> > > c1e1654..dd51309 100644 ---
> > > a/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb +++
> > > b/recipes-ti/ti-softhsmv2/ti-softhsmv2_git.bb @@ -21,7 +21,10 @@
> > > S = "${WORKDIR}/git" CFLAGS += " -mno-unaligned-access"
> > > CPPFLAGS += " -mno-unaligned-access"
> > > 
> > > -EXTRA_OECONF += "--with-zlib=${STAGING_DIR_HOST}/usr"
> > > +EXTRA_OECONF += " \
> > > +    --with-zlib=${STAGING_DIR_TARGET}/usr \
> > > +    --with-openssl=${STAGING_DIR_TARGET}/usr \
> > > +    “
> > 
> > you know there is STAGING_EXECPREFIXDIR, may be better suited here ?
> 
> From bitbake.conf:
> 
> STAGING_EXECPREFIXDIR = "${STAGING_DIR_HOST}${exec_prefix}"
> 

I've looked at bitbake.conf more clearly now:

STAGING_DIR_HOST =   "${STAGING_DIR}/${MACHINE}"
STAGING_DIR_TARGET = "${STAGING_DIR}/${MACHINE}"

So it actually doesn't matter which of these is used.

I'll send a V2 using STAGING_EXECPREFIXDIR for both zlib and openssl.

Thanks,

-- 
Paul Barker
CommAgility Ltd