All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package
@ 2016-01-20 10:35 Mamatha Inamdar
  2016-01-20 10:39 ` [Buildroot] [PATCH 2/2] " Mamatha Inamdar
  2016-01-20 11:09 ` [Buildroot] [PATCH 1/2 V6] Adds " Thomas Petazzoni
  0 siblings, 2 replies; 6+ messages in thread
From: Mamatha Inamdar @ 2016-01-20 10:35 UTC (permalink / raw)
  To: buildroot

Add support for building NVME utility - a utility for interacting with
standard NVM Express (optimized PCI Express SSD interface) devices.

Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
---
 package/nvme/0001-NVME-Makefile-cleanup.patch |   25 +++++++++++++++++++++++++
 package/nvme/nvme.hash                        |    2 ++
 package/nvme/nvme.mk                          |   22 ++++++++++++++++++++++
 3 files changed, 49 insertions(+)
 create mode 100644 package/nvme/0001-NVME-Makefile-cleanup.patch
 create mode 100644 package/nvme/nvme.hash
 create mode 100755 package/nvme/nvme.mk

diff --git a/package/nvme/0001-NVME-Makefile-cleanup.patch b/package/nvme/0001-NVME-Makefile-cleanup.patch
new file mode 100644
index 0000000..74beac9
--- /dev/null
+++ b/package/nvme/0001-NVME-Makefile-cleanup.patch
@@ -0,0 +1,25 @@
+From 985a18605f8decd766370a7d9873c77c16b9253c Mon Sep 17 00:00:00 2001
+From: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
+Date: Mon, 18 Jan 2016 12:40:00 +0530
+Subject: [PATCH V2] NVME Makefile update
+
+Makefile cleanup: remove -Werror flag in CFLAGS
+
+Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
+---
+ Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile b/Makefile
+index d0c0ce4..003928b 100644
+--- a/Makefile
++++ b/Makefile
+@@ -1,4 +1,4 @@
+-CFLAGS += -std=gnu99 -O2 -g -Wall -Werror
++CFLAGS += -std=gnu99 -O2 -g -Wall
+ CPPFLAGS += -I $(SRC) -D_GNU_SOURCE
+ NVME = nvme
+ INSTALL ?= install
+--
+1.9.3
+
diff --git a/package/nvme/nvme.hash b/package/nvme/nvme.hash
new file mode 100644
index 0000000..539a2b6
--- /dev/null
+++ b/package/nvme/nvme.hash
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  914319930a51372293c981562b165ae6af0de70f7da37e42da23940fe23aa387 nvme-v0.2.tar.gz
diff --git a/package/nvme/nvme.mk b/package/nvme/nvme.mk
new file mode 100755
index 0000000..f06ed47
--- /dev/null
+++ b/package/nvme/nvme.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# nvme
+#
+################################################################################
+
+NVME_VERSION = v0.2
+NVME_SITE = $(call github,linux-nvme,nvme-cli,$(NVME_VERSION))
+NVME_LICENSE = GPLv2+
+NVME_LICENSE_FILES = COPYING
+
+define NVME_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) \
+		LIBUDEV=1 -C $(@D)
+endef
+
+define NVME_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
+		PREFIX=/usr install-bin
+endef
+
+$(eval $(generic-package))

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/nvme: new package
  2016-01-20 10:35 [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package Mamatha Inamdar
@ 2016-01-20 10:39 ` Mamatha Inamdar
  2016-01-20 11:10   ` Baruch Siach
  2016-01-20 11:09 ` [Buildroot] [PATCH 1/2 V6] Adds " Thomas Petazzoni
  1 sibling, 1 reply; 6+ messages in thread
From: Mamatha Inamdar @ 2016-01-20 10:39 UTC (permalink / raw)
  To: buildroot

This patch is to add NVME Config file

Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
---
 package/Config.in      |    1 +
 package/nvme/Config.in |    6 ++++++
 2 files changed, 7 insertions(+)
 create mode 100644 package/nvme/Config.in

diff --git a/package/Config.in b/package/Config.in
index e0c2e2a..4d173d4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -380,6 +380,7 @@ endif
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
 	source "package/nvidia-tegra23/Config.in"
+	source "package/nvme/Config.in"
 	source "package/ofono/Config.in"
 	source "package/ola/Config.in"
 	source "package/on2-8170-modules/Config.in"
diff --git a/package/nvme/Config.in b/package/nvme/Config.in
new file mode 100644
index 0000000..8b5d37d
--- /dev/null
+++ b/package/nvme/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_NVME
+	bool "nvme"
+	help
+	  System utilities for IBM Power NVME devices
+
+	  https://github.com/linux-nvme/nvme-cli

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package
  2016-01-20 10:35 [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package Mamatha Inamdar
  2016-01-20 10:39 ` [Buildroot] [PATCH 2/2] " Mamatha Inamdar
@ 2016-01-20 11:09 ` Thomas Petazzoni
  2016-01-21  5:33   ` Mamatha Inamdar
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2016-01-20 11:09 UTC (permalink / raw)
  To: buildroot

Dear Mamatha Inamdar,

On Wed, 20 Jan 2016 16:05:48 +0530, Mamatha Inamdar wrote:
> Add support for building NVME utility - a utility for interacting with
> standard NVM Express (optimized PCI Express SSD interface) devices.
> 
> Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>

Once again, there should be a *single* patch adding the package. Please
merge your two patches into one.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/nvme: new package
  2016-01-20 10:39 ` [Buildroot] [PATCH 2/2] " Mamatha Inamdar
@ 2016-01-20 11:10   ` Baruch Siach
  2016-01-21  5:34     ` Mamatha Inamdar
  0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2016-01-20 11:10 UTC (permalink / raw)
  To: buildroot

Hi Mamatha,

On Wed, Jan 20, 2016 at 04:09:14PM +0530, Mamatha Inamdar wrote:
> This patch is to add NVME Config file

This should be part of the previous patch. That's what Thomas meant when he 
asked you to send a single patch. He only used a list to indicate what should 
change in this single patch compared to your previous submissions.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package
  2016-01-20 11:09 ` [Buildroot] [PATCH 1/2 V6] Adds " Thomas Petazzoni
@ 2016-01-21  5:33   ` Mamatha Inamdar
  0 siblings, 0 replies; 6+ messages in thread
From: Mamatha Inamdar @ 2016-01-21  5:33 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

Sorry...based on your two points I created the patch.... will send 
single patch now.

On 01/20/2016 04:39 PM, Thomas Petazzoni wrote:
> Dear Mamatha Inamdar,
>
> On Wed, 20 Jan 2016 16:05:48 +0530, Mamatha Inamdar wrote:
>> Add support for building NVME utility - a utility for interacting with
>> standard NVM Express (optimized PCI Express SSD interface) devices.
>>
>> Signed-off-by: Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
> Once again, there should be a *single* patch adding the package. Please
> merge your two patches into one.
>
> Best regards,
>
> Thomas

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/nvme: new package
  2016-01-20 11:10   ` Baruch Siach
@ 2016-01-21  5:34     ` Mamatha Inamdar
  0 siblings, 0 replies; 6+ messages in thread
From: Mamatha Inamdar @ 2016-01-21  5:34 UTC (permalink / raw)
  To: buildroot

Hi Baruch,

Thanks...Will send single patch

On 01/20/2016 04:40 PM, Baruch Siach wrote:
> Hi Mamatha,
>
> On Wed, Jan 20, 2016 at 04:09:14PM +0530, Mamatha Inamdar wrote:
>> This patch is to add NVME Config file
> This should be part of the previous patch. That's what Thomas meant when he
> asked you to send a single patch. He only used a list to indicate what should
> change in this single patch compared to your previous submissions.
>
> baruch
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-01-21  5:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-20 10:35 [Buildroot] [PATCH 1/2 V6] Adds package/nvme: new package Mamatha Inamdar
2016-01-20 10:39 ` [Buildroot] [PATCH 2/2] " Mamatha Inamdar
2016-01-20 11:10   ` Baruch Siach
2016-01-21  5:34     ` Mamatha Inamdar
2016-01-20 11:09 ` [Buildroot] [PATCH 1/2 V6] Adds " Thomas Petazzoni
2016-01-21  5:33   ` Mamatha Inamdar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.