* [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
@ 2016-01-20 10:59 Colin King
2016-01-20 12:56 ` Daniel Vetter
2016-01-20 12:56 ` Ville Syrjälä
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-01-20 10:59 UTC (permalink / raw)
To: Dave Airlie, dri-devel; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Duplicated const, only one is required. Also reformat line to ensure
it is less than 80 columns wide.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c895b6f..bb88e3d 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
};
static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
- const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
+ const struct drm_mode_fb_cmd2 *mode_cmd,
+ struct drm_gem_cma_object **obj,
unsigned int num_planes)
{
struct drm_fb_cma *fb_cma;
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
2016-01-20 10:59 [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Colin King
@ 2016-01-20 12:56 ` Daniel Vetter
2016-01-20 12:56 ` Ville Syrjälä
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-01-20 12:56 UTC (permalink / raw)
To: Colin King; +Cc: Dave Airlie, dri-devel, linux-kernel
On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Duplicated const, only one is required. Also reformat line to ensure
> it is less than 80 columns wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd,
> + struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc
2016-01-20 10:59 [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Colin King
2016-01-20 12:56 ` Daniel Vetter
@ 2016-01-20 12:56 ` Ville Syrjälä
1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2016-01-20 12:56 UTC (permalink / raw)
To: Colin King; +Cc: Dave Airlie, dri-devel, linux-kernel
On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Duplicated const, only one is required. Also reformat line to ensure
> it is less than 80 columns wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd,
> + struct drm_gem_cma_object **obj,
Seems to have been my mode_cmd constification that added the second
const by accident.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-20 12:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-20 10:59 [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Colin King
2016-01-20 12:56 ` Daniel Vetter
2016-01-20 12:56 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.