* [PATCH] net/irda: bfin_sir: remove duplicate defines
@ 2016-01-21 5:12 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2016-01-21 5:12 UTC (permalink / raw)
To: Samuel Ortiz, Steven Miao
Cc: linux-kernel, kernel-testers, netdev, adi-buildroot-devel,
Sudip Mukherjee
The defconfig build of blackfin is failing with the error:
arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined
drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition
arch/blackfin/include/asm/bfin_serial.h:382:0: warning: "get_lsr_cache" redefined
drivers/net/irda/bfin_sir.h:86:0: note: this is the location of the previous definition
arch/blackfin/include/asm/bfin_serial.h:383:0: warning: "put_lsr_cache" redefined
drivers/net/irda/bfin_sir.h:87:0: note: this is the location of the previous definition
port_membase, get_lsr_cache, put_lsr_cache are already defined in the
architecture files, no need to define them again in the driver.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/net/irda/bfin_sir.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/irda/bfin_sir.h b/drivers/net/irda/bfin_sir.h
index 29cbde8..d47cf14 100644
--- a/drivers/net/irda/bfin_sir.h
+++ b/drivers/net/irda/bfin_sir.h
@@ -82,9 +82,6 @@ struct bfin_sir_self {
#define DRIVER_NAME "bfin_sir"
-#define port_membase(port) (((struct bfin_sir_port *)(port))->membase)
-#define get_lsr_cache(port) (((struct bfin_sir_port *)(port))->lsr)
-#define put_lsr_cache(port, v) (((struct bfin_sir_port *)(port))->lsr = (v))
#include <asm/bfin_serial.h>
static const unsigned short per[][4] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net/irda: bfin_sir: remove duplicate defines
@ 2016-01-21 5:12 ` Sudip Mukherjee
0 siblings, 0 replies; 4+ messages in thread
From: Sudip Mukherjee @ 2016-01-21 5:12 UTC (permalink / raw)
To: Samuel Ortiz, Steven Miao
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
Sudip Mukherjee
The defconfig build of blackfin is failing with the error:
arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined
drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition
arch/blackfin/include/asm/bfin_serial.h:382:0: warning: "get_lsr_cache" redefined
drivers/net/irda/bfin_sir.h:86:0: note: this is the location of the previous definition
arch/blackfin/include/asm/bfin_serial.h:383:0: warning: "put_lsr_cache" redefined
drivers/net/irda/bfin_sir.h:87:0: note: this is the location of the previous definition
port_membase, get_lsr_cache, put_lsr_cache are already defined in the
architecture files, no need to define them again in the driver.
Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
---
drivers/net/irda/bfin_sir.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/irda/bfin_sir.h b/drivers/net/irda/bfin_sir.h
index 29cbde8..d47cf14 100644
--- a/drivers/net/irda/bfin_sir.h
+++ b/drivers/net/irda/bfin_sir.h
@@ -82,9 +82,6 @@ struct bfin_sir_self {
#define DRIVER_NAME "bfin_sir"
-#define port_membase(port) (((struct bfin_sir_port *)(port))->membase)
-#define get_lsr_cache(port) (((struct bfin_sir_port *)(port))->lsr)
-#define put_lsr_cache(port, v) (((struct bfin_sir_port *)(port))->lsr = (v))
#include <asm/bfin_serial.h>
static const unsigned short per[][4] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/irda: bfin_sir: remove duplicate defines
@ 2016-01-21 18:45 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-21 18:45 UTC (permalink / raw)
To: sudipm.mukherjee
Cc: samuel, realmz6, linux-kernel, kernel-testers, netdev,
adi-buildroot-devel
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Thu, 21 Jan 2016 10:42:31 +0530
> The defconfig build of blackfin is failing with the error:
>
> arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined
> drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition
> arch/blackfin/include/asm/bfin_serial.h:382:0: warning: "get_lsr_cache" redefined
> drivers/net/irda/bfin_sir.h:86:0: note: this is the location of the previous definition
> arch/blackfin/include/asm/bfin_serial.h:383:0: warning: "put_lsr_cache" redefined
> drivers/net/irda/bfin_sir.h:87:0: note: this is the location of the previous definition
>
> port_membase, get_lsr_cache, put_lsr_cache are already defined in the
> architecture files, no need to define them again in the driver.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/irda: bfin_sir: remove duplicate defines
@ 2016-01-21 18:45 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-21 18:45 UTC (permalink / raw)
To: sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w
Cc: samuel-jcdQHdrhKHMdnm+yROfE0A, realmz6-Re5JQEeQqe8AvxtiuMwx3w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-testers-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 21 Jan 2016 10:42:31 +0530
> The defconfig build of blackfin is failing with the error:
>
> arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined
> drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition
> arch/blackfin/include/asm/bfin_serial.h:382:0: warning: "get_lsr_cache" redefined
> drivers/net/irda/bfin_sir.h:86:0: note: this is the location of the previous definition
> arch/blackfin/include/asm/bfin_serial.h:383:0: warning: "put_lsr_cache" redefined
> drivers/net/irda/bfin_sir.h:87:0: note: this is the location of the previous definition
>
> port_membase, get_lsr_cache, put_lsr_cache are already defined in the
> architecture files, no need to define them again in the driver.
>
> Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-21 18:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-21 5:12 [PATCH] net/irda: bfin_sir: remove duplicate defines Sudip Mukherjee
2016-01-21 5:12 ` Sudip Mukherjee
2016-01-21 18:45 ` David Miller
2016-01-21 18:45 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.