[U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER

From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/2] usb: eth: add Realtek RTL8152B/RTL8153 DRIVER
Date: Thu, 21 Jan 2016 11:12:15 +0100	[thread overview]
Message-ID: <201601211112.15331.marex@denx.de> (raw)
In-Reply-To: <CANAwSgTFcy7R7XrAUvLN+7wcmxtxbgR4XDTV+G3L_dHnR3=eUg@mail.gmail.com>

On Thursday, January 21, 2016 at 09:55:59 AM, Anand Moon wrote:
> Hi Marek,
> 
> On 21 January 2016 at 02:04, Marek Vasut <marex@denx.de> wrote:
> > On Wednesday, January 20, 2016 at 09:10:07 PM, Anand Moon wrote:
> >> Hi Ted / Marek / Stephen,
> >> 
> >> On 20 January 2016 at 22:22, Stephen Warren <swarren@wwwdotorg.org> wrote:
> >> > On 01/19/2016 11:24 PM, Ted Chen wrote:
> >> >> This patch adds driver support for the Realtek RTL8152B/RTL8153 USB
> >> >> network adapters.
> >> > 
> >> > This looks fine to me, although I didn't take a detailed enough look
> >> > to actually give and an ack/reviewed-by.
> >> 
> >> What about the other patch: usb xhci Fix vendor command error if the
> >> request.patch
> > 
> > Please repost it , make sure to CC everyone . If there is agreement that
> > it fixes real issue, I'll pick it.
> > 
> >> After setting the usbether mac address my odroid xu4 board shop booting.
> >> even after reset of environment it dose not boot.
> >> ------------------------------------------------------------------------
> >> --- ------------------------------ U-Boot 2016.01-00406-g048c61d-dirty
> >> (Jan 21 2016 - 06:27:09 +1030) for ODROID-XU3
> >> 
> >> CPU:   Exynos5422 @ 800 MHz
> >> Model: Odroid XU3 based on EXYNOS5422
> >> Board: Odroid XU3 based on EXYNOS5422
> >> Type:  xu4
> >> DRAM:  2 GiB
> >> MMC:   EXYNOS DWMMC: 0, EXYNOS DWMMC: 1
> >> *** Warning - bad CRC, using default environment
> >> 
> >> In:    serial
> >> Out:   serial
> >> Err:   serial
> >> Net:   No ethernet found.
> >> Hit any key to stop autoboot:  0
> >> ODROID-XU3 #
> >> ODROID-XU3 #
> >> ODROID-XU3 #
> >> ODROID-XU3 # setenv usbethaddr 00:1e:06:31:06:b3
> >> ODROID-XU3 # saveenv
> > 
> > You ran saveenv, so usbethaddr is now in permanent storage. That's why
> > 'reset' won't help you.
> 
> But I need to set common mac address so that I will get single IP.
> I don't need random mac address.
> 
> Any way thanks for your input.

That was just a comment /wrt your observation that the board stops booting
and reset doesn't fix it ;-)

> >> Saving Environment to MMC...
> >> Writing to MMC(0)... done
> >> ODROID-XU3 # usb info
> >> USB is stopped. Please issue 'usb start' first.
> >> ODROID-XU3 # usb start
> >> starting USB...
> >> USB0:   USB EHCI 1.00
> >> USB1:   Register 2000140 NbrPorts 2
> >> Starting the controller
> >> USB XHCI 1.00
> >> USB2:   Register 2000140 NbrPorts 2
> >> Starting the controller
> >> USB XHCI 1.00
> >> scanning bus 0 for devices... 1 USB Device(s) found
> >> scanning bus 1 for devices... Device not responding to set address.
> >> 
> >>       USB device not accepting new address (error=80000000)
> > 
> > This error looks suspicious.
> 
> I had another wireless mouse and USB to Ethernet adapter connected to the
> board may be it's not getting recognized at that moment.
> 
> Any way thanks for you input.

Looks like something might be afoot with the controller itself ?

> >> 2 USB Device(s) found
> >> scanning bus 2 for devices... 2 USB Device(s) found
> >> 
> >>        scanning usb for ethernet devices... 1 Ethernet Device(s) found
> > 
> > [...]
> 
> Well I have tested the TFTP booting functionality of the board and it
> was success.
> Fell free to add my tested by for this version.
> 
> Tested-by: Anand Moon <linux.amoon@gmail.com>

Excellent, thanks!