From: "Michał Kępień" <kernel@kempniu.pl> To: "Pali Rohár" <pali.rohar@gmail.com> Cc: Matthew Garrett <mjg59@srcf.ucam.org>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>, Darren Hart <dvhart@infradead.org> Subject: Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Date: Thu, 21 Jan 2016 15:56:12 +0100 [thread overview] Message-ID: <20160121145612.GA4684@eudyptula.hq.kempniu.pl> (raw) In-Reply-To: <20160121134425.GG7192@pali> > > > Michał, can you prepare new (v3) version of this patch? Now required > > > acpi video changes are included and so dell-wmi changes should go to... > > > To finally fix this keypress bug on Dell Vostro V131 machine. > > > > I keep this on my to-do list, but the updated patch will depend on the > > final version of the SMBIOS API rework, so I guess there is little point > > in posting it now as that API is subject to change. But rest assured > > that as soon as the final version of the API rework series (which I have > > yet to prepare, of course) gets applied by Darren, I will post a v3 of > > this patch - after all, it is the very reason I am working on the API > > rework. > > There is still need to patch dell-wmi.c? And this change does not depend > on another SMBIOS change (in dell-laptop), right? Well, back in December, you wrote [1]: > This patch is not enough for enabling 0xe025 key on that Vostro machine. > Some extra SMBIOS call is needed, without them ACPI will not send WMI > keypress event. > > (...) > > Maybe now it could make sense to unify Dell SMBIOS API in kernel and > move common functions to one place and let drivers to use just common > functions. According to older Dell ACPI WMI documentation in DMI is bit > which specify if BIOS support SMBIOS via WMI or not. > > At least I think this one patch should not be included into kernel until > there will be full support for 0xe025 key (adding that SMBIOS call). >From the above I understood that first you want to unify the Dell SMBIOS API used throughout the kernel (that's currently in progress), so that it can then be used in dell-wmi as well to perform the SMBIOS call needed on the Vostro V131. If you want me to just rework the patch so that it doesn't introduce a quirk structure, I recalled another reason to use it after all: there are other Dell laptops which require the special SMI for enabling WMI events, but report the Dell Instant Launch Hotkey using a different WMI event code [2]. So I'd say that two separate issues should be fixed using DMI matching: * whether the special SMBIOS call is required, * whether the 0x0e25 event should be translated into a keypress. A quirk structure looks like an elegant way to deal with this. Could you please advise how you would like me to proceed with this? [1] http://www.spinics.net/lists/platform-driver-x86/msg07845.html [2] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1205791/comments/12 -- Best regards, Michał Kępień
WARNING: multiple messages have this Message-ID (diff)
From: "Michał Kępień" <kernel@kempniu.pl> To: "Pali Rohár" <pali.rohar@gmail.com> Cc: Matthew Garrett <mjg59@srcf.ucam.org>, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>, Darren Hart <dvhart@infradead.org> Subject: Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Date: Thu, 21 Jan 2016 15:56:12 +0100 [thread overview] Message-ID: <20160121145612.GA4684@eudyptula.hq.kempniu.pl> (raw) In-Reply-To: <20160121134425.GG7192@pali> > > > Michał, can you prepare new (v3) version of this patch? Now required > > > acpi video changes are included and so dell-wmi changes should go to... > > > To finally fix this keypress bug on Dell Vostro V131 machine. > > > > I keep this on my to-do list, but the updated patch will depend on the > > final version of the SMBIOS API rework, so I guess there is little point > > in posting it now as that API is subject to change. But rest assured > > that as soon as the final version of the API rework series (which I have > > yet to prepare, of course) gets applied by Darren, I will post a v3 of > > this patch - after all, it is the very reason I am working on the API > > rework. > > There is still need to patch dell-wmi.c? And this change does not depend > on another SMBIOS change (in dell-laptop), right? Well, back in December, you wrote [1]: > This patch is not enough for enabling 0xe025 key on that Vostro machine. > Some extra SMBIOS call is needed, without them ACPI will not send WMI > keypress event. > > (...) > > Maybe now it could make sense to unify Dell SMBIOS API in kernel and > move common functions to one place and let drivers to use just common > functions. According to older Dell ACPI WMI documentation in DMI is bit > which specify if BIOS support SMBIOS via WMI or not. > > At least I think this one patch should not be included into kernel until > there will be full support for 0xe025 key (adding that SMBIOS call). From the above I understood that first you want to unify the Dell SMBIOS API used throughout the kernel (that's currently in progress), so that it can then be used in dell-wmi as well to perform the SMBIOS call needed on the Vostro V131. If you want me to just rework the patch so that it doesn't introduce a quirk structure, I recalled another reason to use it after all: there are other Dell laptops which require the special SMI for enabling WMI events, but report the Dell Instant Launch Hotkey using a different WMI event code [2]. So I'd say that two separate issues should be fixed using DMI matching: * whether the special SMBIOS call is required, * whether the 0x0e25 event should be translated into a keypress. A quirk structure looks like an elegant way to deal with this. Could you please advise how you would like me to proceed with this? [1] http://www.spinics.net/lists/platform-driver-x86/msg07845.html [2] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1205791/comments/12 -- Best regards, Michał Kępień
next prev parent reply other threads:[~2016-01-21 14:56 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-26 14:18 [PATCH] dell-wmi: add module param to control Dell Instant Launch hotkey processing Michał Kępień 2015-11-26 14:41 ` Pali Rohár 2015-11-26 14:55 ` Michał Kępień 2015-11-29 19:50 ` Pali Rohár 2015-11-30 14:14 ` Michał Kępień 2015-11-30 14:37 ` Pali Rohár 2015-11-30 14:54 ` Michał Kępień 2015-11-30 20:55 ` Darren Hart 2015-11-30 21:15 ` Darren Hart 2015-12-01 8:47 ` Michał Kępień 2015-12-01 19:51 ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień 2015-12-04 1:16 ` Darren Hart 2015-12-04 8:56 ` Pali Rohár 2015-12-04 13:27 ` Michał Kępień 2016-01-11 19:12 ` Darren Hart 2016-01-11 20:07 ` Pali Rohár 2016-01-21 9:04 ` Pali Rohár 2016-01-21 10:52 ` Michał Kępień 2016-01-21 13:44 ` Pali Rohár 2016-01-21 14:56 ` Michał Kępień [this message] 2016-01-21 14:56 ` Michał Kępień 2016-01-21 15:42 ` Pali Rohár 2016-01-22 11:08 ` Michał Kępień 2016-02-16 14:50 ` [PATCH v3 0/5] Process Dell Instant Launch hotkey on Vostro V131 and Inspiron M5110 Michał Kępień 2016-02-16 14:50 ` [PATCH v3 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień 2016-02-16 14:50 ` [PATCH v3 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień 2016-02-16 14:50 ` [PATCH v3 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień 2016-02-16 15:17 ` Pali Rohár 2016-02-16 21:53 ` Michał Kępień 2016-02-20 1:24 ` Darren Hart 2016-02-22 8:56 ` Michał Kępień 2016-02-22 9:03 ` Pali Rohár 2016-02-22 9:13 ` Michał Kępień 2016-02-22 21:17 ` Darren Hart 2016-02-16 14:50 ` [PATCH v3 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień 2016-02-16 14:50 ` [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień 2016-02-16 15:22 ` Pali Rohár 2016-02-16 22:03 ` Michał Kępień 2016-02-17 11:42 ` Pali Rohár 2016-02-17 12:01 ` Michał Kępień 2016-02-17 12:08 ` Pali Rohár 2016-02-18 8:25 ` Michał Kępień 2016-02-24 7:20 ` [PATCH v4 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień 2016-02-24 7:20 ` [PATCH v4 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień 2016-02-29 12:52 ` Pali Rohár 2016-02-29 20:22 ` Michał Kępień 2016-02-29 20:24 ` Pali Rohár 2016-02-29 20:41 ` Michał Kępień 2016-02-29 22:50 ` Darren Hart 2016-03-02 11:49 ` Michał Kępień 2016-03-03 11:38 ` Pali Rohár 2016-02-24 7:20 ` [PATCH v4 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień 2016-02-29 12:53 ` Pali Rohár 2016-02-24 7:20 ` [PATCH v4 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień 2016-02-29 12:57 ` Pali Rohár 2016-02-24 7:20 ` [PATCH v4 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień 2016-02-29 12:59 ` Pali Rohár 2016-02-29 20:31 ` Michał Kępień 2016-02-29 20:39 ` Pali Rohár 2016-02-29 20:49 ` Michał Kępień 2016-02-29 20:56 ` Pali Rohár 2016-02-29 23:00 ` Darren Hart 2016-02-29 23:00 ` Darren Hart 2016-03-02 12:35 ` Michał Kępień 2016-03-03 17:16 ` Darren Hart 2016-03-03 18:46 ` Michał Kępień 2016-03-03 20:47 ` Darren Hart 2016-02-29 23:00 ` Darren Hart 2016-02-24 7:20 ` [PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień 2016-02-29 13:00 ` Pali Rohár 2016-03-04 13:09 ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Michał Kępień 2016-03-04 13:09 ` [PATCH v5 1/5] dell-laptop: move dell_smi_error() to dell-smbios Michał Kępień 2016-03-04 13:09 ` [PATCH v5 2/5] dell-smbios: rename dell_smi_error() to dell_smbios_error() Michał Kępień 2016-03-04 13:09 ` [PATCH v5 3/5] dell-wmi: enable receiving WMI events on Dell Vostro V131 Michał Kępień 2016-03-04 13:09 ` [PATCH v5 4/5] dell-wmi: properly process Dell Instant Launch hotkey Michał Kępień 2016-03-04 13:09 ` [PATCH v5 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień 2016-03-07 8:27 ` [PATCH v5 0/5] Process Dell Instant Launch hotkey on Vostro V131 and " Pali Rohár 2016-03-08 11:20 ` Darren Hart 2015-12-04 12:55 ` [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień 2015-12-04 16:04 ` Andy Lutomirski 2015-12-04 8:48 ` Pali Rohár 2015-12-04 12:36 ` Michał Kępień
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160121145612.GA4684@eudyptula.hq.kempniu.pl \ --to=kernel@kempniu.pl \ --cc=dvhart@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mjg59@srcf.ucam.org \ --cc=pali.rohar@gmail.com \ --cc=platform-driver-x86@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.