From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
kernel-hardening@lists.openwall.com, will.deacon@arm.com,
catalin.marinas@arm.com, mark.rutland@arm.com,
leif.lindholm@linaro.org, keescook@chromium.org,
linux-kernel@vger.kernel.org, stuart.yoder@freescale.com,
bhupesh.sharma@freescale.com, arnd@arndb.de,
marc.zyngier@arm.com, christoffer.dall@linaro.org
Subject: Re: [PATCH v3 20/21] efi: stub: use high allocation for converted command line
Date: Thu, 21 Jan 2016 16:20:56 +0000 [thread overview]
Message-ID: <20160121162056.GG2510@codeblueprint.co.uk> (raw)
In-Reply-To: <1452518355-4606-22-git-send-email-ard.biesheuvel@linaro.org>
On Mon, 11 Jan, at 02:19:14PM, Ard Biesheuvel wrote:
> Before we can move the command line processing before the allocation
> of the kernel, which is required for detecting the 'nokaslr' option
> which controls that allocation, move the converted command line higher
> up in memory, to prevent it from interfering with the kernel itself.
>
> Since x86 needs the address to fit in 32 bits, use UINT_MAX as the upper
> bound there. Otherwise, use ULONG_MAX (i.e., no limit)
>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/x86/include/asm/efi.h | 2 ++
> drivers/firmware/efi/libstub/efi-stub-helper.c | 14 +++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
WARNING: multiple messages have this Message-ID (diff)
From: matt@codeblueprint.co.uk (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 20/21] efi: stub: use high allocation for converted command line
Date: Thu, 21 Jan 2016 16:20:56 +0000 [thread overview]
Message-ID: <20160121162056.GG2510@codeblueprint.co.uk> (raw)
In-Reply-To: <1452518355-4606-22-git-send-email-ard.biesheuvel@linaro.org>
On Mon, 11 Jan, at 02:19:14PM, Ard Biesheuvel wrote:
> Before we can move the command line processing before the allocation
> of the kernel, which is required for detecting the 'nokaslr' option
> which controls that allocation, move the converted command line higher
> up in memory, to prevent it from interfering with the kernel itself.
>
> Since x86 needs the address to fit in 32 bits, use UINT_MAX as the upper
> bound there. Otherwise, use ULONG_MAX (i.e., no limit)
>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/x86/include/asm/efi.h | 2 ++
> drivers/firmware/efi/libstub/efi-stub-helper.c | 14 +++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
kernel-hardening@lists.openwall.com, will.deacon@arm.com,
catalin.marinas@arm.com, mark.rutland@arm.com,
leif.lindholm@linaro.org, keescook@chromium.org,
linux-kernel@vger.kernel.org, stuart.yoder@freescale.com,
bhupesh.sharma@freescale.com, arnd@arndb.de,
marc.zyngier@arm.com, christoffer.dall@linaro.org
Subject: [kernel-hardening] Re: [PATCH v3 20/21] efi: stub: use high allocation for converted command line
Date: Thu, 21 Jan 2016 16:20:56 +0000 [thread overview]
Message-ID: <20160121162056.GG2510@codeblueprint.co.uk> (raw)
In-Reply-To: <1452518355-4606-22-git-send-email-ard.biesheuvel@linaro.org>
On Mon, 11 Jan, at 02:19:14PM, Ard Biesheuvel wrote:
> Before we can move the command line processing before the allocation
> of the kernel, which is required for detecting the 'nokaslr' option
> which controls that allocation, move the converted command line higher
> up in memory, to prevent it from interfering with the kernel itself.
>
> Since x86 needs the address to fit in 32 bits, use UINT_MAX as the upper
> bound there. Otherwise, use ULONG_MAX (i.e., no limit)
>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/x86/include/asm/efi.h | 2 ++
> drivers/firmware/efi/libstub/efi-stub-helper.c | 14 +++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
next prev parent reply other threads:[~2016-01-21 16:21 UTC|newest]
Thread overview: 207+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 13:18 [PATCH v3 00/21] arm64: implement support for KASLR Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 13:18 ` [PATCH v3 01/21] of/fdt: make memblock minimum physical address arch configurable Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 13:18 ` [PATCH v3 02/21] arm64: introduce KIMAGE_VADDR as the virtual base of the kernel region Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 16:31 ` Mark Rutland
2016-01-11 16:31 ` [kernel-hardening] " Mark Rutland
2016-01-11 16:31 ` Mark Rutland
2016-01-11 13:18 ` [PATCH v3 03/21] arm64: pgtable: add dummy pud_index() and pmd_index() definitions Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 17:40 ` Mark Rutland
2016-01-11 17:40 ` [kernel-hardening] " Mark Rutland
2016-01-11 17:40 ` Mark Rutland
2016-01-12 17:25 ` Ard Biesheuvel
2016-01-12 17:25 ` [kernel-hardening] " Ard Biesheuvel
2016-01-12 17:25 ` Ard Biesheuvel
2016-01-11 13:18 ` [PATCH v3 04/21] arm64: decouple early fixmap init from linear mapping Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 16:09 ` Mark Rutland
2016-01-11 16:09 ` [kernel-hardening] " Mark Rutland
2016-01-11 16:09 ` Mark Rutland
2016-01-11 16:15 ` Ard Biesheuvel
2016-01-11 16:15 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 16:15 ` Ard Biesheuvel
2016-01-11 16:27 ` Mark Rutland
2016-01-11 16:27 ` [kernel-hardening] " Mark Rutland
2016-01-11 16:27 ` Mark Rutland
2016-01-11 16:51 ` Mark Rutland
2016-01-11 16:51 ` [kernel-hardening] " Mark Rutland
2016-01-11 16:51 ` Mark Rutland
2016-01-11 17:08 ` Ard Biesheuvel
2016-01-11 17:08 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 17:08 ` Ard Biesheuvel
2016-01-11 17:15 ` Ard Biesheuvel
2016-01-11 17:15 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 17:15 ` Ard Biesheuvel
2016-01-11 17:21 ` Mark Rutland
2016-01-11 17:21 ` [kernel-hardening] " Mark Rutland
2016-01-11 17:21 ` Mark Rutland
2016-01-11 13:18 ` [PATCH v3 05/21] arm64: kvm: deal with kernel symbols outside of " Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-12 12:36 ` Mark Rutland
2016-01-12 12:36 ` [kernel-hardening] " Mark Rutland
2016-01-12 12:36 ` Mark Rutland
2016-01-12 13:23 ` Ard Biesheuvel
2016-01-12 13:23 ` [kernel-hardening] " Ard Biesheuvel
2016-01-12 13:23 ` Ard Biesheuvel
2016-01-11 13:18 ` [PATCH v3 06/21] arm64: pgtable: implement static [pte|pmd|pud]_offset variants Ard Biesheuvel
2016-01-11 13:18 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:18 ` Ard Biesheuvel
2016-01-11 16:24 ` Mark Rutland
2016-01-11 16:24 ` [kernel-hardening] " Mark Rutland
2016-01-11 16:24 ` Mark Rutland
2016-01-11 17:28 ` Ard Biesheuvel
2016-01-11 17:28 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 17:28 ` Ard Biesheuvel
2016-01-11 17:31 ` Mark Rutland
2016-01-11 17:31 ` [kernel-hardening] " Mark Rutland
2016-01-11 17:31 ` Mark Rutland
2016-01-11 13:19 ` [PATCH v3 07/21] arm64: move kernel image to base of vmalloc area Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-12 18:14 ` Mark Rutland
2016-01-12 18:14 ` [kernel-hardening] " Mark Rutland
2016-01-12 18:14 ` Mark Rutland
2016-01-13 8:39 ` Ard Biesheuvel
2016-01-13 8:39 ` [kernel-hardening] " Ard Biesheuvel
2016-01-13 8:39 ` Ard Biesheuvel
2016-01-13 9:58 ` Ard Biesheuvel
2016-01-13 9:58 ` [kernel-hardening] " Ard Biesheuvel
2016-01-13 9:58 ` Ard Biesheuvel
2016-01-13 11:11 ` Mark Rutland
2016-01-13 11:11 ` [kernel-hardening] " Mark Rutland
2016-01-13 11:11 ` Mark Rutland
2016-01-13 11:14 ` Ard Biesheuvel
2016-01-13 11:14 ` [kernel-hardening] " Ard Biesheuvel
2016-01-13 11:14 ` Ard Biesheuvel
2016-01-13 13:51 ` Mark Rutland
2016-01-13 13:51 ` [kernel-hardening] " Mark Rutland
2016-01-13 13:51 ` Mark Rutland
2016-01-13 15:50 ` Ard Biesheuvel
2016-01-13 15:50 ` [kernel-hardening] " Ard Biesheuvel
2016-01-13 15:50 ` Ard Biesheuvel
2016-01-13 16:26 ` Mark Rutland
2016-01-13 16:26 ` [kernel-hardening] " Mark Rutland
2016-01-13 16:26 ` Mark Rutland
2016-01-14 18:57 ` Mark Rutland
2016-01-14 18:57 ` [kernel-hardening] " Mark Rutland
2016-01-14 18:57 ` Mark Rutland
2016-01-15 9:54 ` Ard Biesheuvel
2016-01-15 9:54 ` [kernel-hardening] " Ard Biesheuvel
2016-01-15 9:54 ` Ard Biesheuvel
2016-01-15 11:23 ` Mark Rutland
2016-01-15 11:23 ` [kernel-hardening] " Mark Rutland
2016-01-15 11:23 ` Mark Rutland
2016-01-27 14:31 ` Ard Biesheuvel
2016-01-27 14:31 ` [kernel-hardening] " Ard Biesheuvel
2016-01-27 14:31 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 08/21] arm64: add support for module PLTs Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-22 16:55 ` Mark Rutland
2016-01-22 16:55 ` [kernel-hardening] " Mark Rutland
2016-01-22 16:55 ` Mark Rutland
2016-01-22 17:06 ` Ard Biesheuvel
2016-01-22 17:06 ` [kernel-hardening] " Ard Biesheuvel
2016-01-22 17:06 ` Ard Biesheuvel
2016-01-22 17:19 ` Mark Rutland
2016-01-22 17:19 ` [kernel-hardening] " Mark Rutland
2016-01-22 17:19 ` Mark Rutland
2016-01-11 13:19 ` [PATCH v3 09/21] extable: add support for relative extables to search and sort routines Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 10/21] arm64: switch to relative exception tables Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 11/21] arm64: avoid R_AARCH64_ABS64 relocations for Image header fields Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-13 18:12 ` Mark Rutland
2016-01-13 18:12 ` [kernel-hardening] " Mark Rutland
2016-01-13 18:12 ` Mark Rutland
2016-01-13 18:48 ` Ard Biesheuvel
2016-01-13 18:48 ` [kernel-hardening] " Ard Biesheuvel
2016-01-13 18:48 ` Ard Biesheuvel
2016-01-14 8:51 ` Ard Biesheuvel
2016-01-14 8:51 ` [kernel-hardening] " Ard Biesheuvel
2016-01-14 8:51 ` Ard Biesheuvel
2016-01-14 9:05 ` Ard Biesheuvel
2016-01-14 9:05 ` [kernel-hardening] " Ard Biesheuvel
2016-01-14 9:05 ` Ard Biesheuvel
2016-01-14 10:46 ` Mark Rutland
2016-01-14 10:46 ` [kernel-hardening] " Mark Rutland
2016-01-14 10:46 ` Mark Rutland
2016-01-14 11:22 ` Ard Biesheuvel
2016-01-14 11:22 ` [kernel-hardening] " Ard Biesheuvel
2016-01-14 11:22 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 12/21] arm64: avoid dynamic relocations in early boot code Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-14 17:09 ` Mark Rutland
2016-01-14 17:09 ` [kernel-hardening] " Mark Rutland
2016-01-14 17:09 ` Mark Rutland
2016-01-11 13:19 ` [PATCH v3 13/21] arm64: allow kernel Image to be loaded anywhere in physical memory Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 14/21] arm64: redefine SWAPPER_TABLE_SHIFT for use in asm code Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 14/21] arm64: [re]define SWAPPER_TABLE_[SHIFT|SIZE] " Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:26 ` Ard Biesheuvel
2016-01-11 13:26 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:26 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 15/21] arm64: split elf relocs into a separate header Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 16/21] scripts/sortextable: add support for ET_DYN binaries Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 17/21] arm64: add support for a relocatable kernel and KASLR Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 18/21] efi: stub: implement efi_get_random_bytes() based on EFI_RNG_PROTOCOL Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-21 15:42 ` Matt Fleming
2016-01-21 15:42 ` [kernel-hardening] " Matt Fleming
2016-01-21 15:42 ` Matt Fleming
2016-01-21 16:12 ` Ard Biesheuvel
2016-01-21 16:12 ` [kernel-hardening] " Ard Biesheuvel
2016-01-21 16:12 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 19/21] efi: stub: add implementation of efi_random_alloc() Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-21 16:10 ` Matt Fleming
2016-01-21 16:10 ` [kernel-hardening] " Matt Fleming
2016-01-21 16:10 ` Matt Fleming
2016-01-21 16:16 ` Ard Biesheuvel
2016-01-21 16:16 ` [kernel-hardening] " Ard Biesheuvel
2016-01-21 16:16 ` Ard Biesheuvel
2016-01-11 13:19 ` [PATCH v3 20/21] efi: stub: use high allocation for converted command line Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-21 16:20 ` Matt Fleming [this message]
2016-01-21 16:20 ` [kernel-hardening] " Matt Fleming
2016-01-21 16:20 ` Matt Fleming
2016-01-11 13:19 ` [PATCH v3 21/21] arm64: efi: invoke EFI_RNG_PROTOCOL to supply KASLR randomness Ard Biesheuvel
2016-01-11 13:19 ` [kernel-hardening] " Ard Biesheuvel
2016-01-11 13:19 ` Ard Biesheuvel
2016-01-21 16:31 ` Matt Fleming
2016-01-21 16:31 ` [kernel-hardening] " Matt Fleming
2016-01-21 16:31 ` Matt Fleming
2016-01-11 22:07 ` [PATCH v3 00/21] arm64: implement support for KASLR Kees Cook
2016-01-11 22:07 ` [kernel-hardening] " Kees Cook
2016-01-11 22:07 ` Kees Cook
2016-01-12 7:17 ` Ard Biesheuvel
2016-01-12 7:17 ` [kernel-hardening] " Ard Biesheuvel
2016-01-12 7:17 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121162056.GG2510@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bhupesh.sharma@freescale.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=stuart.yoder@freescale.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.