* [PATCH] mtd: bcm47xxpart: limit scanned flash area on BCM47XX (MIPS) only
@ 2015-12-05 1:09 Rafał Miłecki
2016-01-23 22:45 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2015-12-05 1:09 UTC (permalink / raw)
To: Brian Norris, linux-mtd; +Cc: Hauke Mehrtens, Rafał Miłecki
We allowed using bcm47xxpart on BCM5301X arch with commit:
9e3afa5f5c7 ("mtd: bcm47xxpart: allow enabling on ARCH_BCM_5301X")
BCM5301X devices may contain some partitions in higher memory, e.g.
Netgear R8000 has board_data at 0x2600000. To detect them we should
use size limit on MIPS only.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/bcm47xxpart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c
index 92a6dd1..4450e74 100644
--- a/drivers/mtd/bcm47xxpart.c
+++ b/drivers/mtd/bcm47xxpart.c
@@ -118,8 +118,8 @@ static int bcm47xxpart_parse(struct mtd_info *master,
/* Parse block by block looking for magics */
for (offset = 0; offset <= master->size - blocksize;
offset += blocksize) {
- /* Nothing more in higher memory */
- if (offset >= 0x2000000)
+ /* Nothing more in higher memory on BCM47XX (MIPS) */
+ if (config_enabled(CONFIG_BCM47XX) && offset >= 0x2000000)
break;
if (curr_part >= BCM47XXPART_MAX_PARTS) {
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: bcm47xxpart: limit scanned flash area on BCM47XX (MIPS) only
2015-12-05 1:09 [PATCH] mtd: bcm47xxpart: limit scanned flash area on BCM47XX (MIPS) only Rafał Miłecki
@ 2016-01-23 22:45 ` Brian Norris
2016-01-24 9:31 ` Rafał Miłecki
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-01-23 22:45 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-mtd, Hauke Mehrtens
On Sat, Dec 05, 2015 at 02:09:43AM +0100, Rafał Miłecki wrote:
> We allowed using bcm47xxpart on BCM5301X arch with commit:
> 9e3afa5f5c7 ("mtd: bcm47xxpart: allow enabling on ARCH_BCM_5301X")
>
> BCM5301X devices may contain some partitions in higher memory, e.g.
> Netgear R8000 has board_data at 0x2600000. To detect them we should
> use size limit on MIPS only.
Why was the siez limit imposed in the first place? Just to make the scan more
efficient?
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Pushed to l2-mtd.git/next
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: bcm47xxpart: limit scanned flash area on BCM47XX (MIPS) only
2016-01-23 22:45 ` Brian Norris
@ 2016-01-24 9:31 ` Rafał Miłecki
0 siblings, 0 replies; 3+ messages in thread
From: Rafał Miłecki @ 2016-01-24 9:31 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Hauke Mehrtens
On 23 January 2016 at 23:45, Brian Norris <computersforpeace@gmail.com> wrote:
> On Sat, Dec 05, 2015 at 02:09:43AM +0100, Rafał Miłecki wrote:
>> We allowed using bcm47xxpart on BCM5301X arch with commit:
>> 9e3afa5f5c7 ("mtd: bcm47xxpart: allow enabling on ARCH_BCM_5301X")
>>
>> BCM5301X devices may contain some partitions in higher memory, e.g.
>> Netgear R8000 has board_data at 0x2600000. To detect them we should
>> use size limit on MIPS only.
>
> Why was the siez limit imposed in the first place? Just to make the scan more
> efficient?
That's correct, just to save a minimal amount of time.
--
Rafał
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-24 9:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-05 1:09 [PATCH] mtd: bcm47xxpart: limit scanned flash area on BCM47XX (MIPS) only Rafał Miłecki
2016-01-23 22:45 ` Brian Norris
2016-01-24 9:31 ` Rafał Miłecki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.