* [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h>
@ 2016-01-23 21:31 Brian Norris
2016-01-23 21:44 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-01-23 21:31 UTC (permalink / raw)
To: linux-mtd
Cc: Brian Norris, Sascha Hauer, Marc Kleine-Budde, Richard Weinberger
To be consistent with mkfs.jffs2, and to get this to build on my
machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>.
Fixes this error, seen on an Ubuntu 14.04 build system:
ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory
#include <attr/xattr.h>
^
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Richard Weinberger <richard@nod.at>
---
ubifs-utils/mkfs.ubifs/mkfs.ubifs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
index 27f8d0a160c3..a60052d12c46 100644
--- a/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
+++ b/ubifs-utils/mkfs.ubifs/mkfs.ubifs.c
@@ -27,7 +27,7 @@
#include "common.h"
#include <sys/types.h>
#ifndef WITHOUT_XATTR
-#include <attr/xattr.h>
+#include <sys/xattr.h>
#endif
/* Size (prime number) of hash table for link counting */
--
2.7.0.rc3.207.g0ac5344
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h>
2016-01-23 21:31 [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h> Brian Norris
@ 2016-01-23 21:44 ` Richard Weinberger
2016-01-25 4:13 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2016-01-23 21:44 UTC (permalink / raw)
To: Brian Norris, linux-mtd; +Cc: Sascha Hauer, Marc Kleine-Budde
Am 23.01.2016 um 22:31 schrieb Brian Norris:
> To be consistent with mkfs.jffs2, and to get this to build on my
> machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>.
>
> Fixes this error, seen on an Ubuntu 14.04 build system:
>
> ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory
> #include <attr/xattr.h>
The build fails because you don't have libattr-devel (or however your distro names that package).
Switching to sys/xattr.h from glibc-devel seems fine to me as mkfs.ubifs.c is using only basic xattr stuff.
Reviewed-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h>
2016-01-23 21:44 ` Richard Weinberger
@ 2016-01-25 4:13 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-01-25 4:13 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd, Sascha Hauer, Marc Kleine-Budde
On Sat, Jan 23, 2016 at 10:44:23PM +0100, Richard Weinberger wrote:
> Am 23.01.2016 um 22:31 schrieb Brian Norris:
> > To be consistent with mkfs.jffs2, and to get this to build on my
> > machine, it looks like we should use <sys/xattr.h>, not <attr/xattr.h>.
> >
> > Fixes this error, seen on an Ubuntu 14.04 build system:
> >
> > ubifs-utils/mkfs.ubifs/mkfs.ubifs.c:30:24: fatal error: attr/xattr.h: No such file or directory
> > #include <attr/xattr.h>
>
> The build fails because you don't have libattr-devel (or however your distro names that package).
> Switching to sys/xattr.h from glibc-devel seems fine to me as mkfs.ubifs.c is using only basic xattr stuff.
Ah, thanks for the clarification.
> Reviewed-by: Richard Weinberger <richard@nod.at>
Pushed to mtd-utils.git.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 4:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-23 21:31 [mtd-utils PATCH] mkfs.ubifs: <sys/xattr.h>, not <attr/xattr.h> Brian Norris
2016-01-23 21:44 ` Richard Weinberger
2016-01-25 4:13 ` Brian Norris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.