* [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32()
@ 2016-01-25 3:38 Bin Meng
2016-01-25 3:47 ` Marek Vasut
2016-02-02 20:02 ` Stefano Babic
0 siblings, 2 replies; 3+ messages in thread
From: Bin Meng @ 2016-01-25 3:38 UTC (permalink / raw)
To: u-boot
Currently when building mxsboot on certain machines it reports:
HOSTCC tools/mxsboot
tools/mxsboot.c: In function 'mx28_create_sd_image':
tools/mxsboot.c:560: warning: implicit declaration of function 'htole32'
/tmp/cchLIV6q.o: In function 'main':
mxsboot.c:(.text+0x6d8): undefined reference to 'htole32'
mxsboot.c:(.text+0x6e7): undefined reference to 'htole32'
mxsboot.c:(.text+0x6f6): undefined reference to 'htole32'
mxsboot.c:(.text+0x705): undefined reference to 'htole32'
mxsboot.c:(.text+0x711): undefined reference to 'htole32'
/tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to
'htole32' follow
collect2: ld returned 1 exit status
make[1]: *** [tools/mxsboot] Error 1
make: *** [tools] Error 2
The solution is to use cpu_to_le32() instead which is more portable,
just like other U-Boot tools [1] do.
[1] http://lists.denx.de/pipermail/u-boot/2014-October/192919.html
Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
tools/mxsboot.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tools/mxsboot.c b/tools/mxsboot.c
index 3434c81..457f435 100644
--- a/tools/mxsboot.c
+++ b/tools/mxsboot.c
@@ -557,15 +557,15 @@ static int mx28_create_sd_image(int infd, int outfd)
cb = (struct mx28_sd_config_block *)buf;
- cb->signature = htole32(0x00112233);
- cb->primary_boot_tag = htole32(0x1);
- cb->secondary_boot_tag = htole32(0x1);
- cb->num_copies = htole32(1);
- cb->drv_info[0].chip_num = htole32(0x0);
- cb->drv_info[0].drive_type = htole32(0x0);
- cb->drv_info[0].tag = htole32(0x1);
- cb->drv_info[0].first_sector_number = htole32(sd_sector + 4);
- cb->drv_info[0].sector_count = htole32((size - 4) / 512);
+ cb->signature = cpu_to_le32(0x00112233);
+ cb->primary_boot_tag = cpu_to_le32(0x1);
+ cb->secondary_boot_tag = cpu_to_le32(0x1);
+ cb->num_copies = cpu_to_le32(1);
+ cb->drv_info[0].chip_num = cpu_to_le32(0x0);
+ cb->drv_info[0].drive_type = cpu_to_le32(0x0);
+ cb->drv_info[0].tag = cpu_to_le32(0x1);
+ cb->drv_info[0].first_sector_number = cpu_to_le32(sd_sector + 4);
+ cb->drv_info[0].sector_count = cpu_to_le32((size - 4) / 512);
wr_size = write(outfd, buf, size);
if (wr_size != size) {
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32()
2016-01-25 3:38 [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32() Bin Meng
@ 2016-01-25 3:47 ` Marek Vasut
2016-02-02 20:02 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2016-01-25 3:47 UTC (permalink / raw)
To: u-boot
On Monday, January 25, 2016 at 04:38:32 AM, Bin Meng wrote:
> Currently when building mxsboot on certain machines it reports:
>
> HOSTCC tools/mxsboot
> tools/mxsboot.c: In function 'mx28_create_sd_image':
> tools/mxsboot.c:560: warning: implicit declaration of function 'htole32'
> /tmp/cchLIV6q.o: In function 'main':
> mxsboot.c:(.text+0x6d8): undefined reference to 'htole32'
> mxsboot.c:(.text+0x6e7): undefined reference to 'htole32'
> mxsboot.c:(.text+0x6f6): undefined reference to 'htole32'
> mxsboot.c:(.text+0x705): undefined reference to 'htole32'
> mxsboot.c:(.text+0x711): undefined reference to 'htole32'
> /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to
> 'htole32' follow
> collect2: ld returned 1 exit status
> make[1]: *** [tools/mxsboot] Error 1
> make: *** [tools] Error 2
>
> The solution is to use cpu_to_le32() instead which is more portable,
> just like other U-Boot tools [1] do.
>
> [1] http://lists.denx.de/pipermail/u-boot/2014-October/192919.html
>
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Marek Vasut <marex@denx.de>
Thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32()
2016-01-25 3:38 [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32() Bin Meng
2016-01-25 3:47 ` Marek Vasut
@ 2016-02-02 20:02 ` Stefano Babic
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2016-02-02 20:02 UTC (permalink / raw)
To: u-boot
On 25/01/2016 04:38, Bin Meng wrote:
> Currently when building mxsboot on certain machines it reports:
>
> HOSTCC tools/mxsboot
> tools/mxsboot.c: In function 'mx28_create_sd_image':
> tools/mxsboot.c:560: warning: implicit declaration of function 'htole32'
> /tmp/cchLIV6q.o: In function 'main':
> mxsboot.c:(.text+0x6d8): undefined reference to 'htole32'
> mxsboot.c:(.text+0x6e7): undefined reference to 'htole32'
> mxsboot.c:(.text+0x6f6): undefined reference to 'htole32'
> mxsboot.c:(.text+0x705): undefined reference to 'htole32'
> mxsboot.c:(.text+0x711): undefined reference to 'htole32'
> /tmp/cchLIV6q.o:mxsboot.c:(.text+0x71d): more undefined references to
> 'htole32' follow
> collect2: ld returned 1 exit status
> make[1]: *** [tools/mxsboot] Error 1
> make: *** [tools] Error 2
>
> The solution is to use cpu_to_le32() instead which is more portable,
> just like other U-Boot tools [1] do.
>
> [1] http://lists.denx.de/pipermail/u-boot/2014-October/192919.html
>
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-02 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 3:38 [U-Boot] [PATCH] tools: mxsboot: Use more portable cpu_to_le32() Bin Meng
2016-01-25 3:47 ` Marek Vasut
2016-02-02 20:02 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.