* [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc
@ 2016-01-13 14:31 Daniel Vetter
2016-01-13 14:57 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-25 15:45 ` [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-01-13 14:31 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Daniel Vetter, Maxime Ripard, Laurent Pinchart, DRI Development,
Daniel Vetter
This shouldn't be used by atomic drivers any more, it confuses the
state tracking.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/drm_crtc_helper.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index a02a7f9a6a9d..a278fbbe23e0 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -220,6 +220,15 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
* disconnected connectors. Then it will disable all unused encoders and CRTCs
* either by calling their disable callback if available or by calling their
* dpms callback with DRM_MODE_DPMS_OFF.
+ *
+ * NOTE:
+ *
+ * This function is part of the legacy modeset helper library and will cause
+ * major confusion with atomic drivers. This is because atomic helpers guarantee
+ * to never call ->disable() hooks on a disabled function, or ->enable() hooks
+ * on an enabled functions. drm_helper_disable_unused_functions() on the other
+ * hand throws such guarantees into the wind and calls disable hooks
+ * unconditionally on unused functions.
*/
void drm_helper_disable_unused_functions(struct drm_device *dev)
{
--
2.7.0.rc3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ warning: Fi.CI.BAT
2016-01-13 14:31 [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
@ 2016-01-13 14:57 ` Patchwork
2016-01-25 15:44 ` Daniel Vetter
2016-01-25 15:45 ` [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-01-13 14:57 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Summary ==
Built on 4d09810b01441f9124c072a866f608b748f92f6c drm-intel-nightly: 2016y-01m-13d-12h-32m-08s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
pass -> DMESG-WARN (skl-i5k-2) UNSTABLE
pass -> DMESG-WARN (bdw-ultra)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
dmesg-warn -> PASS (ilk-hp8440p)
bdw-nuci7 total:138 pass:129 dwarn:0 dfail:0 fail:0 skip:9
bdw-ultra total:138 pass:131 dwarn:1 dfail:0 fail:0 skip:6
bsw-nuc-2 total:141 pass:115 dwarn:2 dfail:0 fail:0 skip:24
hsw-brixbox total:141 pass:134 dwarn:0 dfail:0 fail:0 skip:7
hsw-gt2 total:141 pass:137 dwarn:0 dfail:0 fail:0 skip:4
hsw-xps12 total:138 pass:133 dwarn:1 dfail:0 fail:0 skip:4
ilk-hp8440p total:141 pass:101 dwarn:3 dfail:0 fail:0 skip:37
ivb-t430s total:135 pass:122 dwarn:3 dfail:4 fail:0 skip:6
skl-i5k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8
skl-i7k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8
snb-dellxps total:141 pass:122 dwarn:5 dfail:0 fail:0 skip:14
snb-x220t total:141 pass:122 dwarn:5 dfail:0 fail:1 skip:13
Results at /archive/results/CI_IGT_test/Patchwork_1169/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ warning: Fi.CI.BAT
2016-01-13 14:57 ` ✗ warning: Fi.CI.BAT Patchwork
@ 2016-01-25 15:44 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-01-25 15:44 UTC (permalink / raw)
To: Patchwork; +Cc: Daniel Vetter, intel-gfx
On Wed, Jan 13, 2016 at 02:57:33PM -0000, Patchwork wrote:
> == Summary ==
>
> Built on 4d09810b01441f9124c072a866f608b748f92f6c drm-intel-nightly: 2016y-01m-13d-12h-32m-08s UTC integration manifest
>
> Test gem_storedw_loop:
> Subgroup basic-render:
> pass -> DMESG-WARN (skl-i5k-2) UNSTABLE
> pass -> DMESG-WARN (bdw-ultra)
This was https://bugs.freedesktop.org/show_bug.cgi?id=93693 but has since
been fixed.
-Daniel
> Test kms_flip:
> Subgroup basic-flip-vs-dpms:
> dmesg-warn -> PASS (ilk-hp8440p)
>
> bdw-nuci7 total:138 pass:129 dwarn:0 dfail:0 fail:0 skip:9
> bdw-ultra total:138 pass:131 dwarn:1 dfail:0 fail:0 skip:6
> bsw-nuc-2 total:141 pass:115 dwarn:2 dfail:0 fail:0 skip:24
> hsw-brixbox total:141 pass:134 dwarn:0 dfail:0 fail:0 skip:7
> hsw-gt2 total:141 pass:137 dwarn:0 dfail:0 fail:0 skip:4
> hsw-xps12 total:138 pass:133 dwarn:1 dfail:0 fail:0 skip:4
> ilk-hp8440p total:141 pass:101 dwarn:3 dfail:0 fail:0 skip:37
> ivb-t430s total:135 pass:122 dwarn:3 dfail:4 fail:0 skip:6
> skl-i5k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8
> skl-i7k-2 total:141 pass:131 dwarn:2 dfail:0 fail:0 skip:8
> snb-dellxps total:141 pass:122 dwarn:5 dfail:0 fail:0 skip:14
> snb-x220t total:141 pass:122 dwarn:5 dfail:0 fail:1 skip:13
>
> Results at /archive/results/CI_IGT_test/Patchwork_1169/
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc
2016-01-13 14:31 [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
2016-01-13 14:57 ` ✗ warning: Fi.CI.BAT Patchwork
@ 2016-01-25 15:45 ` Daniel Vetter
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-01-25 15:45 UTC (permalink / raw)
To: Intel Graphics Development
Cc: Daniel Vetter, Maxime Ripard, Laurent Pinchart, DRI Development,
Daniel Vetter
On Wed, Jan 13, 2016 at 03:31:16PM +0100, Daniel Vetter wrote:
> This shouldn't be used by atomic drivers any more, it confuses the
> state tracking.
>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Applied this one to drm-misc.
-Daniel
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index a02a7f9a6a9d..a278fbbe23e0 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -220,6 +220,15 @@ static void __drm_helper_disable_unused_functions(struct drm_device *dev)
> * disconnected connectors. Then it will disable all unused encoders and CRTCs
> * either by calling their disable callback if available or by calling their
> * dpms callback with DRM_MODE_DPMS_OFF.
> + *
> + * NOTE:
> + *
> + * This function is part of the legacy modeset helper library and will cause
> + * major confusion with atomic drivers. This is because atomic helpers guarantee
> + * to never call ->disable() hooks on a disabled function, or ->enable() hooks
> + * on an enabled functions. drm_helper_disable_unused_functions() on the other
> + * hand throws such guarantees into the wind and calls disable hooks
> + * unconditionally on unused functions.
> */
> void drm_helper_disable_unused_functions(struct drm_device *dev)
> {
> --
> 2.7.0.rc3
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-25 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13 14:31 [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
2016-01-13 14:57 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-25 15:44 ` Daniel Vetter
2016-01-25 15:45 ` [PATCH] drm/crtc-helper: Add caveat to disable_unused_functions doc Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.