* [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms
@ 2016-01-26 19:21 Darrick J. Wong
2016-01-26 19:49 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2016-01-26 19:21 UTC (permalink / raw)
To: Brian Foster; +Cc: Eric Sandeen, xfs
Since the checksum function and the field are both __le32, don't
perform endian conversion when comparing the two. This fixes mount
failures on ppc64.
v2: fix the other crc comparison
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_log_recover.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index da37beb..594f7e6 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -4491,7 +4491,7 @@ xlog_recover_process(
* know precisely what failed.
*/
if (pass == XLOG_RECOVER_CRCPASS) {
- if (rhead->h_crc && crc != le32_to_cpu(rhead->h_crc))
+ if (rhead->h_crc && crc != rhead->h_crc)
return -EFSBADCRC;
return 0;
}
@@ -4502,7 +4502,7 @@ xlog_recover_process(
* zero CRC check prevents warnings from being emitted when upgrading
* the kernel from one that does not add CRCs by default.
*/
- if (crc != le32_to_cpu(rhead->h_crc)) {
+ if (crc != rhead->h_crc) {
if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
xfs_alert(log->l_mp,
"log record CRC mismatch: found 0x%x, expected 0x%x.",
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms
2016-01-26 19:21 [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms Darrick J. Wong
@ 2016-01-26 19:49 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2016-01-26 19:49 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Tue, Jan 26, 2016 at 11:21:05AM -0800, Darrick J. Wong wrote:
> Since the checksum function and the field are both __le32, don't
> perform endian conversion when comparing the two. This fixes mount
> failures on ppc64.
>
> v2: fix the other crc comparison
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Thanks!
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_log_recover.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index da37beb..594f7e6 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -4491,7 +4491,7 @@ xlog_recover_process(
> * know precisely what failed.
> */
> if (pass == XLOG_RECOVER_CRCPASS) {
> - if (rhead->h_crc && crc != le32_to_cpu(rhead->h_crc))
> + if (rhead->h_crc && crc != rhead->h_crc)
> return -EFSBADCRC;
> return 0;
> }
> @@ -4502,7 +4502,7 @@ xlog_recover_process(
> * zero CRC check prevents warnings from being emitted when upgrading
> * the kernel from one that does not add CRCs by default.
> */
> - if (crc != le32_to_cpu(rhead->h_crc)) {
> + if (crc != rhead->h_crc) {
> if (rhead->h_crc || xfs_sb_version_hascrc(&log->l_mp->m_sb)) {
> xfs_alert(log->l_mp,
> "log record CRC mismatch: found 0x%x, expected 0x%x.",
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-26 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-26 19:21 [PATCH v2] xfs: fix endianness error when checking log block crc on big endian platforms Darrick J. Wong
2016-01-26 19:49 ` Brian Foster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.