From: Andi Shyti <andi.shyti@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()
Date: Wed, 27 Jan 2016 11:12:14 +0900 [thread overview]
Message-ID: <20160127021214.GG14296@samsunx.samsung> (raw)
In-Reply-To: <56A82331.5050403@osg.samsung.com>
> >> if (tm->tm_year < 100) {
> >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> >>- 1900 + tm->tm_year);
> >>+ dev_warn(info->dev,
> >>+ "RTC can't handle year %d. Assume it's 2000\n",
> >>+ 1900 + tm->tm_year);
> >> return -EINVAL;
> >
> >Because we are returning an error value, why not use dev_err()?
> >
>
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.
>
> If you don't mind I plan to do it as a follow up patch to avoid having
> to resend the whole series only for this change.
Fine for me!
Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()
Date: Wed, 27 Jan 2016 11:12:14 +0900 [thread overview]
Message-ID: <20160127021214.GG14296@samsunx.samsung> (raw)
In-Reply-To: <56A82331.5050403@osg.samsung.com>
> >> if (tm->tm_year < 100) {
> >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> >>- 1900 + tm->tm_year);
> >>+ dev_warn(info->dev,
> >>+ "RTC can't handle year %d. Assume it's 2000\n",
> >>+ 1900 + tm->tm_year);
> >> return -EINVAL;
> >
> >Because we are returning an error value, why not use dev_err()?
> >
>
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.
>
> If you don't mind I plan to do it as a follow up patch to avoid having
> to resend the whole series only for this change.
Fine for me!
Andi
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-01-27 2:12 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 19:20 [PATCH v3 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-26 19:20 ` Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-26 19:20 ` [PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:19 ` Andi Shyti
2016-01-27 1:19 ` [rtc-linux] " Andi Shyti
2016-01-26 19:20 ` [PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:20 ` Andi Shyti
2016-01-27 1:20 ` [rtc-linux] " Andi Shyti
2016-01-26 19:20 ` [PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:21 ` Andi Shyti
2016-01-27 1:21 ` [rtc-linux] " Andi Shyti
2016-01-26 19:20 ` [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:21 ` Andi Shyti
2016-01-27 1:21 ` [rtc-linux] " Andi Shyti
2016-01-27 1:47 ` Krzysztof Kozlowski
2016-01-27 1:47 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:53 ` Krzysztof Kozlowski
2016-01-27 1:53 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:59 ` Krzysztof Kozlowski
2016-01-27 1:59 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-27 2:24 ` Javier Martinez Canillas
2016-01-27 2:24 ` Javier Martinez Canillas
2016-01-27 2:24 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 2:22 ` Andi Shyti
2016-01-27 2:22 ` [rtc-linux] " Andi Shyti
2016-01-26 19:20 ` [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:22 ` Andi Shyti
2016-01-27 1:22 ` [rtc-linux] " Andi Shyti
2016-01-27 1:53 ` Javier Martinez Canillas
2016-01-27 1:53 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 2:05 ` Krzysztof Kozlowski
2016-01-27 2:05 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-27 2:20 ` Javier Martinez Canillas
2016-01-27 2:20 ` Javier Martinez Canillas
2016-01-27 2:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 2:35 ` Andi Shyti
2016-01-27 2:35 ` [rtc-linux] " Andi Shyti
2016-01-27 2:42 ` Javier Martinez Canillas
2016-01-27 2:42 ` Javier Martinez Canillas
2016-01-27 2:42 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 2:46 ` Alexandre Belloni
2016-01-27 2:46 ` [rtc-linux] " Alexandre Belloni
2016-01-27 2:50 ` Javier Martinez Canillas
2016-01-27 2:50 ` Javier Martinez Canillas
2016-01-27 2:50 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 2:12 ` Andi Shyti [this message]
2016-01-27 2:12 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-27 1:22 ` Andi Shyti
2016-01-27 1:22 ` [rtc-linux] " Andi Shyti
2016-01-27 2:09 ` Krzysztof Kozlowski
2016-01-27 2:09 ` [rtc-linux] " Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
2016-01-26 19:20 ` [PATCH v3 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-26 19:20 ` Javier Martinez Canillas
2016-01-26 19:20 ` [rtc-linux] " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127021214.GG14296@samsunx.samsung \
--to=andi.shyti@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.