* [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init()
@ 2015-12-26 22:16 Jean-Christophe Dubois
2016-01-17 17:53 ` Jean-Christophe DUBOIS
0 siblings, 1 reply; 4+ messages in thread
From: Jean-Christophe Dubois @ 2015-12-26 22:16 UTC (permalink / raw)
To: linux-arm-kernel
The wrong pointer is passed to the ioumap function in the cleanup path
Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
---
arch/arm/mach-imx/pm-imx6.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
index 4470376..58924b3 100644
--- a/arch/arm/mach-imx/pm-imx6.c
+++ b/arch/arm/mach-imx/pm-imx6.c
@@ -561,13 +561,13 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
goto put_node;
pl310_cache_map_failed:
- iounmap(&pm_info->gpc_base.vbase);
+ iounmap(pm_info->gpc_base.vbase);
gpc_map_failed:
- iounmap(&pm_info->iomuxc_base.vbase);
+ iounmap(pm_info->iomuxc_base.vbase);
iomuxc_map_failed:
- iounmap(&pm_info->src_base.vbase);
+ iounmap(pm_info->src_base.vbase);
src_map_failed:
- iounmap(&pm_info->mmdc_base.vbase);
+ iounmap(pm_info->mmdc_base.vbase);
put_node:
of_node_put(node);
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init()
2015-12-26 22:16 [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init() Jean-Christophe Dubois
@ 2016-01-17 17:53 ` Jean-Christophe DUBOIS
2016-01-18 9:43 ` Lucas Stach
2016-01-28 6:36 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Jean-Christophe DUBOIS @ 2016-01-17 17:53 UTC (permalink / raw)
To: linux-arm-kernel
Shawn, Sascha,
Are you OK with this patch?
JC
Le 26/12/2015 23:16, Jean-Christophe Dubois a ?crit :
> The wrong pointer is passed to the ioumap function in the cleanup path
>
> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
> ---
> arch/arm/mach-imx/pm-imx6.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> index 4470376..58924b3 100644
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -561,13 +561,13 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
> goto put_node;
>
> pl310_cache_map_failed:
> - iounmap(&pm_info->gpc_base.vbase);
> + iounmap(pm_info->gpc_base.vbase);
> gpc_map_failed:
> - iounmap(&pm_info->iomuxc_base.vbase);
> + iounmap(pm_info->iomuxc_base.vbase);
> iomuxc_map_failed:
> - iounmap(&pm_info->src_base.vbase);
> + iounmap(pm_info->src_base.vbase);
> src_map_failed:
> - iounmap(&pm_info->mmdc_base.vbase);
> + iounmap(pm_info->mmdc_base.vbase);
> put_node:
> of_node_put(node);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init()
2016-01-17 17:53 ` Jean-Christophe DUBOIS
@ 2016-01-18 9:43 ` Lucas Stach
2016-01-28 6:36 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2016-01-18 9:43 UTC (permalink / raw)
To: linux-arm-kernel
Am Sonntag, den 17.01.2016, 18:53 +0100 schrieb Jean-Christophe DUBOIS:
> Shawn, Sascha,
>
> Are you OK with this patch?
>
> JC
>
Looks good.
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Le 26/12/2015 23:16, Jean-Christophe Dubois a ?crit :
> > The wrong pointer is passed to the ioumap function in the cleanup path
> >
> > Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
> > ---
> > arch/arm/mach-imx/pm-imx6.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> > index 4470376..58924b3 100644
> > --- a/arch/arm/mach-imx/pm-imx6.c
> > +++ b/arch/arm/mach-imx/pm-imx6.c
> > @@ -561,13 +561,13 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
> > goto put_node;
> >
> > pl310_cache_map_failed:
> > - iounmap(&pm_info->gpc_base.vbase);
> > + iounmap(pm_info->gpc_base.vbase);
> > gpc_map_failed:
> > - iounmap(&pm_info->iomuxc_base.vbase);
> > + iounmap(pm_info->iomuxc_base.vbase);
> > iomuxc_map_failed:
> > - iounmap(&pm_info->src_base.vbase);
> > + iounmap(pm_info->src_base.vbase);
> > src_map_failed:
> > - iounmap(&pm_info->mmdc_base.vbase);
> > + iounmap(pm_info->mmdc_base.vbase);
> > put_node:
> > of_node_put(node);
> >
>
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init()
2016-01-17 17:53 ` Jean-Christophe DUBOIS
2016-01-18 9:43 ` Lucas Stach
@ 2016-01-28 6:36 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-01-28 6:36 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Jan 17, 2016 at 06:53:05PM +0100, Jean-Christophe DUBOIS wrote:
> Shawn, Sascha,
>
> Are you OK with this patch?
>
> JC
>
> Le 26/12/2015 23:16, Jean-Christophe Dubois a ?crit :
> >The wrong pointer is passed to the ioumap function in the cleanup path
> >
> >Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-28 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-26 22:16 [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init() Jean-Christophe Dubois
2016-01-17 17:53 ` Jean-Christophe DUBOIS
2016-01-18 9:43 ` Lucas Stach
2016-01-28 6:36 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.