All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: dann frazier <dann.frazier@canonical.com>,
	Duc Dang <dhdang@apm.com>, Kumar Sankaran <ksankaran@apm.com>,
	Loc Ho <lho@apm.com>, Feng Kan <fkan@apm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Disallow combination of ARCH_XGENE and 16K page size
Date: Thu, 28 Jan 2016 11:08:20 +0000	[thread overview]
Message-ID: <20160128110820.GE30928@arm.com> (raw)
In-Reply-To: <20160128103441.GS14823@e104818-lin.cambridge.arm.com>

On Thu, Jan 28, 2016 at 10:34:41AM +0000, Catalin Marinas wrote:
> On Wed, Jan 27, 2016 at 04:10:30PM -0700, dann frazier wrote:
> > 16K page size is an optional feature of the architecture, and is not
> > supported by the X-Gene SoC family.
> > 
> > Signed-off-by: dann frazier <dann.frazier@canonical.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 21074f6..b241290 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -133,6 +133,7 @@ config ARCH_VEXPRESS
> >  
> >  config ARCH_XGENE
> >  	bool "AppliedMicro X-Gene SOC Family"
> > +	depends on !ARM64_16K_PAGES
> >  	help
> >  	  This enables support for AppliedMicro X-Gene SOC Family
> 
> This would be the case on Juno as well. But maybe at some point the
> X-Gene family would gain a CPU with such support.
> 
> Anyway, I would rather make 16K pages depend on EXPERT, make it a bit
> harder to enable. We've had a few questions recently about enabling it
> on CPUs that don't have such feature.

I thought there was also a suggestion that we could fail gracefully in
the EFI stub if we detected an unsupported page size?

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Disallow combination of ARCH_XGENE and 16K page size
Date: Thu, 28 Jan 2016 11:08:20 +0000	[thread overview]
Message-ID: <20160128110820.GE30928@arm.com> (raw)
In-Reply-To: <20160128103441.GS14823@e104818-lin.cambridge.arm.com>

On Thu, Jan 28, 2016 at 10:34:41AM +0000, Catalin Marinas wrote:
> On Wed, Jan 27, 2016 at 04:10:30PM -0700, dann frazier wrote:
> > 16K page size is an optional feature of the architecture, and is not
> > supported by the X-Gene SoC family.
> > 
> > Signed-off-by: dann frazier <dann.frazier@canonical.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > index 21074f6..b241290 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -133,6 +133,7 @@ config ARCH_VEXPRESS
> >  
> >  config ARCH_XGENE
> >  	bool "AppliedMicro X-Gene SOC Family"
> > +	depends on !ARM64_16K_PAGES
> >  	help
> >  	  This enables support for AppliedMicro X-Gene SOC Family
> 
> This would be the case on Juno as well. But maybe at some point the
> X-Gene family would gain a CPU with such support.
> 
> Anyway, I would rather make 16K pages depend on EXPERT, make it a bit
> harder to enable. We've had a few questions recently about enabling it
> on CPUs that don't have such feature.

I thought there was also a suggestion that we could fail gracefully in
the EFI stub if we detected an unsupported page size?

Will

  reply	other threads:[~2016-01-28 11:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27 23:10 [PATCH] arm64: Disallow combination of ARCH_XGENE and 16K page size dann frazier
2016-01-27 23:10 ` dann frazier
2016-01-28 10:34 ` Catalin Marinas
2016-01-28 10:34   ` Catalin Marinas
2016-01-28 11:08   ` Will Deacon [this message]
2016-01-28 11:08     ` Will Deacon
2016-01-28 11:20     ` Mark Rutland
2016-01-28 11:20       ` Mark Rutland
2016-01-28 14:50       ` Jeremy Linton
2016-01-28 14:50         ` Jeremy Linton
2016-01-28 11:27     ` Suzuki K. Poulose
2016-01-28 11:27       ` Suzuki K. Poulose
2016-01-28 11:30       ` Ard Biesheuvel
2016-01-28 11:30         ` Ard Biesheuvel
2016-01-28 11:34         ` Suzuki K. Poulose
2016-01-28 11:34           ` Suzuki K. Poulose
2016-01-28 11:24 ` Mark Rutland
2016-01-28 11:24   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128110820.GE30928@arm.com \
    --to=will.deacon@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dann.frazier@canonical.com \
    --cc=dhdang@apm.com \
    --cc=fkan@apm.com \
    --cc=ksankaran@apm.com \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.